Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

fix(photos):floor-upload-progress-percentage

Aswin Asok716801a7794d
diff --git a/web/apps/photos/tests/upload-progress-percent.test.ts b/web/apps/photos/tests/upload-progress-percent.test.ts
new file mode 100644
index 0000000000..7f8e24e9d8
--- /dev/null
+++ b/web/apps/photos/tests/upload-progress-percent.test.ts
@@ -0,0 +1,14 @@
+import { normalizePercent } from "ente-gallery/components/upload-progress/helpers";
+import { expect, test } from "vitest";
+
+test("floors upload percentages and clamps them to the valid range", () => {
+ const screenshotProgress = (2716 / 2721) * 100;
+ expect(Math.round(screenshotProgress)).toBe(100);
+ expect(normalizePercent(screenshotProgress)).toBe(99);
+ expect(normalizePercent(99.999)).toBe(99);
+ expect(normalizePercent(42.6)).toBe(42);
+ expect(normalizePercent(100)).toBe(100);
+ expect(normalizePercent(101)).toBe(100);
+ expect(normalizePercent(-1)).toBe(0);
+ expect(normalizePercent(NaN)).toBe(0);
+});
diff --git a/web/packages/gallery/components/upload-progress/helpers.ts b/web/packages/gallery/components/upload-progress/helpers.ts
index 20fc912b23..ccf2b559f4 100644
--- a/web/packages/gallery/components/upload-progress/helpers.ts
+++ b/web/packages/gallery/components/upload-progress/helpers.ts
@@ -125,4 +125,4 @@ export const uploadCountsText = ({
};
export const normalizePercent = (value: number) =>
- Math.min(100, Math.max(0, Math.round(value || 0)));
+ Math.min(100, Math.max(0, Math.floor(value || 0)));