Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Improve Space error logging

Anand Baburajan783897906a4d
diff --git a/web/apps/space/src/pages/passkeys/verify.tsx b/web/apps/space/src/pages/passkeys/verify.tsx
index 3e24e397f5..6509a5deef 100644
--- a/web/apps/space/src/pages/passkeys/verify.tsx
+++ b/web/apps/space/src/pages/passkeys/verify.tsx
@@ -2,6 +2,7 @@ import { SpacePageMeta } from "components/SpacePageMeta";
import { SpaceRouteFallback } from "components/SpaceRouteFallback";
import { savedPartialLocalUser } from "ente-accounts-rs/services/accounts-db";
import { openPasskeyVerificationURL } from "ente-accounts-rs/services/passkey";
+import log from "ente-base/log";
import React, { useEffect, useState } from "react";
import {
PasskeyVerificationScreen,
@@ -108,7 +109,7 @@ const Page: React.FC = () => {
clearPasskeyVerification();
await routeAfterCompletedLogin(router, refreshProfile);
} catch (error) {
- console.error("Space passkey status check failed", error);
+ log.error("Space passkey status check failed", error);
setErrorMessage(passkeyErrorMessage(error));
setStatus("waiting");
}
diff --git a/web/apps/space/src/services/spaceLogout.ts b/web/apps/space/src/services/spaceLogout.ts
index 0a74a6636f..e2ecf3e391 100644
--- a/web/apps/space/src/services/spaceLogout.ts
+++ b/web/apps/space/src/services/spaceLogout.ts
@@ -1,4 +1,5 @@
import { accountLogout } from "ente-accounts-rs/services/logout";
+import log from "ente-base/log";
import {
clearSpaceBrowserSession,
revokeSpaceBrowserSessions,
@@ -6,6 +7,14 @@ import {
export const spaceLogout = async () => {
await revokeSpaceBrowserSessions();
- clearSpaceBrowserSession();
+ try {
+ clearSpaceBrowserSession();
+ } catch (error) {
+ log.error(
+ "Ignoring error during logout (Space browser session)",
+ error,
+ );
+ }
+ // accountLogout() is used to clear the remaining account state and browser caches
await accountLogout();
};