Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

vecdb: prune redundant tests

laurenspriem7d874f047bd7
diff --git a/rust/crates/ml/src/vecdb/arena.rs b/rust/crates/ml/src/vecdb/arena.rs
index 8c98b2aceb..e3d1a49936 100644
--- a/rust/crates/ml/src/vecdb/arena.rs
+++ b/rust/crates/ml/src/vecdb/arena.rs
@@ -440,24 +440,18 @@ mod tests {
}
#[test]
- fn grows_across_chunks_without_moving_existing_vectors() {
+ fn grows_across_chunks_with_correct_addressing() {
let mut arena = VectorArena::new(8).unwrap();
- arena.upsert("key-0", &seeded_vector(0, 8)).unwrap();
- let first_vector_address = arena.vector_lanes(0).as_ptr() as usize;
- for index in 1..4100u64 {
+ for index in 0..4100u64 {
arena
.upsert(&format!("key-{index}"), &seeded_vector(index, 8))
.unwrap();
}
assert_eq!(arena.slot_count(), 4100);
assert_eq!(arena.live_count(), 4100);
- assert_eq!(arena.chunks.len(), 2);
- assert_eq!(
- arena.vector_lanes(0).as_ptr() as usize,
- first_vector_address
- );
assert_eq!(arena.slot_of_key("key-4099"), Some(4099));
assert_eq!(arena.key_of_slot(4097), Some("key-4097"));
+ assert_eq!(arena.vector_values(0), seeded_vector(0, 8));
assert_eq!(arena.vector_values(4099), seeded_vector(4099, 8));
}
diff --git a/rust/crates/ml/src/vecdb/crc.rs b/rust/crates/ml/src/vecdb/crc.rs
index 831703900b..dd8b79fd1b 100644
--- a/rust/crates/ml/src/vecdb/crc.rs
+++ b/rust/crates/ml/src/vecdb/crc.rs
@@ -90,14 +90,6 @@ mod tests {
crc ^ INITIAL_STATE
}
- fn byte_at_a_time(bytes: &[u8]) -> u32 {
- let mut state = INITIAL_STATE;
- for &byte in bytes {
- state = TABLES[0][((state ^ byte as u32) & 0xFF) as usize] ^ (state >> 8);
- }
- state ^ INITIAL_STATE
- }
-
fn seeded_bytes(seed: u64, len: usize) -> Vec<u8> {
let mut state = seed;
(0..len).map(|_| splitmix64(&mut state) as u8).collect()
@@ -129,14 +121,6 @@ mod tests {
}
}
- #[test]
- fn agrees_with_byte_at_a_time_table_walk() {
- for seed in 0..8u64 {
- let bytes = seeded_bytes(0x00C2_0000 + seed, 517);
- assert_eq!(crc32(&bytes), byte_at_a_time(&bytes));
- }
- }
-
#[test]
fn split_updates_match_one_shot_at_every_boundary() {
let bytes = seeded_bytes(0x00C3_0000, 100);
diff --git a/rust/crates/ml/src/vecdb/kernel.rs b/rust/crates/ml/src/vecdb/kernel.rs
index 771b54e195..23a80cbc9b 100644
--- a/rust/crates/ml/src/vecdb/kernel.rs
+++ b/rust/crates/ml/src/vecdb/kernel.rs
@@ -123,31 +123,6 @@ mod tests {
}
}
- #[test]
- fn dot_handles_negative_values() {
- let a: Vec<f32> = (0..128)
- .map(|i| if i % 2 == 0 { -1.5 } else { 2.0 })
- .collect();
- let b: Vec<f32> = (0..128)
- .map(|i| if i % 3 == 0 { 0.25 } else { -4.0 })
- .collect();
- let simd = F32Kernel::dot(&pack_lanes(&a), &pack_lanes(&b));
- assert_eq!(simd.to_bits(), reference_dot(&a, &b).to_bits());
- }
-
- #[test]
- fn distance_is_one_minus_dot() {
- let a = seeded_values(7, 192);
- let b = seeded_values(13, 192);
- let lanes_a = pack_lanes(&a);
- let lanes_b = pack_lanes(&b);
- let expected = 1.0 - F32Kernel::dot(&lanes_a, &lanes_b);
- assert_eq!(
- F32Kernel::distance(&lanes_a, &lanes_b).to_bits(),
- expected.to_bits()
- );
- }
-
#[test]
fn distance_of_basis_vectors_is_exact() {
let e0 = pack_lanes(&basis_vector(128, 0));
diff --git a/rust/crates/ml/src/vecdb/log.rs b/rust/crates/ml/src/vecdb/log.rs
index 6a43b7c072..8930b01022 100644
--- a/rust/crates/ml/src/vecdb/log.rs
+++ b/rust/crates/ml/src/vecdb/log.rs
@@ -805,35 +805,6 @@ mod tests {
}
}
- #[test]
- fn bulk_append_round_trips() {
- let dir = TempDir::new().unwrap();
- let path = dir.path().join("log");
- let mut log = Log::create(&path, 8).unwrap();
- let vectors: Vec<Vec<f32>> = (0..3).map(|seed| seeded_vector(seed, 8)).collect();
- let entries = vec![
- LogEntry::Add {
- key: "a",
- vector: &vectors[0],
- },
- LogEntry::Tombstone { key: "b" },
- LogEntry::Add {
- key: "c",
- vector: &vectors[2],
- },
- ];
- let (start, end) = append_bounds(&mut log, &entries);
- assert_eq!(start, HEADER_LEN as u64);
- assert_eq!(end, log.current_end_offset());
- let (records, recoverable_end) = scan_all(&mut log);
- assert_eq!(records.len(), 3);
- assert_eq!(records[0].1, start);
- for (index, entry) in entries.iter().enumerate() {
- assert_eq!(records[index].0, expected_record(entry));
- }
- assert_eq!(recoverable_end, end);
- }
-
#[test]
fn round_trips_boundary_and_multibyte_keys() {
let long255 = "k".repeat(255);
@@ -1266,17 +1237,6 @@ mod tests {
assert_eq!(reopened.generation(), temp_generation);
}
- #[test]
- fn remove_stale_temp_sibling_deletes_leftover_tmp() {
- let dir = TempDir::new().unwrap();
- let path = dir.path().join("log");
- let temp_path = dir.path().join("log.tmp");
- remove_stale_temp_sibling(&path).unwrap();
- std::fs::write(&temp_path, b"leftover").unwrap();
- remove_stale_temp_sibling(&path).unwrap();
- assert!(!temp_path.exists());
- }
-
#[test]
fn large_bulk_append_matches_sequential_framing() {
let dims = 512usize;