Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mob][photos] Prune redundant filmstrip comments

ashil-pilota4cbb1f5a45c
diff --git a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip.dart b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip.dart
index 8429074d45..d51cc093cc 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip.dart
@@ -350,10 +350,8 @@ class _FilmstripInteractionState {
// strip can end its ballistic activity before the replacement drag starts.
final Set<int> _activePointerIds = {};
- // A user session spans both the direct drag and its ballistic coast.
bool _userScrollSessionActive = false;
- // A deferred request is retried when both the session and all pointers end.
_CenteringRequestState _centeringState = _CenteringRequestState.idle;
bool get isUserScrollSessionActive => _userScrollSessionActive;
diff --git a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_coordinator.dart b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_coordinator.dart
index 2e38f7fe92..adbf567629 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_coordinator.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_coordinator.dart
@@ -2,22 +2,16 @@ import "package:flutter/foundation.dart";
import "package:flutter/widgets.dart";
import "package:photos/ui/viewer/file/file_viewer_filmstrip_event.dart";
-/// Returns the viewer's currently committed page index.
typedef FileViewerFilmstripCurrentIndex = int Function();
-/// Returns the stable identity currently stored at [index], or null if absent.
typedef FileViewerFilmstripIdentityAt = Object? Function(int index);
-/// Requests an animation-free page jump and reports whether it was dispatched.
typedef FileViewerFilmstripImmediatePageJump = bool Function(int index);
/// Runs [callback] after a guaranteed future frame's paint phase.
typedef FileViewerFilmstripPaintScheduler =
void Function(VoidCallback callback);
-/// Coordinates the filmstrip's interaction lifecycle with the full-page
-/// viewer without depending on media, navigation, or application services.
-///
/// A user scroll session starts with the drag and remains active through any
/// ballistic coast. During that session, [previewIndex] exposes the centered
/// thumbnail when it differs from the committed page. On commit, the preview
@@ -32,7 +26,6 @@ class FileViewerFilmstripCoordinator {
final ValueNotifier<int?> _previewIndexNotifier = ValueNotifier(null);
- // The session is the source of truth; previewIndex is its UI-facing mirror.
_FilmstripSession _session = const _IdleFilmstripSession();
bool _isDisposed = false;
diff --git a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_event.dart b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_event.dart
index 1373bee976..2ea3d6ec43 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_event.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_event.dart
@@ -1,10 +1,7 @@
import "package:flutter/foundation.dart";
-/// The interaction that caused a [FileViewerFilmstripEvent].
enum FileViewerFilmstripEventType { tap, scrubStart, scrubPreview, scrubCommit }
-/// A user interaction emitted by the filmstrip.
-///
/// Scrub start and commit are lifecycle events, so they are emitted even when
/// [index] has not changed. Preview and tap events identify a newly focused
/// item.
diff --git a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_physics.dart b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_physics.dart
index 7681d8d292..c7424e8c77 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_physics.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_physics.dart
@@ -1,6 +1,5 @@
import "package:flutter/widgets.dart";
-/// The capped, Android-style scroll behavior used by the file-viewer filmstrip.
const ScrollPhysics fileViewerFilmstripPhysics = _FilmstripScrollPhysics();
const _maxFlingVelocity = 800.0;
diff --git a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_preview_layer.dart b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_preview_layer.dart
index b218477ac4..241c309f64 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_preview_layer.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/file_viewer_filmstrip_preview_layer.dart
@@ -8,11 +8,6 @@ const fileViewerFilmstripPreviewKey = ValueKey<String>(
typedef FileViewerFilmstripPreviewBuilder =
Widget Function(BuildContext context, int index);
-/// Opaque preview shown above the page viewer while the filmstrip is scrubbed.
-///
-/// A non-null preview index always produces an absorbing, opaque layer; the
-/// builder supplies only its content.
-///
/// This widget returns [Positioned.fill], so its parent must be a [Stack].
class FileViewerFilmstripPreviewLayer extends StatelessWidget {
final ValueListenable<int?> previewIndex;
diff --git a/mobile/apps/photos/lib/ui/viewer/file/gallery_file_viewer_filmstrip.dart b/mobile/apps/photos/lib/ui/viewer/file/gallery_file_viewer_filmstrip.dart
index d556a25afb..57b9a0207d 100644
--- a/mobile/apps/photos/lib/ui/viewer/file/gallery_file_viewer_filmstrip.dart
+++ b/mobile/apps/photos/lib/ui/viewer/file/gallery_file_viewer_filmstrip.dart
@@ -13,7 +13,6 @@ import "package:photos/ui/viewer/file/file_viewer_filmstrip_event.dart";
import "package:photos/ui/viewer/file/file_viewer_filmstrip_preview_layer.dart";
import "package:photos/ui/viewer/file/thumbnail_widget.dart";
-/// Spacing contributed by the filmstrip to the gallery viewer's chrome.
abstract final class GalleryFileViewerFilmstripLayout {
static const upperContentGap = 6.0;
static const additionalBottomInset =
@@ -23,7 +22,6 @@ abstract final class GalleryFileViewerFilmstripLayout {
/// Keeps the filmstrip limited to internal users while it is being evaluated.
bool get isGalleryFileViewerFilmstripEnabled => flagService.internalUser;
-/// Whether the gallery-specific viewer may expose its neighboring files.
bool shouldShowGalleryFileViewerFilmstrip({
required bool isFeatureEnabled,
required bool isEnabled,
@@ -37,8 +35,6 @@ bool shouldShowGalleryFileViewerFilmstrip({
!isGuestView &&
itemCount > 1;
-/// Renders the opaque, lightweight gallery thumbnail used while scrubbing.
-///
/// This widget returns [Positioned.fill], so its parent must be a [Stack].
class GalleryFileViewerFilmstripPreviewLayer extends StatelessWidget {
final List<EnteFile> files;
@@ -88,8 +84,6 @@ class GalleryFileViewerFilmstripPreviewLayer extends StatelessWidget {
}
}
-/// Positions and presents the filmstrip above the gallery viewer's controls.
-///
/// This widget returns [Positioned], so its parent must be a [Stack].
class GalleryFileViewerFilmstripOverlay extends StatelessWidget {
final List<EnteFile> files;