Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[mobile][photos] Remove misleading sharpness adjustment

r4khula748493269ae
diff --git a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_page.dart b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_page.dart
index 4768ad20ee..b2a227d5e4 100644
--- a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_page.dart
+++ b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_page.dart
@@ -590,7 +590,6 @@ class _ImageEditorPageState extends State<ImageEditorPage> {
tuneEditor: TuneEditorConfigs(
tuneAdjustmentOptions: imageEditorTuneAdjustments(
tuneI18n,
- context.strings.imageEditorSharpness,
context.strings.imageEditorLuminance,
),
style: TuneEditorStyle(
diff --git a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_adjustments.dart b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_adjustments.dart
index 488a5a1377..6f71347827 100644
--- a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_adjustments.dart
+++ b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_adjustments.dart
@@ -4,22 +4,12 @@ import 'package:pro_image_editor/pro_image_editor.dart';
List<TuneAdjustmentItem> imageEditorTuneAdjustments(
I18nTuneEditor i18n,
- String sharpnessLabel,
String luminanceLabel,
) {
final presets = tunePresets(icons: const TuneEditorIcons(), i18n: i18n);
- // Keep Ente's existing controls and their appearance across the 13.x update.
+ // Keep Ente's luminance and fade behavior across the 13.x update.
return [
...presets.take(6),
- TuneAdjustmentItem(
- id: 'sharpness',
- icon: Icons.shutter_speed,
- label: sharpnessLabel,
- min: 0,
- max: 1,
- divisions: 100,
- toMatrix: _sharpnessMatrix,
- ),
TuneAdjustmentItem(
id: 'luminance',
icon: Icons.light_mode_outlined,
@@ -33,33 +23,6 @@ List<TuneAdjustmentItem> imageEditorTuneAdjustments(
];
}
-List<double> _sharpnessMatrix(double value) {
- final factor = 1 + value * 2;
- final offset = -(factor - 1) * 128;
- return [
- factor,
- 0,
- 0,
- 0,
- offset,
- 0,
- factor,
- 0,
- 0,
- offset,
- 0,
- 0,
- factor,
- 0,
- offset,
- 0,
- 0,
- 0,
- 1,
- 0,
- ];
-}
-
List<double> _luminanceMatrix(double value) {
const red = 0.2126;
const green = 0.7152;
diff --git a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_bar.dart b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_bar.dart
index 97b38ab343..698844200c 100644
--- a/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_bar.dart
+++ b/mobile/apps/photos/lib/ui/tools/editor/image_editor/image_editor_tune_bar.dart
@@ -190,7 +190,6 @@ class TuneItem extends StatelessWidget {
"exposure" => HugeIcons.strokeRoundedCameraLens,
"saturation" => HugeIcons.strokeRoundedDroplet,
"temperature" => HugeIcons.strokeRoundedTemperature,
- "sharpness" => HugeIcons.strokeRoundedFocusPoint,
"hue" => HugeIcons.strokeRoundedColors,
_ => null,
};