π End-to-end encrypted cloud for everything.
Dart 2faandroidauthye2eeencryptionend-to-end-encryptionfluttergolanggoogle-photosgoogle-photos-alternativeiosopensourcephotosprivacyprivacy-toolstypescriptzero-knowledge
fix(photos):preserve-alt-text-and-aria-labels
Aswin Asokb5e28594eb33
diff --git a/web/apps/photos/src/components/Collections/CollectionMapDialog.tsx b/web/apps/photos/src/components/Collections/CollectionMapDialog.tsxindex 1717f1e4e2..cfa9335f85 100644--- a/web/apps/photos/src/components/Collections/CollectionMapDialog.tsx+++ b/web/apps/photos/src/components/Collections/CollectionMapDialog.tsx@@ -915,9 +915,6 @@ function createMarkerIcon(const outerBorderRadius = 16;const innerBorderRadius = 12;- const escapedLocationLabel = t("location")- .replaceAll("&", "&")- .replaceAll('"', """);const hoverHandlers = interactive? "onmouseover=\"this.style.background='#22c55e'; this.style.borderColor='#22c55e'; this.parentElement.querySelector('.triangle').style.borderTopColor='#22c55e';\" onmouseout=\"this.style.background='white'; this.style.borderColor='#ffffff'; this.parentElement.querySelector('.triangle').style.borderTopColor='white';\""@@ -956,7 +953,7 @@ function createMarkerIcon(>${hasImage- ? `<img src="${imageSrc}" style="width:100%;height:100%;object-fit:cover;border-radius:${innerBorderRadius}px;" alt="${escapedLocationLabel}" />`+ ? `<img src="${imageSrc}" style="width:100%;height:100%;object-fit:cover;border-radius:${innerBorderRadius}px;" alt="Location" />`: `<div style="width:100%;height:100%;border-radius:${innerBorderRadius}px;animation:skeleton-pulse 1.5s ease-in-out infinite;"></div><style>@keyframes skeleton-pulse{0%{background-color:#ffffff}50%{background-color:#f0f0f0}100%{background-color:#ffffff}}</style>`}@@ -1869,7 +1866,7 @@ function CenteredBox({ children, onClose, closeLabel }: CenteredBoxProps) {<CenteredBoxContainer>{onClose && (<IconButton- aria-label={closeLabel ?? t("close")}+ aria-label={closeLabel ?? "Close"}onClick={onClose}sx={{ position: "absolute", top: 16, right: 16 }}>@@ -1899,7 +1896,7 @@ const MapCover = React.memo(function MapCover({<CoverImageContainer><imgsrc={coverImageUrl}- alt={t("cover")}+ alt="Cover"style={{position: "absolute",inset: 0,@@ -1911,7 +1908,7 @@ const MapCover = React.memo(function MapCover({/><CoverGradientOverlay />- <CoverCloseButton aria-label={t("close")} onClick={onClose}>+ <CoverCloseButton aria-label="Close" onClick={onClose}><CloseIcon sx={{ fontSize: 20 }} /></CoverCloseButton>diff --git a/web/apps/photos/src/components/FileList.tsx b/web/apps/photos/src/components/FileList.tsxindex 356d8cc0ca..6c037de2a3 100644--- a/web/apps/photos/src/components/FileList.tsx+++ b/web/apps/photos/src/components/FileList.tsx@@ -822,7 +822,7 @@ export const FileList: React.FC<FileListProps> = ({{showBackToTop && (<BackToTopButtonsize="small"- aria-label={t("scroll_to_top")}+ aria-label="scroll to top"onClick={handleScrollToTop}><KeyboardArrowUpIcon />diff --git a/web/apps/photos/src/components/SelectedFileOptions.tsx b/web/apps/photos/src/components/SelectedFileOptions.tsxindex 06c16e9b8f..93d4279e85 100644--- a/web/apps/photos/src/components/SelectedFileOptions.tsx+++ b/web/apps/photos/src/components/SelectedFileOptions.tsx@@ -341,7 +341,7 @@ const DownloadButton: React.FC<ButtonishProps> = ({ onClick }) => (const SendLinkButton: React.FC<ButtonishProps> = ({ onClick }) => (<Tooltip title={t("send_link")}>- <IconButton {...{ onClick }} aria-label={t("send_link")}>+ <IconButton {...{ onClick }} aria-label="Send link"><HugeiconsIcon icon={Navigation03Icon} /></IconButton></Tooltip>diff --git a/web/apps/photos/src/components/sidebar/AppLockSettings.tsx b/web/apps/photos/src/components/sidebar/AppLockSettings.tsxindex ae81cbf9c1..f08567a153 100644--- a/web/apps/photos/src/components/sidebar/AppLockSettings.tsx+++ b/web/apps/photos/src/components/sidebar/AppLockSettings.tsx@@ -517,9 +517,7 @@ const PinSetupDialog: React.FC<SetupDialogProps> = ({fontSize: "1.25rem",padding: "12px 0",},- "aria-label": t("app_lock_pin_digit_label", {- index: i + 1,- }),+ "aria-label": `PIN digit ${String(i + 1)}`,},}}sx={{ flex: 1, minWidth: 0 }}diff --git a/web/packages/base/locales/en-US/translation.json b/web/packages/base/locales/en-US/translation.jsonindex 07ce50c011..319f8ea573 100644--- a/web/packages/base/locales/en-US/translation.json+++ b/web/packages/base/locales/en-US/translation.json@@ -439,7 +439,6 @@"rename": "Rename","rename_file": "Rename file","album_cover": "Album cover",- "cover": "Cover","set_cover": "Set cover","select_cover_photo": "Select cover photo","reset_to_default": "Reset to default",@@ -481,7 +480,6 @@"file_type": "File type","camera_make": "Camera Make","camera_model": "Camera Model",- "scroll_to_top": "scroll to top","settings": "Settings","slideshow": "Slideshow","slideshow_settings": "Slideshow settings",