Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Fix Cast release build metadata

Neeraj Guptad4b6b3c0e531
diff --git a/.github/workflows/cast-build.yml b/.github/workflows/cast-build.yml
index 8147a30033..75eac6b772 100644
--- a/.github/workflows/cast-build.yml
+++ b/.github/workflows/cast-build.yml
@@ -25,28 +25,12 @@ jobs:
working-directory: apple/apps/cast
run: |
settings="$(xcodebuild -showBuildSettings -project Cast.xcodeproj -scheme Cast -configuration Release)"
- version="$(awk '$1 == "MARKETING_VERSION" { print $3; exit }' <<< "${settings}")"
build_base="$(awk '$1 == "CURRENT_PROJECT_VERSION" { print $3; exit }' <<< "${settings}")"
- if [[ ! "${version}" =~ ^[0-9]+\.[0-9]+(\.[0-9]+)?$ ]]; then
- echo "::error::MARKETING_VERSION must be x.y or x.y.z"
- exit 1
- fi
if [[ ! "${build_base}" =~ ^[0-9]+$ ]]; then
echo "::error::CURRENT_PROJECT_VERSION must be an integer"
exit 1
fi
- if [[ "${GITHUB_REF_NAME}" == release/cast-v* ]]; then
- if [[ "${GITHUB_REF_NAME}" != "release/cast-v${version}" ]]; then
- echo "::error::${GITHUB_REF_NAME} does not match Cast version ${version}"
- exit 1
- fi
- build_number="${build_base}"
- elif [[ "${GITHUB_REF_NAME}" == main ]]; then
- build_number="$((build_base + GITHUB_RUN_NUMBER))"
- else
- echo "::error::Cast builds must run from main or release/cast-v${version}"
- exit 1
- fi
+ build_number="$((build_base + GITHUB_RUN_NUMBER))"
echo "build_number=${build_number}" >> "${GITHUB_OUTPUT}"
- name: Generate Cast bindings
diff --git a/apple/apps/cast/Cast.xcodeproj/project.pbxproj b/apple/apps/cast/Cast.xcodeproj/project.pbxproj
index ee2a0889fe..b461216c6f 100644
--- a/apple/apps/cast/Cast.xcodeproj/project.pbxproj
+++ b/apple/apps/cast/Cast.xcodeproj/project.pbxproj
@@ -474,7 +474,6 @@
ENABLE_USER_SCRIPT_SANDBOXING = NO;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = Cast/Info.plist;
- "INFOPLIST_FILE[sdk=appletvos*]" = "";
INFOPLIST_KEY_CFBundleDisplayName = "Ente Cast";
INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.photography";
INFOPLIST_KEY_UILaunchScreen_Generation = YES;
diff --git a/apple/apps/cast/README.md b/apple/apps/cast/README.md
index 614d50058f..9b6e770497 100644
--- a/apple/apps/cast/README.md
+++ b/apple/apps/cast/README.md
@@ -27,11 +27,6 @@ Run `cast-build.yml` manually on `main` to archive and upload a TestFlight build
Its build number is the committed Cast Release build number plus the GitHub
Actions run number.
-For a release candidate, create `release/cast-v<version>` after setting the Cast
-Release marketing version to `<version>`, then run the same workflow on that
-branch. Release branches use the committed build number; increment it before
-uploading another build for the same version.
-
Before the first release, create the `Cast App Store` provisioning profile for
`io.ente.frame.tv.cast`. The shared certificate and App Store Connect API-key
secrets are documented in [Apple signing](../../../.github/docs/apple-signing.md).