π End-to-end encrypted cloud for everything.
Dart 2faandroidauthye2eeencryptionend-to-end-encryptionfluttergolanggoogle-photosgoogle-photos-alternativeiosopensourcephotosprivacyprivacy-toolstypescriptzero-knowledge
[mobile][photos] remove toasts from notification permission flow as useless
Priyanshu Dangaredc44ba9c0519
diff --git a/mobile/apps/photos/lib/l10n/intl_en.arb b/mobile/apps/photos/lib/l10n/intl_en.arbindex 5c20a92c4b..a668b5a7b0 100644--- a/mobile/apps/photos/lib/l10n/intl_en.arb+++ b/mobile/apps/photos/lib/l10n/intl_en.arb@@ -2930,7 +2930,6 @@"ritualChooseDaysLabel": "Choose days for ritual","ritualDayLabel": "Day","ritualNotificationsOffHint": "Notifications are off. Tap a day to turn them on.",- "enableNotificationsHint": "Enable notifications for Ente Photos in settings","ritualTimeLabel": "Time","ritualAlbumLabel": "Album","ritualSave": "Save ritual",diff --git a/mobile/apps/photos/lib/services/notification_service.dart b/mobile/apps/photos/lib/services/notification_service.dartindex 4524b380f6..89311a8f44 100644--- a/mobile/apps/photos/lib/services/notification_service.dart+++ b/mobile/apps/photos/lib/services/notification_service.dart@@ -8,9 +8,7 @@ import "package:flutter_timezone/flutter_timezone.dart";import "package:logging/logging.dart";import "package:package_info_plus/package_info_plus.dart";import "package:permission_handler/permission_handler.dart";-import "package:photos/generated/l10n.dart";import "package:photos/services/timezone_aliases.dart";-import "package:photos/ui/notification/toast.dart";import "package:shared_preferences/shared_preferences.dart";import 'package:timezone/data/latest_10y.dart' as tzdb;import "package:timezone/timezone.dart" as tz;@@ -168,7 +166,7 @@ class NotificationService {if (!context.mounted) return false;if (await _askPermissions()) return true;if (!context.mounted) return false;- await _openNotificationSettings(context);+ await _openNotificationSettings();const interval = Duration(milliseconds: 500);const maxAttempts = 1000;for (var attempt = 0; attempt < maxAttempts; attempt++) {@@ -194,7 +192,7 @@ class NotificationService {return await impl?.requestNotificationsPermission() ?? false;}- Future<void> _openNotificationSettings(BuildContext context) async {+ Future<void> _openNotificationSettings() async {if (Platform.isIOS) {await openAppSettings();return;@@ -206,9 +204,6 @@ class NotificationService {"android.provider.extra.APP_PACKAGE": packageInfo.packageName,},).launch();- if (!context.mounted) return;- final l10n = AppLocalizations.of(context);- showToast(context, l10n.enableNotificationsHint);}Future<bool> hasGrantedPermissions() async {diff --git a/mobile/apps/photos/lib/ui/rituals/ritual_editor_dialog.dart b/mobile/apps/photos/lib/ui/rituals/ritual_editor_dialog.dartindex 964feb0cf3..35eb947814 100644--- a/mobile/apps/photos/lib/ui/rituals/ritual_editor_dialog.dart+++ b/mobile/apps/photos/lib/ui/rituals/ritual_editor_dialog.dart@@ -3,7 +3,6 @@ import "dart:io";import "package:flutter/cupertino.dart";import "package:flutter/material.dart";import "package:hugeicons/hugeicons.dart";-import "package:photos/generated/l10n.dart";import "package:photos/l10n/l10n.dart";import "package:photos/models/collection/collection.dart";import "package:photos/models/file/file.dart";@@ -16,7 +15,6 @@ import "package:photos/theme/ente_theme.dart";import "package:photos/ui/collections/album/column_item.dart";import "package:photos/ui/collections/album/new_list_item.dart";import "package:photos/ui/components/thumbnail_list_item.dart";-import "package:photos/ui/notification/toast.dart";import "package:photos/ui/viewer/file/thumbnail_widget.dart";import "package:photos/utils/dialog_util.dart";@@ -548,14 +546,6 @@ Future<void> _showRitualEditor(BuildContext context, {Ritual? ritual}) async {// ignore: use_build_context_synchronouslycontext,)) {- if (context.mounted) {- showToast(- context,- AppLocalizations.of(- context,- ).enableNotificationsHint,- );- }return;}final updated =