Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[photos][web] Add volume slider to video player controls (#13825)

Mohd Sultane8e97048bc0e
diff --git a/desktop/changes/web-video-volume-slider.md b/desktop/changes/web-video-volume-slider.md
new file mode 100644
index 0000000000..b6fb2096ab
--- /dev/null
+++ b/desktop/changes/web-video-volume-slider.md
@@ -0,0 +1 @@
+- Add volume slider to web video player controls (@mohdsultan18)
diff --git a/web/packages/gallery/components/viewer/photoswipe-core.ts b/web/packages/gallery/components/viewer/photoswipe-core.ts
index 12e9cde027..aaeb4fd832 100644
--- a/web/packages/gallery/components/viewer/photoswipe-core.ts
+++ b/web/packages/gallery/components/viewer/photoswipe-core.ts
@@ -1550,12 +1550,22 @@ export class FileViewerPhotoSwipe<
cb = handleDelete;
break;
case "ArrowLeft":
- cb = handleSeekBackOrPreviousSlide;
pswpEvent.preventDefault();
+ if (
+ document.activeElement?.tagName ===
+ "MEDIA-VOLUME-RANGE"
+ )
+ return;
+ cb = handleSeekBackOrPreviousSlide;
break;
case "ArrowRight":
- cb = handleSeekForwardOrNextSlide;
pswpEvent.preventDefault();
+ if (
+ document.activeElement?.tagName ===
+ "MEDIA-VOLUME-RANGE"
+ )
+ return;
+ cb = handleSeekForwardOrNextSlide;
break;
case "?":
cb = handleHelp;
@@ -1599,6 +1609,7 @@ export class FileViewerPhotoSwipe<
const target = e.target;
if (target instanceof HTMLElement) {
switch (target.tagName) {
+ case "MEDIA-VOLUME-RANGE":
case "MEDIA-TIME-RANGE":
case "MEDIA-PLAY-BUTTON":
case "MEDIA-MUTE-BUTTON":
@@ -1714,6 +1725,7 @@ const hlsVideoControlsHTML = () => `
<media-control-bar>
<media-play-button notooltip></media-play-button>
<media-mute-button notooltip></media-mute-button>
+ <media-volume-range></media-volume-range>
<media-time-display showduration notoggle></media-time-display>
<media-text-display></media-text-display>
<media-settings-menu-button id="ente-settings-menu-btn" invoketarget="ente-settings-menu" notooltip>
diff --git a/web/packages/gallery/styles/photoswipe.css b/web/packages/gallery/styles/photoswipe.css
index 24b911afcf..2daa2fbf97 100644
--- a/web/packages/gallery/styles/photoswipe.css
+++ b/web/packages/gallery/styles/photoswipe.css
@@ -345,6 +345,12 @@ media-time-range {
--media-control-padding: 0px;
}
+@media (width < 450px) {
+ media-volume-range {
+ display: none;
+ }
+}
+
media-time-range:hover {
--media-range-track-height: 5px;
--media-range-thumb-transform: scale(1.1);