π End-to-end encrypted cloud for everything.
Dart 2faandroidauthye2eeencryptionend-to-end-encryptionfluttergolanggoogle-photosgoogle-photos-alternativeiosopensourcephotosprivacyprivacy-toolstypescriptzero-knowledge
Remove unreachable indexing model deletion
laurenspriemecd0147333ca
diff --git a/mobile/apps/photos/lib/services/machine_learning/ml_indexing_isolate.dart b/mobile/apps/photos/lib/services/machine_learning/ml_indexing_isolate.dartindex 1ceef1463a..74b61fd297 100644--- a/mobile/apps/photos/lib/services/machine_learning/ml_indexing_isolate.dart+++ b/mobile/apps/photos/lib/services/machine_learning/ml_indexing_isolate.dart@@ -6,7 +6,6 @@ import "package:photos/service_locator.dart" show flagService, localSettings;import "package:photos/services/machine_learning/ml_model_download_service.dart";import "package:photos/services/machine_learning/ml_result.dart";import "package:photos/services/machine_learning/webgpu_execution_policy.dart";-import "package:photos/src/rust/api/ml_indexing_api.dart" as rust_ml;import "package:photos/utils/isolate/isolate_operations.dart";import "package:photos/utils/isolate/super_isolate.dart";import "package:photos/utils/ml_util.dart";@@ -172,17 +171,7 @@ class MLIndexingIsolate extends SuperIsolate {return "Rust+${acceleratedProviders.join('+')}";}- Future<void> cleanupLocalIndexingModels({bool delete = false}) async {- await releaseRustRuntime();- if (!MLModelDownloadService.instance.areIndexingModelsDownloaded) return;-- if (delete) {- await rust_ml.removeIndexingModels(- assetsDir: await MLModelDownloadService.instance.getAssetsDirectory(),- );- MLModelDownloadService.instance.invalidateModelDownloadCache();- }- }+ Future<void> cleanupLocalIndexingModels() => releaseRustRuntime();Future<Map<String, dynamic>> _buildRustRuntimeArgs() async {return {diff --git a/rust/bindings/frb/photos/src/api/ml_indexing_api.rs b/rust/bindings/frb/photos/src/api/ml_indexing_api.rsindex 5356c8cb48..520400c6d1 100644--- a/rust/bindings/frb/photos/src/api/ml_indexing_api.rs+++ b/rust/bindings/frb/photos/src/api/ml_indexing_api.rs@@ -263,10 +263,6 @@ pub fn is_clip_text_downloaded(assets_dir: String, include_vocab: bool) -> bool)}-pub fn remove_indexing_models(assets_dir: String) -> Result<(), String> {- assets::remove_mobile_indexing_models(&AssetStore::new(&assets_dir), Path::new(&assets_dir))-}-fn task_error(error: impl std::fmt::Display) -> RustMlError {RustMlError::Other {message: error.to_string(),