Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

Test rendered inline video previews in WebKit

Anand Baburajaned66f9d12344
diff --git a/.github/workflows/web-lint.yml b/.github/workflows/web-lint.yml
index 33ab82235c..3598a4411b 100644
--- a/.github/workflows/web-lint.yml
+++ b/.github/workflows/web-lint.yml
@@ -65,3 +65,7 @@ jobs:
- run: node scripts/lint.mjs
- run: npm test
+
+ - run: npm exec --workspace space -- playwright install --with-deps webkit
+
+ - run: npm run test:browser --workspace space
diff --git a/web/apps/space/package.json b/web/apps/space/package.json
index 97600cc135..f093418b11 100644
--- a/web/apps/space/package.json
+++ b/web/apps/space/package.json
@@ -4,7 +4,8 @@
"private": true,
"scripts": {
"build:post": "mv out/404.html out/_next/404.html",
- "test": "vitest --run"
+ "test": "vitest --run",
+ "test:browser": "node --test tests/browser/inline-post-video.mts"
},
"dependencies": {
"@ffmpeg/ffmpeg": "0.12.15",
@@ -26,6 +27,8 @@
},
"devDependencies": {
"ente-build-config": "*",
+ "playwright": "1.64.1",
+ "vite": "8.3.4",
"vite-plugin-wasm": "3.6.0",
"vitest": "5.0.4"
}
diff --git a/web/apps/space/tests/browser/README.md b/web/apps/space/tests/browser/README.md
new file mode 100644
index 0000000000..8d23bd68e8
--- /dev/null
+++ b/web/apps/space/tests/browser/README.md
@@ -0,0 +1,17 @@
+Run from `web`:
+
+```sh
+npm exec --workspace space -- playwright install --with-deps webkit
+npm run test:browser --workspace space
+```
+
+The test mounts the real inline video component in WebKit and exposes half of the
+inactive second slide. It checks screenshot pixels for both colors in the decoded
+video while that slide remains paused at time zero. A cover or blank preview fails.
+
+`preview.mp4` is a generated, silent H.264 video with a green upper half and blue
+lower half. Regenerate it from this directory with:
+
+```sh
+ffmpeg -f lavfi -i 'color=c=0x00ff00:s=320x240:r=2:d=1' -vf 'drawbox=x=0:y=120:w=320:h=120:color=0x0000ff:t=fill' -c:v libx264 -pix_fmt yuv420p -movflags +faststart preview.mp4
+```
diff --git a/web/apps/space/tests/browser/index.html b/web/apps/space/tests/browser/index.html
new file mode 100644
index 0000000000..10b8d9d719
--- /dev/null
+++ b/web/apps/space/tests/browser/index.html
@@ -0,0 +1,30 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
+ <title>Inline video preview test</title>
+ <style>
+ body {
+ margin: 0;
+ }
+ article {
+ display: flex;
+ width: 320px;
+ height: 240px;
+ overflow: hidden;
+ background: black;
+ }
+ .slide {
+ position: relative;
+ flex: 0 0 100%;
+ }
+ .space-video-control[aria-hidden="true"] {
+ display: none;
+ }
+ </style>
+ </head>
+ <body>
+ <div id="root"></div>
+ <script type="module" src="./preview.tsx"></script>
+ </body>
+</html>
diff --git a/web/apps/space/tests/browser/inline-post-video.mts b/web/apps/space/tests/browser/inline-post-video.mts
new file mode 100644
index 0000000000..40e9388ea3
--- /dev/null
+++ b/web/apps/space/tests/browser/inline-post-video.mts
@@ -0,0 +1,109 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+import { fileURLToPath } from "node:url";
+import { webkit } from "playwright";
+import { createServer } from "vite";
+
+await test("an inactive preloaded slide renders its decoded frame when partially revealed", async (t) => {
+ const server = await createServer({
+ configFile: false,
+ root: fileURLToPath(new URL("../..", import.meta.url)),
+ oxc: { jsx: { runtime: "automatic" } },
+ define: { "process.env": JSON.stringify({ appName: "space" }) },
+ resolve: {
+ alias: {
+ components: fileURLToPath(
+ new URL("../../src/components", import.meta.url),
+ ),
+ services: fileURLToPath(
+ new URL("../../src/services", import.meta.url),
+ ),
+ },
+ },
+ server: { host: "127.0.0.1", port: 0 },
+ });
+ t.after(() => server.close());
+ await server.listen();
+ const browser = await webkit.launch();
+ t.after(() => browser.close());
+ const page = await browser.newPage({
+ viewport: { width: 320, height: 480 },
+ deviceScaleFactor: 1,
+ isMobile: true,
+ hasTouch: true,
+ });
+ const errors: Error[] = [];
+ page.on("pageerror", (error) => errors.push(error));
+ await page.goto(`${server.resolvedUrls!.local[0]}tests/browser/index.html`);
+ await page.waitForFunction(() => {
+ const videos = document.querySelectorAll("video");
+ return (
+ videos.length == 2 &&
+ !videos[0]!.paused &&
+ videos[1]!.readyState >= HTMLMediaElement.HAVE_CURRENT_DATA
+ );
+ });
+ await page.locator("article").evaluate((element) => {
+ element.scrollLeft = 160;
+ });
+ const next = page.locator("video").nth(1);
+ assert.equal(
+ await next.evaluate((video: HTMLVideoElement) => video.paused),
+ true,
+ );
+ assert.equal(
+ await next.evaluate((video: HTMLVideoElement) => video.currentTime),
+ 0,
+ );
+ const screenshot = await page.screenshot({
+ clip: { x: 176, y: 16, width: 128, height: 208 },
+ });
+ const pixels = await page.evaluate(async (base64) => {
+ const image = new Image();
+ image.src = `data:image/png;base64,${base64}`;
+ await image.decode();
+ const canvas = document.createElement("canvas");
+ canvas.width = image.width;
+ canvas.height = image.height;
+ const context = canvas.getContext("2d")!;
+ context.drawImage(image, 0, 0);
+ const { data } = context.getImageData(
+ 0,
+ 0,
+ canvas.width,
+ canvas.height,
+ );
+ let green = 0;
+ let blue = 0;
+ for (let i = 0; i < data.length; i += 4) {
+ if (
+ data[i + 1]! - data[i]! > 100 &&
+ data[i + 1]! - data[i + 2]! > 100
+ )
+ green++;
+ if (
+ data[i + 2]! - data[i]! > 100 &&
+ data[i + 2]! - data[i + 1]! > 100
+ )
+ blue++;
+ }
+ return {
+ green: green / (data.length / 4),
+ blue: blue / (data.length / 4),
+ };
+ }, screenshot.toString("base64"));
+ assert.ok(
+ pixels.green > 0.45,
+ `Missing green video pixels: ${pixels.green}`,
+ );
+ assert.ok(pixels.blue > 0.45, `Missing blue video pixels: ${pixels.blue}`);
+ assert.equal(
+ await next.evaluate((video: HTMLVideoElement) => video.paused),
+ true,
+ );
+ assert.equal(
+ await next.evaluate((video: HTMLVideoElement) => video.currentTime),
+ 0,
+ );
+ assert.deepEqual(errors, []);
+});
diff --git a/web/apps/space/tests/browser/preview.mp4 b/web/apps/space/tests/browser/preview.mp4
new file mode 100644
index 0000000000..33f613e66d
Binary files /dev/null and b/web/apps/space/tests/browser/preview.mp4 differ
diff --git a/web/apps/space/tests/browser/preview.tsx b/web/apps/space/tests/browser/preview.tsx
new file mode 100644
index 0000000000..818fa76cc7
--- /dev/null
+++ b/web/apps/space/tests/browser/preview.tsx
@@ -0,0 +1,29 @@
+import { useEffect, useRef } from "react";
+import { createRoot } from "react-dom/client";
+import { SpaceInlinePostVideo } from "../../src/components/InlinePostVideo";
+import { registerFeedPost } from "../../src/components/feed-video-playback";
+
+const video = { url: "/tests/browser/preview.mp4", durationMs: 1000 };
+const imageUrl = `data:image/svg+xml,${encodeURIComponent('<svg xmlns="http://www.w3.org/2000/svg" width="320" height="240"><path fill="#ff00ff" d="M0 0h320v240H0z"/></svg>')}`;
+
+export const Preview = () => {
+ const post = useRef<HTMLElement>(null);
+ useEffect(() => registerFeedPost(post.current!), []);
+ return (
+ <article ref={post}>
+ {[true, false].map((isActive, index) => (
+ <div className="slide" key={index}>
+ <SpaceInlinePostVideo
+ video={video}
+ imageUrl={imageUrl}
+ isActive={isActive}
+ shouldPreload
+ muted
+ />
+ </div>
+ ))}
+ </article>
+ );
+};
+
+createRoot(document.getElementById("root")!).render(<Preview />);
diff --git a/web/apps/space/tests/inline-post-video.test.tsx b/web/apps/space/tests/inline-post-video.test.tsx
index 1d482d74b2..8228eb74f9 100644
--- a/web/apps/space/tests/inline-post-video.test.tsx
+++ b/web/apps/space/tests/inline-post-video.test.tsx
@@ -173,7 +173,7 @@ test("leaving the post releases its player and cancels its load", () => {
expect(registration.unregister).toHaveBeenCalledOnce();
});
-test("a preloaded slide shows its video frame as soon as it is decoded", () => {
+test("a preloaded slide removes its poster as soon as a frame is decoded", () => {
render(true);
expect(content.video.poster).toBe("blob:cover");
content.video.readyState = 2;
diff --git a/web/package-lock.json b/web/package-lock.json
index 2e0ed9ca49..99b4183cd2 100644
--- a/web/package-lock.json
+++ b/web/package-lock.json
@@ -367,6 +367,8 @@
},
"devDependencies": {
"ente-build-config": "*",
+ "playwright": "1.64.1",
+ "vite": "8.3.4",
"vite-plugin-wasm": "3.6.0",
"vitest": "5.0.4"
}
@@ -9425,6 +9427,35 @@
"url": "https://github.com/sponsors/jonschlinkert"
}
},
+ "node_modules/playwright": {
+ "version": "1.64.1",
+ "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.64.1.tgz",
+ "integrity": "sha512-HCrVhHr5QQuwYoswEUGTb7gGp522yflbv/ST8nF4sFWGuLjQCt17Q/EubpGGSNKYn1tsTCPZxqHhHCfVURu7UA==",
+ "dev": true,
+ "license": "Apache-2.0",
+ "dependencies": {
+ "playwright-core": "1.64.1"
+ },
+ "bin": {
+ "playwright": "cli.js"
+ },
+ "engines": {
+ "node": ">=20"
+ }
+ },
+ "node_modules/playwright-core": {
+ "version": "1.64.1",
+ "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.64.1.tgz",
+ "integrity": "sha512-BC4s8y6SEVA6Q1rSxZTto8hI1KUI3xXlHGZgvGqP4IqPdI/a6FX9H29IDNz7vKo9l21b6LfYosScPL6M3xxyDQ==",
+ "dev": true,
+ "license": "Apache-2.0",
+ "bin": {
+ "playwright-core": "cli.js"
+ },
+ "engines": {
+ "node": ">=20"
+ }
+ },
"node_modules/pngjs": {
"version": "6.0.0",
"resolved": "https://registry.npmjs.org/pngjs/-/pngjs-6.0.0.tgz",