Skip to content

armgit / ente

Public Imported from GitHub
0

πŸ’š End-to-end encrypted cloud for everything.

[server] Store trimmed discount coupon codes (#13744)

Yugendhraf9df3ed3191d
diff --git a/server/pkg/controller/discountcoupon/controller.go b/server/pkg/controller/discountcoupon/controller.go
index 8608994715..d47cc8deac 100644
--- a/server/pkg/controller/discountcoupon/controller.go
+++ b/server/pkg/controller/discountcoupon/controller.go
@@ -200,7 +200,7 @@ func (c *Controller) AddCoupons(ctx *gin.Context, req AddCouponsRequest) error {
if len(validCodes) == 0 {
return nil
}
- err := c.Repo.AddCoupons(ctx, req.ProviderName, req.Codes)
+ err := c.Repo.AddCoupons(ctx, req.ProviderName, validCodes)
if err != nil {
return stacktrace.Propagate(err, "failed to add coupons")
}
diff --git a/server/pkg/controller/discountcoupon/controller_test.go b/server/pkg/controller/discountcoupon/controller_test.go
new file mode 100644
index 0000000000..d80effc145
--- /dev/null
+++ b/server/pkg/controller/discountcoupon/controller_test.go
@@ -0,0 +1,41 @@
+package discountcoupon
+
+import (
+ "net/http/httptest"
+ "testing"
+
+ "github.com/ente/museum/internal/testutil"
+ "github.com/ente/museum/pkg/repo/discountcoupon"
+ "github.com/gin-gonic/gin"
+ "github.com/stretchr/testify/require"
+)
+
+func TestAddCouponsStoresTrimmedCodes(t *testing.T) {
+ db := testutil.RequireTestDB(t)
+ deleteTestCoupons := func() {
+ _, err := db.Exec(`DELETE FROM discount_coupons WHERE provider_name = 'Test'`)
+ require.NoError(t, err)
+ }
+ deleteTestCoupons()
+ t.Cleanup(deleteTestCoupons)
+
+ gin.SetMode(gin.TestMode)
+ ctx, _ := gin.CreateTestContext(httptest.NewRecorder())
+ controller := &Controller{Repo: &discountcoupon.Repository{DB: db}}
+ require.NoError(t, controller.AddCoupons(ctx, AddCouponsRequest{
+ ProviderName: "Test",
+ Codes: []string{"AAA ", "BBB\r", "", " ", "AAA"},
+ }))
+
+ rows, err := db.Query(`SELECT code FROM discount_coupons WHERE provider_name = 'Test' ORDER BY code`)
+ require.NoError(t, err)
+ defer rows.Close()
+ var codes []string
+ for rows.Next() {
+ var code string
+ require.NoError(t, rows.Scan(&code))
+ codes = append(codes, code)
+ }
+ require.NoError(t, rows.Err())
+ require.Equal(t, []string{"AAA", "BBB"}, codes)
+}