Skip to content

armgit / ente

Public Imported from GitHub
0

💚 End-to-end encrypted cloud for everything.

Prune test policy mirrors

Manav Rathifa0fdd75d93e
diff --git a/mobile/apps/auth/lib/ui/home_page.dart b/mobile/apps/auth/lib/ui/home_page.dart
index b80973132a..e6621e69f9 100644
--- a/mobile/apps/auth/lib/ui/home_page.dart
+++ b/mobile/apps/auth/lib/ui/home_page.dart
@@ -61,6 +61,7 @@ import 'package:ente_ui/components/buttons/button_widget.dart';
import 'package:ente_ui/components/buttons/models/button_type.dart';
import 'package:ente_ui/components/loading_widget.dart';
import 'package:ente_ui/pages/base_home_page.dart';
+import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter/widgets.dart' as widgets;
diff --git a/mobile/apps/auth/test/utils/debug_code_deep_link_test.dart b/mobile/apps/auth/test/utils/debug_code_deep_link_test.dart
deleted file mode 100644
index c1b82a5180..0000000000
--- a/mobile/apps/auth/test/utils/debug_code_deep_link_test.dart
+++ /dev/null
@@ -1,53 +0,0 @@
-import 'package:ente_auth/utils/debug_code_deep_link.dart';
-import 'package:flutter_test/flutter_test.dart';
-
-void main() {
- test('unwraps a debug add-code link', () {
- const codeUri =
- 'otpauth://totp/Example:[email protected]?secret=JBSWY3DPEHPK3PXP&issuer=Example';
- final link = Uri(
- scheme: 'enteauth',
- host: 'debug',
- path: '/add-code',
- queryParameters: {'uri': codeUri},
- ).toString();
-
- final result = parseDebugCodeDeepLink(link);
- expect(result?.action, DebugCodeDeepLinkAction.addCode);
- expect(result?.codeUri, codeUri);
- });
-
- test('parses debug visual preview links', () {
- const encodedCode =
- 'otpauth%3A%2F%2Ftotp%2FExample%3Fsecret%3DJBSWY3DPEHPK3PXP';
-
- expect(
- parseDebugCodeDeepLink(
- 'enteauth://debug/show-qr?uri=$encodedCode',
- )?.action,
- DebugCodeDeepLinkAction.showQr,
- );
- expect(
- parseDebugCodeDeepLink(
- 'enteauth://debug/share-code?uri=$encodedCode',
- )?.action,
- DebugCodeDeepLinkAction.shareCode,
- );
- expect(
- parseDebugCodeDeepLink(
- 'enteauth://debug/show-icons?uri=$encodedCode',
- )?.action,
- DebugCodeDeepLinkAction.showIcons,
- );
- });
-
- test('rejects unrelated and non-OTP links', () {
- expect(parseDebugCodeDeepLink('enteauth://search?query=Example'), isNull);
- expect(
- parseDebugCodeDeepLink(
- 'enteauth://debug/add-code?uri=https%3A%2F%2Fexample.com',
- ),
- isNull,
- );
- });
-}
diff --git a/mobile/apps/locker/test/utils/collection_list_util_test.dart b/mobile/apps/locker/test/utils/collection_list_util_test.dart
deleted file mode 100644
index 7160aecc50..0000000000
--- a/mobile/apps/locker/test/utils/collection_list_util_test.dart
+++ /dev/null
@@ -1,45 +0,0 @@
-import "package:ente_sharing/models/user.dart";
-import "package:flutter_test/flutter_test.dart";
-import "package:locker/services/collections/models/collection.dart";
-import "package:locker/utils/collection_list_util.dart";
-
-void main() {
- test("keeps distinct uncategorized collections", () {
- final ownCollection = _uncategorizedCollection(1, 10);
- final sharedCollection = _uncategorizedCollection(2, 20);
-
- expect(
- uniqueCollectionsById([
- sharedCollection,
- ownCollection,
- sharedCollection,
- ]),
- [sharedCollection, ownCollection],
- );
- });
-
- test("finds the uncategorized collection owned by the user", () {
- final sharedCollection = _uncategorizedCollection(1, 20);
- final ownCollection = _uncategorizedCollection(2, 10);
-
- expect(
- findUserUncategorizedCollection([sharedCollection, ownCollection], 10),
- ownCollection,
- );
- });
-}
-
-Collection _uncategorizedCollection(int id, int ownerID) => Collection(
- id,
- User(id: ownerID, email: "[email protected]"),
- "",
- null,
- "Uncategorized",
- null,
- null,
- CollectionType.uncategorized,
- CollectionAttributes(),
- const [],
- const [],
- 0,
-);
diff --git a/mobile/apps/photos/test/models/ml/face/person_test.dart b/mobile/apps/photos/test/models/ml/face/person_test.dart
index 4ae9fc075c..f110289b85 100644
--- a/mobile/apps/photos/test/models/ml/face/person_test.dart
+++ b/mobile/apps/photos/test/models/ml/face/person_test.dart
@@ -3,13 +3,6 @@ import "package:photos/models/ml/face/person.dart";
void main() {
group("PersonData.fromJson", () {
- test("treats a missing name as an ignored unnamed person", () {
- final person = PersonData.fromJson({});
-
- expect(person.name, isEmpty);
- expect(person.isIgnored, isTrue);
- });
-
test("treats a null name as an ignored unnamed person", () {
final person = PersonData.fromJson({
"name": null,
@@ -26,16 +19,5 @@ void main() {
expect(person.assigned.single.id, "cluster-1");
expect(person.assigned.single.faces, {"face-1"});
});
-
- test("preserves a valid name", () {
- final person = PersonData.fromJson({"name": "Alex"});
-
- expect(person.name, "Alex");
- expect(person.isIgnored, isFalse);
- });
-
- test("rejects a non-string name", () {
- expect(() => PersonData.fromJson({"name": 7}), throwsA(isA<TypeError>()));
- });
});
}
diff --git a/mobile/apps/photos/test/ui/components/dialog_widget_test.dart b/mobile/apps/photos/test/ui/components/dialog_widget_test.dart
index 72fd8db134..be772ab7eb 100644
--- a/mobile/apps/photos/test/ui/components/dialog_widget_test.dart
+++ b/mobile/apps/photos/test/ui/components/dialog_widget_test.dart
@@ -7,6 +7,7 @@ import "package:photos/models/button_result.dart";
import "package:photos/ui/components/buttons/button_widget.dart";
import "package:photos/ui/components/dialog_widget.dart";
import "package:photos/ui/components/models/button_type.dart";
+import "package:photos/utils/dialog_util.dart";
void main() {
group("showDialogWidget", () {
diff --git a/mobile/apps/photos/test/ui/family/family_dashboard_test.dart b/mobile/apps/photos/test/ui/family/family_dashboard_test.dart
index 6becf3e3b0..f67ecb5e1e 100644
--- a/mobile/apps/photos/test/ui/family/family_dashboard_test.dart
+++ b/mobile/apps/photos/test/ui/family/family_dashboard_test.dart
@@ -13,121 +13,6 @@ import 'package:photos/ui/viewer/people/person_face_widget.dart';
import 'package:photos/utils/avatar_util.dart';
void main() {
- group('familyMemberActions', () {
- test('gates admin contact actions on user ID for active members', () {
- final memberWithUserID = _member(userID: 42);
- final memberWithoutUserID = _member();
-
- expect(
- familyMemberActions(
- isAdmin: true,
- isCurrentUser: false,
- member: memberWithUserID,
- hasSavedContact: false,
- ),
- [
- FamilyMemberAction.saveContact,
- FamilyMemberAction.editStorageLimit,
- FamilyMemberAction.removeMember,
- ],
- );
- expect(
- familyMemberActions(
- isAdmin: true,
- isCurrentUser: false,
- member: memberWithoutUserID,
- hasSavedContact: false,
- ),
- [FamilyMemberAction.editStorageLimit, FamilyMemberAction.removeMember],
- );
- expect(
- familyMemberActions(
- isAdmin: true,
- isCurrentUser: false,
- member: memberWithUserID,
- hasSavedContact: true,
- ),
- [
- FamilyMemberAction.editContact,
- FamilyMemberAction.editStorageLimit,
- FamilyMemberAction.removeMember,
- ],
- );
- });
-
- test(
- 'lets members manage contacts only for other members with user IDs',
- () {
- expect(
- familyMemberActions(
- isAdmin: false,
- isCurrentUser: false,
- member: _member(userID: 42),
- hasSavedContact: true,
- ),
- [FamilyMemberAction.editContact],
- );
- expect(
- familyMemberActions(
- isAdmin: false,
- isCurrentUser: false,
- member: _member(userID: 42),
- hasSavedContact: false,
- ),
- [FamilyMemberAction.saveContact],
- );
- expect(
- familyMemberActions(
- isAdmin: false,
- isCurrentUser: false,
- member: _member(),
- hasSavedContact: false,
- ),
- isEmpty,
- );
- expect(
- familyMemberActions(
- isAdmin: false,
- isCurrentUser: true,
- member: _member(userID: 42),
- hasSavedContact: true,
- ),
- isEmpty,
- );
- },
- );
-
- test(
- 'keeps pending-invite management while honoring provisioned user IDs',
- () {
- expect(
- familyMemberActions(
- isAdmin: true,
- isCurrentUser: false,
- member: _member(status: FamilyMemberStatus.invited, userID: 42),
- hasSavedContact: true,
- librarySharingEnabled: true,
- ),
- [
- FamilyMemberAction.editContact,
- FamilyMemberAction.resendInvite,
- FamilyMemberAction.revokeInvite,
- ],
- );
- expect(
- familyMemberActions(
- isAdmin: true,
- isCurrentUser: false,
- member: _member(status: FamilyMemberStatus.invited),
- hasSavedContact: false,
- librarySharingEnabled: true,
- ),
- [FamilyMemberAction.resendInvite, FamilyMemberAction.revokeInvite],
- );
- },
- );
- });
-
testWidgets(
'renders saved contacts and their shared-album counts at 375 pixels',
(tester) async {
diff --git a/mobile/apps/photos/test/ui/viewer/search/result/contact_person_picker_page_test.dart b/mobile/apps/photos/test/ui/viewer/search/result/contact_person_picker_page_test.dart
deleted file mode 100644
index 726d14aeb4..0000000000
--- a/mobile/apps/photos/test/ui/viewer/search/result/contact_person_picker_page_test.dart
+++ /dev/null
@@ -1,57 +0,0 @@
-import "package:flutter_test/flutter_test.dart";
-import "package:photos/models/file/file.dart";
-import "package:photos/models/ml/face/person.dart";
-import "package:photos/models/search/generic_search_result.dart";
-import "package:photos/models/search/hierarchical/face_filter.dart";
-import "package:photos/models/search/search_constants.dart";
-import "package:photos/models/search/search_types.dart";
-import "package:photos/ui/viewer/search/result/contact_person_picker_page.dart";
-
-void main() {
- test("orders unassigned face clusters by photo frequency", () {
- final person = PersonEntity("person-1", PersonData(name: "Alex"));
-
- final candidates = buildContactPersonPickerCandidates(
- faceResults: [
- _faceResult(personID: "person-1", fileCount: 2),
- _faceResult(clusterID: "cluster-small", fileCount: 1),
- _faceResult(clusterID: "cluster-large", fileCount: 5),
- ],
- persons: [person],
- );
-
- expect(candidates, hasLength(3));
- expect(
- (candidates.first as ContactPersonPickerPersonCandidate).person,
- same(person),
- );
- expect(
- candidates
- .skip(1)
- .cast<ContactPersonPickerClusterCandidate>()
- .map((candidate) => candidate.clusterID),
- ["cluster-large", "cluster-small"],
- );
- });
-}
-
-GenericSearchResult _faceResult({
- String? personID,
- String? clusterID,
- required int fileCount,
-}) {
- final files = List.generate(fileCount, (_) => EnteFile());
- return GenericSearchResult(
- ResultType.faces,
- "",
- files,
- params: {kPersonParamID: ?personID, kClusterParamId: ?clusterID},
- hierarchicalSearchFilter: FaceFilter(
- personId: personID,
- clusterId: clusterID,
- faceName: null,
- faceFile: files.first,
- occurrence: fileCount,
- ),
- );
-}
diff --git a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
index 7b1ff8f74f..8a9bc24d79 100644
--- a/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
+++ b/mobile/packages/ente_components/test/components/app_surface_widgets_test.dart
@@ -352,42 +352,6 @@ void main() {
expect(tester.takeException(), isNull);
});
- testWidgets('SliverAppBarComponent preserves title callbacks with eyebrow', (
- tester,
- ) async {
- var tapped = false;
-
- await pumpComponent(
- tester,
- CustomScrollView(
- slivers: [
- SliverAppBarComponent(
- title: 'Tap me',
- eyebrow: 'Context',
- onTitleTap: () => tapped = true,
- actions: const [Icon(Icons.search)],
- ),
- SliverList.builder(
- itemCount: 8,
- itemBuilder: (context, index) {
- return SizedBox(height: 60, child: Text('Item $index'));
- },
- ),
- ],
- ),
- width: 320,
- height: 360,
- );
-
- expect(find.byType(TooltipComponent), findsNothing);
-
- await tester.tap(find.text('Tap me'));
- await tester.pump();
-
- expect(tapped, isTrue);
- expect(tester.takeException(), isNull);
- });
-
testWidgets(
'SliverAppBarComponent collapses title content and reserved space',
(tester) async {
diff --git a/mobile/packages/ente_components/test/components/avatar_test.dart b/mobile/packages/ente_components/test/components/avatar_test.dart
index b9e9cb1eca..113441e893 100644
--- a/mobile/packages/ente_components/test/components/avatar_test.dart
+++ b/mobile/packages/ente_components/test/components/avatar_test.dart
@@ -9,20 +9,4 @@ void main() {
);
expect(avatarSeedForIdentity('[email protected]'), 2493822278);
});
-
- test('component identity colors use the Figma avatar palette', () {
- final color = avatarComponentColorForIdentity('email:[email protected]');
-
- expect(avatarComponentColorForIdentity(' EMAIL:[email protected] '), color);
- expect(color, isIn(avatarComponentIdentityPalette));
- expect(avatarComponentIdentityPalette, const [
- AvatarComponentColor.yellow,
- AvatarComponentColor.green,
- AvatarComponentColor.orange,
- AvatarComponentColor.pink,
- AvatarComponentColor.purple,
- AvatarComponentColor.blue,
- AvatarComponentColor.cyan,
- ]);
- });
}
diff --git a/mobile/packages/ente_components/test/components/button_test.dart b/mobile/packages/ente_components/test/components/button_test.dart
index 84de1c640a..650b896f5f 100644
--- a/mobile/packages/ente_components/test/components/button_test.dart
+++ b/mobile/packages/ente_components/test/components/button_test.dart
@@ -264,30 +264,6 @@ void main() {
expect(find.text("Fail"), findsOneWidget);
});
- testWidgets("IconButtonComponent can handle tap down without onTap", (
- tester,
- ) async {
- TapDownDetails? tapDownDetails;
-
- await tester.pumpWidget(
- _wrap(
- IconButtonComponent(
- icon: const Icon(Icons.add),
- onTapDown: (details) => tapDownDetails = details,
- ),
- ),
- );
-
- final surfaceFinder = find.byKey(const ValueKey('icon-button-surface'));
- final gesture = await tester.startGesture(tester.getCenter(surfaceFinder));
- await tester.pump();
-
- expect(tapDownDetails, isNotNull);
- expect(_iconButtonColor(tester), Colors.transparent);
-
- await gesture.up();
- });
-
testWidgets("IconButtonComponent resets state after async errors", (
tester,
) async {
@@ -414,10 +390,3 @@ Widget _wrapModalTestApp({
),
);
}
-
-Color _iconButtonColor(WidgetTester tester) {
- final container = tester.widget<AnimatedContainer>(
- find.byKey(const ValueKey('icon-button-surface')),
- );
- return (container.decoration! as BoxDecoration).color!;
-}
diff --git a/mobile/packages/ente_components/test/components/selection_controls_test.dart b/mobile/packages/ente_components/test/components/selection_controls_test.dart
index 1e7d2c6970..2ca360ff5b 100644
--- a/mobile/packages/ente_components/test/components/selection_controls_test.dart
+++ b/mobile/packages/ente_components/test/components/selection_controls_test.dart
@@ -1,7 +1,6 @@
import "dart:async";
import "package:ente_components/ente_components.dart";
-import "package:flutter/cupertino.dart";
import "package:flutter/material.dart";
import "package:flutter_test/flutter_test.dart";
@@ -129,29 +128,6 @@ void main() {
expect(find.byKey(const ValueKey('toggle-state-idle')), findsOneWidget);
});
- testWidgets("ToggleSwitchComponent uses Cupertino switch on iOS", (
- tester,
- ) async {
- bool? nextValue;
-
- await tester.pumpWidget(
- _wrap(
- ToggleSwitchComponent(
- selected: false,
- onChanged: (value) => nextValue = value,
- ),
- platform: TargetPlatform.iOS,
- ),
- );
-
- await tester.tap(find.byType(CupertinoSwitch));
- await tester.pump();
-
- expect(nextValue, isTrue);
- expect(find.byType(Switch), findsNothing);
- await tester.pump(const Duration(milliseconds: 200));
- });
-
testWidgets("LabeledControlComponent wraps long labels", (tester) async {
const label =
"This is a deliberately long label that should wrap inside the control row";
@@ -186,74 +162,13 @@ void main() {
greaterThan(40),
);
});
-
- testWidgets("FilterChipComponent keeps avatar fixed by default", (
- tester,
- ) async {
- await tester.pumpWidget(
- _wrap(
- const FilterChipComponent(
- avatar: ColoredBox(key: ValueKey("avatar"), color: Colors.purple),
- state: FilterChipComponentState.unselected,
- ),
- textScaler: const TextScaler.linear(2),
- ),
- );
-
- expect(
- tester.getSize(find.byKey(const ValueKey("avatar"))),
- const Size.square(32),
- );
- });
-
- testWidgets("FilterChipComponent scales avatar when enabled", (tester) async {
- await tester.pumpWidget(
- _wrap(
- const FilterChipComponent(
- avatar: ColoredBox(key: ValueKey("avatar"), color: Colors.purple),
- state: FilterChipComponentState.unselected,
- scaleAvatarWithText: true,
- ),
- textScaler: const TextScaler.linear(2),
- ),
- );
-
- expect(
- tester.getSize(find.byKey(const ValueKey("avatar"))),
- const Size.square(48),
- );
- });
-
- testWidgets("FilterChipComponent scales custom avatar size when needed", (
- tester,
- ) async {
- await tester.pumpWidget(
- _wrap(
- const FilterChipComponent(
- avatar: ColoredBox(key: ValueKey("avatar"), color: Colors.purple),
- state: FilterChipComponentState.unselected,
- avatarSize: 40,
- scaleAvatarWithText: true,
- ),
- textScaler: const TextScaler.linear(2),
- ),
- );
-
- expect(
- tester.getSize(find.byKey(const ValueKey("avatar"))),
- const Size.square(48),
- );
- });
}
-Widget _wrap(
- Widget child, {
- TargetPlatform platform = TargetPlatform.android,
- TextScaler textScaler = TextScaler.noScaling,
- ThemeData? theme,
-}) {
+Widget _wrap(Widget child, {TextScaler textScaler = TextScaler.noScaling}) {
return MaterialApp(
- theme: (theme ?? ComponentTheme.lightTheme()).copyWith(platform: platform),
+ theme: ComponentTheme.lightTheme().copyWith(
+ platform: TargetPlatform.android,
+ ),
home: MediaQuery(
data: MediaQueryData(textScaler: textScaler),
child: Scaffold(body: Center(child: child)),
diff --git a/mobile/packages/ente_components/test/theme/theme_tokens_test.dart b/mobile/packages/ente_components/test/theme/theme_tokens_test.dart
deleted file mode 100644
index da26ba8cc0..0000000000
--- a/mobile/packages/ente_components/test/theme/theme_tokens_test.dart
+++ /dev/null
@@ -1,102 +0,0 @@
-import "package:ente_components/ente_components.dart";
-import "package:flutter/material.dart";
-import "package:flutter_test/flutter_test.dart";
-
-void main() {
- group("theme", () {
- testWidgets("selects color tokens from the ambient brightness", (
- tester,
- ) async {
- late ColorTokens lightColors;
- late ColorTokens darkColors;
-
- await tester.pumpWidget(
- Theme(
- data: ComponentTheme.lightTheme(),
- child: Builder(
- builder: (context) {
- lightColors = ComponentTheme.colorsOf(context);
- return const SizedBox.shrink();
- },
- ),
- ),
- );
-
- await tester.pumpWidget(
- Theme(
- data: ComponentTheme.darkTheme(),
- child: Builder(
- builder: (context) {
- darkColors = context.componentColors;
- return const SizedBox.shrink();
- },
- ),
- ),
- );
-
- expect(lightColors.backgroundBase, ColorTokens.light.backgroundBase);
- expect(lightColors.textBase, ColorTokens.light.textBase);
- expect(darkColors.backgroundBase, ColorTokens.dark.backgroundBase);
- expect(darkColors.textBase, ColorTokens.dark.textBase);
- });
-
- testWidgets("reads app-aware tokens from ComponentTheme ThemeData", (
- tester,
- ) async {
- late ColorTokens authColors;
- late ColorTokens lockerColors;
-
- await tester.pumpWidget(
- Theme(
- data: ComponentTheme.lightTheme(app: ComponentApp.auth),
- child: Builder(
- builder: (context) {
- authColors = context.componentColors;
- return const SizedBox.shrink();
- },
- ),
- ),
- );
-
- await tester.pumpWidget(
- Theme(
- data: ComponentTheme.darkTheme(app: ComponentApp.locker),
- child: Builder(
- builder: (context) {
- lockerColors = context.componentColors;
- return const SizedBox.shrink();
- },
- ),
- ),
- );
-
- expect(authColors.primary, purpleDefaultLight);
- expect(authColors.backgroundBase, ColorTokens.light.backgroundBase);
- expect(lockerColors.primary, blueDefaultDark);
- expect(lockerColors.backgroundBase, ColorTokens.dark.backgroundBase);
- });
-
- testWidgets("uses configured app tokens when ThemeData has no extension", (
- tester,
- ) async {
- addTearDown(() => ComponentTheme.configure(app: ComponentApp.photos));
- ComponentTheme.configure(app: ComponentApp.locker);
-
- late ColorTokens colors;
- await tester.pumpWidget(
- Theme(
- data: ThemeData(brightness: Brightness.dark),
- child: Builder(
- builder: (context) {
- colors = context.componentColors;
- return const SizedBox.shrink();
- },
- ),
- ),
- );
-
- expect(colors.primary, blueDefaultDark);
- expect(colors.backgroundBase, ColorTokens.dark.backgroundBase);
- });
- });
-}
diff --git a/mobile/packages/ente_pure_utils/test/locale_display_name_test.dart b/mobile/packages/ente_pure_utils/test/locale_display_name_test.dart
deleted file mode 100644
index 6a6e689b69..0000000000
--- a/mobile/packages/ente_pure_utils/test/locale_display_name_test.dart
+++ /dev/null
@@ -1,48 +0,0 @@
-import 'package:ente_pure_utils/ente_pure_utils.dart';
-import 'package:flutter/widgets.dart';
-import 'package:flutter_test/flutter_test.dart';
-
-void main() {
- group('getLocaleDisplayName', () {
- test('labels Chinese variants by region', () {
- expect(getLocaleDisplayName(const Locale('zh', 'CN')), '中文 (中国)');
- expect(getLocaleDisplayName(const Locale('zh', 'TW')), '中文 (台灣)');
- expect(getLocaleDisplayName(const Locale('zh', 'HK')), '中文 (香港)');
- });
-
- test('labels Chinese variants by script', () {
- expect(
- getLocaleDisplayName(
- const Locale.fromSubtags(languageCode: 'zh', scriptCode: 'Hans'),
- ),
- '中文 (简体)',
- );
- expect(
- getLocaleDisplayName(
- const Locale.fromSubtags(languageCode: 'zh', scriptCode: 'Hant'),
- ),
- '中文 (繁體)',
- );
- });
-
- test('keeps auth language selector labels', () {
- expect(getLocaleDisplayName(const Locale('ar')), 'العربية');
- expect(getLocaleDisplayName(const Locale('bg')), 'Български');
- expect(
- getLocaleDisplayName(const Locale('es', 'ES')),
- 'Español (España)',
- );
- expect(getLocaleDisplayName(const Locale('fa')), 'فارسی');
- expect(getLocaleDisplayName(const Locale('fi')), 'Suomi');
- expect(getLocaleDisplayName(const Locale('he')), 'עברית');
- expect(getLocaleDisplayName(const Locale('id')), 'Bahasa Indonesia');
- expect(getLocaleDisplayName(const Locale('ko')), '한국어');
- expect(
- getLocaleDisplayName(const Locale('pt', 'BR')),
- 'Português (Brasil)',
- );
- expect(getLocaleDisplayName(const Locale('sk')), 'Slovenčina');
- expect(getLocaleDisplayName(const Locale('sl')), 'Slovenščina');
- });
- });
-}
diff --git a/mobile/packages/ente_qr_scanner/test/ente_qr_scanner_test.dart b/mobile/packages/ente_qr_scanner/test/ente_qr_scanner_test.dart
deleted file mode 100644
index 4f0b83b56f..0000000000
--- a/mobile/packages/ente_qr_scanner/test/ente_qr_scanner_test.dart
+++ /dev/null
@@ -1,18 +0,0 @@
-import 'package:ente_qr_scanner/ente_qr_scanner.dart';
-import 'package:flutter/material.dart';
-import 'package:flutter_test/flutter_test.dart';
-
-void main() {
- test('overlay serializes creation params', () {
- const overlay = EnteQrScannerOverlay(
- borderColor: Colors.green,
- overlayColor: Colors.black54,
- cutOutSize: 240,
- borderRadius: 10,
- borderLength: 28,
- borderWidth: 3,
- );
-
- expect(overlay.toCreationParams(), {'cutOutSize': 240.0});
- });
-}
diff --git a/server/ente/admin_test.go b/server/ente/admin_test.go
deleted file mode 100644
index eddc885283..0000000000
--- a/server/ente/admin_test.go
+++ /dev/null
@@ -1,31 +0,0 @@
-package ente
-
-import "testing"
-
-func TestSupportUpdateBonusValidate_AllowsNonProfitBonus(t *testing.T) {
- req := SupportUpdateBonus{
- BonusType: "ADD_ON_NON_PROFIT",
- Action: ADD,
- UserID: 1,
- Year: 3,
- StorageInGB: 200,
- }
-
- if err := req.Validate(); err != nil {
- t.Fatalf("expected non-profit bonus to be valid, got error: %v", err)
- }
-}
-
-func TestSupportUpdateBonusValidate_RejectsInvalidNonProfitBonus(t *testing.T) {
- req := SupportUpdateBonus{
- BonusType: "ADD_ON_NON_PROFIT",
- Action: ADD,
- UserID: 1,
- Year: 101,
- StorageInGB: 200,
- }
-
- if err := req.Validate(); err == nil {
- t.Fatal("expected invalid non-profit bonus to be rejected")
- }
-}
diff --git a/server/ente/public_collection_test.go b/server/ente/public_collection_test.go
index 0768a6dac7..9b23424a03 100644
--- a/server/ente/public_collection_test.go
+++ b/server/ente/public_collection_test.go
@@ -2,26 +2,6 @@ package ente
import "testing"
-func TestCreatePublicAccessTokenRequestValidatesDeviceLimit(t *testing.T) {
- for _, test := range []struct {
- name string
- deviceLimit int
- wantError bool
- }{
- {name: "negative", deviceLimit: -1, wantError: true},
- {name: "unlimited", deviceLimit: 0},
- {name: "maximum", deviceLimit: 50},
- {name: "over maximum", deviceLimit: 51, wantError: true},
- } {
- t.Run(test.name, func(t *testing.T) {
- err := (&CreatePublicAccessTokenRequest{DeviceLimit: test.deviceLimit}).Validate()
- if (err != nil) != test.wantError {
- t.Fatalf("Validate() error = %v, wantError = %t", err, test.wantError)
- }
- })
- }
-}
-
func TestFilterPublicURLsForRole(t *testing.T) {
viewer := VIEWER
collaborator := COLLABORATOR
diff --git a/server/ente/remotestore_test.go b/server/ente/remotestore_test.go
index 5adafe787b..d8c8edcf95 100644
--- a/server/ente/remotestore_test.go
+++ b/server/ente/remotestore_test.go
@@ -71,39 +71,3 @@ func TestValidatePublicCustomDomain(t *testing.T) {
})
}
}
-
-func TestFlagKey_IsValidValue(t *testing.T) {
- tests := []struct {
- name string
- key FlagKey
- value string
- wantErr bool
- }{
- {"valid true for bool key", MapEnabled, "true", false},
- {"valid false for bool key", FaceSearchEnabled, "false", false},
-
- {"invalid value for bool key", PassKeyEnabled, "yes", true},
- {"empty value for bool key", IsInternalUser, "", true},
-
- {"valid custom domain", CustomDomain, "example.com", false},
- {"valid subdomain", CustomDomain, "sub.example.com", false},
- {"valid family custom domain pointer", CustomDomain, "_123:example.com", false},
-
- {"empty custom domain", CustomDomain, "", false},
- {"custom domain with scheme", CustomDomain, "http://example.com", true},
- {"custom domain with invalid format", CustomDomain, "exa$mple.com", true},
- {"custom domain with leading space", CustomDomain, " example.com", true},
- {"custom domain with trailing space", CustomDomain, "example.com ", true},
- {"invalid family custom domain pointer missing admin", CustomDomain, "_:example.com", true},
- {"invalid family custom domain pointer invalid domain", CustomDomain, "_123:exa$mple.com", true},
- }
-
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- err := tt.key.IsValidValue(tt.value)
- if (err != nil) != tt.wantErr {
- t.Errorf("FlagKey(%q).IsValidValue(%q) error = %v, wantErr %v", tt.key, tt.value, err, tt.wantErr)
- }
- })
- }
-}
diff --git a/server/ente/storagebonus/storge_bonus_test.go b/server/ente/storagebonus/storge_bonus_test.go
deleted file mode 100644
index 10778ebe6d..0000000000
--- a/server/ente/storagebonus/storge_bonus_test.go
+++ /dev/null
@@ -1,22 +0,0 @@
-package storagebonus
-
-import (
- "slices"
- "testing"
-)
-
-func TestAddOnNonProfitBonusProperties(t *testing.T) {
- if got := BonusFromType("ADD_ON_NON_PROFIT"); got != AddOnNonProfit {
- t.Fatalf("expected ADD_ON_NON_PROFIT to map to AddOnNonProfit, got %q", got)
- }
- if !AddOnNonProfit.ExtendsExpiry() {
- t.Fatal("expected ADD_ON_NON_PROFIT to extend expiry")
- }
- if AddOnNonProfit.RestrictToDoublingStorage() {
- t.Fatal("expected ADD_ON_NON_PROFIT to behave like an add-on bonus")
- }
-
- if !slices.Contains(PaidAddOnTypes, AddOnNonProfit) {
- t.Fatal("expected ADD_ON_NON_PROFIT to be treated as a paid add-on type")
- }
-}
diff --git a/server/pkg/api/user_test.go b/server/pkg/api/user_test.go
index c0d897682a..546f631cb9 100644
--- a/server/pkg/api/user_test.go
+++ b/server/pkg/api/user_test.go
@@ -1,7 +1,6 @@
package api
import (
- "bytes"
"database/sql"
"encoding/json"
"net/http"
@@ -17,42 +16,6 @@ import (
"github.com/gin-gonic/gin"
)
-func TestSetAttributesHandlerRejectsUnexpectedKDFStrength(t *testing.T) {
- handler, db := setupUserHandlerTest(t)
-
- userID := testutil.InsertUser(t, db, testutil.UserFixture{
- UserID: 101,
- Email: "[email protected]",
- CreationTime: 1,
- })
-
- body := map[string]any{
- "keyAttributes": validSetAttributesPayload(128*1024*1024, 31),
- }
-
- recorder := performSetAttributesRequest(t, handler, userID, body)
-
- assertAPIErrorResponse(t, recorder, http.StatusBadRequest, ente.BadRequest, "Unexpected KDF strength")
-}
-
-func TestSetAttributesHandlerRejectsLowMemoryLimit(t *testing.T) {
- handler, db := setupUserHandlerTest(t)
-
- userID := testutil.InsertUser(t, db, testutil.UserFixture{
- UserID: 102,
- Email: "[email protected]",
- CreationTime: 1,
- })
-
- body := map[string]any{
- "keyAttributes": validSetAttributesPayload(64*1024*1024, 64),
- }
-
- recorder := performSetAttributesRequest(t, handler, userID, body)
-
- assertAPIErrorResponse(t, recorder, http.StatusBadRequest, ente.BadRequest, "memory limit must be at least 128MB")
-}
-
func TestGetPublicKeyHandlerUsesEmailLookup(t *testing.T) {
handler, db := setupUserHandlerTest(t)
requesterUserID := testutil.InsertUser(t, db, testutil.UserFixture{
@@ -163,59 +126,3 @@ func setupUserHandlerTest(t *testing.T) (*UserHandler, *sql.DB) {
},
}, db
}
-
-func performSetAttributesRequest(t *testing.T, handler *UserHandler, userID int64, body map[string]any) *httptest.ResponseRecorder {
- t.Helper()
-
- gin.SetMode(gin.TestMode)
-
- payload, err := json.Marshal(body)
- if err != nil {
- t.Fatalf("failed to marshal request body: %v", err)
- }
-
- recorder := httptest.NewRecorder()
- req := httptest.NewRequest(http.MethodPost, "/user/attributes", bytes.NewReader(payload))
- req.Header.Set("Content-Type", "application/json")
- req.Header.Set("X-Auth-User-ID", strconv.FormatInt(userID, 10))
-
- router := gin.New()
- router.POST("/user/attributes", handler.SetAttributes)
- router.ServeHTTP(recorder, req)
-
- return recorder
-}
-
-func validSetAttributesPayload(memLimit, opsLimit int) map[string]any {
- return map[string]any{
- "kekSalt": "kek-salt",
- "encryptedKey": "encrypted-key",
- "keyDecryptionNonce": "key-nonce",
- "publicKey": "public-key",
- "encryptedSecretKey": "encrypted-secret-key",
- "secretKeyDecryptionNonce": "secret-key-nonce",
- "memLimit": memLimit,
- "opsLimit": opsLimit,
- }
-}
-
-func assertAPIErrorResponse(t *testing.T, recorder *httptest.ResponseRecorder, wantStatus int, wantCode ente.ErrorCode, wantMessage string) {
- t.Helper()
-
- if recorder.Code != wantStatus {
- t.Fatalf("unexpected status code: got %d want %d; body=%s", recorder.Code, wantStatus, recorder.Body.String())
- }
-
- var apiErr ente.ApiError
- if err := json.Unmarshal(recorder.Body.Bytes(), &apiErr); err != nil {
- t.Fatalf("failed to decode response body %q: %v", recorder.Body.String(), err)
- }
-
- if apiErr.Code != wantCode {
- t.Fatalf("unexpected error code: got %q want %q", apiErr.Code, wantCode)
- }
-
- if apiErr.Message != wantMessage {
- t.Fatalf("unexpected error message: got %q want %q", apiErr.Message, wantMessage)
- }
-}
diff --git a/server/pkg/api/userentity_test.go b/server/pkg/api/userentity_test.go
index 790f259ff8..1c7bbceff8 100644
--- a/server/pkg/api/userentity_test.go
+++ b/server/pkg/api/userentity_test.go
@@ -71,7 +71,16 @@ func TestCreateUserEntityKeyReturnsAlreadyExistsForConflictingCreate(t *testing.
}
second := performCreateUserEntityKeyRequest(t, handler, userID, secondBody)
- assertAPIErrorResponse(t, second, http.StatusConflict, ente.AlreadyExists, "Key already exists")
+ if second.Code != http.StatusConflict {
+ t.Fatalf("unexpected status code: got %d want %d; body=%s", second.Code, http.StatusConflict, second.Body.String())
+ }
+ var apiErr ente.ApiError
+ if err := json.Unmarshal(second.Body.Bytes(), &apiErr); err != nil {
+ t.Fatalf("failed to decode response body: %v", err)
+ }
+ if apiErr.Code != ente.AlreadyExists || apiErr.Message != "Key already exists" {
+ t.Fatalf("unexpected error response: %+v", apiErr)
+ }
}
func TestEnsureUserEntityKeyReturnsExistingKeyForConflict(t *testing.T) {
diff --git a/server/pkg/controller/collections/share_test.go b/server/pkg/controller/collections/share_test.go
index 8f6b387cf5..1abe2228b9 100644
--- a/server/pkg/controller/collections/share_test.go
+++ b/server/pkg/controller/collections/share_test.go
@@ -170,20 +170,6 @@ func addShareTestOwnerFile(t *testing.T, db *sql.DB, collectionID, ownerID int64
return fileID
}
-func TestShareeIndexForEmail(t *testing.T) {
- sharees := []ente.CollectionUser{
- {ID: 1, Email: "[email protected]"},
- {ID: 2, Email: "[email protected]"},
- }
-
- if got := shareeIndexForEmail(sharees, " [email protected] "); got != 1 {
- t.Fatalf("sharee index = %d, want 1", got)
- }
- if got := shareeIndexForEmail(sharees, "[email protected]"); got != -1 {
- t.Fatalf("missing sharee index = %d, want -1", got)
- }
-}
-
func TestUnShareResolvesTargetFromCurrentSharees(t *testing.T) {
testutil.WithServerRoot(t)
db := testutil.RequireTestDB(t)
diff --git a/server/pkg/controller/public/free_user_device_limit_test.go b/server/pkg/controller/public/free_user_device_limit_test.go
deleted file mode 100644
index 7e88ee339c..0000000000
--- a/server/pkg/controller/public/free_user_device_limit_test.go
+++ /dev/null
@@ -1,21 +0,0 @@
-package public
-
-import "testing"
-
-func TestIsAllowedFreeUserDeviceLimit(t *testing.T) {
- if FreeUserDeviceLimit != 10 {
- t.Fatalf("free user device limit = %d, want 10", FreeUserDeviceLimit)
- }
-
- for _, deviceLimit := range []int{FreeUserDeviceLimit, 5} {
- if !IsAllowedFreeUserDeviceLimit(deviceLimit) {
- t.Fatalf("device limit %d should be allowed for free users", deviceLimit)
- }
- }
-
- for _, deviceLimit := range []int{0, 1, 2, 25, 50} {
- if IsAllowedFreeUserDeviceLimit(deviceLimit) {
- t.Fatalf("device limit %d should not be allowed for free users", deviceLimit)
- }
- }
-}
diff --git a/server/pkg/repo/collection_actions_test.go b/server/pkg/repo/collection_actions_test.go
deleted file mode 100644
index 29f4ebb03a..0000000000
--- a/server/pkg/repo/collection_actions_test.go
+++ /dev/null
@@ -1,38 +0,0 @@
-package repo
-
-import (
- "encoding/json"
- "testing"
-)
-
-func TestMarshalCollectionActionData(t *testing.T) {
- payload, err := marshalCollectionActionData(nil)
- if err != nil {
- t.Fatalf("unexpected error for nil data: %v", err)
- }
- if payload != nil {
- t.Fatalf("expected nil payload for nil data, got %v", payload)
- }
-
- data := map[string]interface{}{
- "reason": "admin_remove",
- "id": float64(42),
- }
- payload, err = marshalCollectionActionData(data)
- if err != nil {
- t.Fatalf("unexpected error for valid data: %v", err)
- }
-
- payloadStr, ok := payload.(string)
- if !ok {
- t.Fatalf("expected payload to be a string, got %T", payload)
- }
-
- var decoded map[string]interface{}
- if err := json.Unmarshal([]byte(payloadStr), &decoded); err != nil {
- t.Fatalf("payload should be valid json, got error %v", err)
- }
- if decoded["reason"] != data["reason"] || decoded["id"] != data["id"] {
- t.Fatalf("decoded payload mismatch. expected %v, got %v", data, decoded)
- }
-}
diff --git a/server/pkg/repo/storagebonus/referral_codes_test.go b/server/pkg/repo/storagebonus/referral_codes_test.go
index c4bfe0b669..837a71daf9 100644
--- a/server/pkg/repo/storagebonus/referral_codes_test.go
+++ b/server/pkg/repo/storagebonus/referral_codes_test.go
@@ -48,19 +48,6 @@ func TestGetReferralCode(t *testing.T) {
assert.Equal(t, newCode, *code)
}
-func TestInsertReferralCode(t *testing.T) {
- ctx := t.Context()
- repo := newStorageBonusTestRepository(t)
- userID := int64(2)
- code := "AAEEDD"
- err := repo.InsertCode(ctx, userID, code)
- assert.Nil(t, err)
-
- codeNew, err := repo.GetCode(ctx, userID)
- assert.Nil(t, err)
- assert.Equal(t, code, *codeNew)
-}
-
func TestAddNewReferralCode(t *testing.T) {
ctx := t.Context()
repo := newStorageBonusTestRepository(t)