Skip to content

EspoCRM – Open Source CRM Application

role edit view performance improvement

Yuri Kuznetsov0aae87a2488d
diff --git a/client/src/ui/select.js b/client/src/ui/select.js
index 43b17fed33..08a9a29049 100644
--- a/client/src/ui/select.js
+++ b/client/src/ui/select.js
@@ -42,6 +42,8 @@ import Selectize from 'lib!selectize';
* @property {'value'|'text'|'$order'|'$score'} [sortBy='$order'] Item sorting.
* @property {'asc'|'desc'} [sortDirection='asc'] Sort direction.
* @property {function()} [onFocus] On-focus callback.
+ * @property {boolean} [requestAnimationFrame] If many elements rendered on the same form, it significantly
+ * boosts rendering performance.
*/
/**
@@ -119,6 +121,7 @@ const Select = {
allowEmptyOption: allowedValues.includes(''),
showEmptyOptionInDropdown: true,
$relativeParent: $relativeParent,
+ requestAnimationFrame: options.requestAnimationFrame,
render: {
item: function (data) {
return $('<div>')
diff --git a/client/src/views/fields/enum.js b/client/src/views/fields/enum.js
index 1537ffa87d..e42748c736 100644
--- a/client/src/views/fields/enum.js
+++ b/client/src/views/fields/enum.js
@@ -97,6 +97,12 @@ class EnumFieldView extends BaseFieldView {
validationElementSelector = '.selectize-control'
+ /**
+ * @protected
+ * @type {boolean}
+ */
+ requestAnimationFrame = false
+
// noinspection JSCheckFunctionSignatures
/** @inheritDoc */
data() {
@@ -423,7 +429,10 @@ class EnumFieldView extends BaseFieldView {
}
if (this.isEditMode() || this.isSearchMode()) {
- Select.init(this.$element, {matchAnyWord: true});
+ Select.init(this.$element, {
+ matchAnyWord: true,
+ requestAnimationFrame: this.requestAnimationFrame,
+ });
}
}
diff --git a/client/src/views/role/record/table.js b/client/src/views/role/record/table.js
index b8f5d9dae5..59aebc4b13 100644
--- a/client/src/views/role/record/table.js
+++ b/client/src/views/role/record/table.js
@@ -395,7 +395,7 @@ class RoleRecordTableView extends View {
this.formModel.set(scope, scopeItem.access, {silent: true});
- const view = new EnumFieldView({
+ const view = new CustomEnumFieldView({
name: scope,
model: this.formModel,
mode: this.mode,
@@ -429,7 +429,7 @@ class RoleRecordTableView extends View {
this.formModel.set(name, actionItem.level, {silent: true});
- const view = new EnumFieldView({
+ const view = new CustomEnumFieldView({
name: name,
model: this.formModel,
mode: this.mode,
@@ -513,7 +513,7 @@ class RoleRecordTableView extends View {
this.formModel.set(name, actionItem.value, {silent: true});
- const view = new EnumFieldView({
+ const view = new CustomEnumFieldView({
name: name,
model: this.formModel,
mode: this.mode,
@@ -1214,4 +1214,9 @@ class RoleRecordTableView extends View {
}
}
+class CustomEnumFieldView extends EnumFieldView {
+
+ requestAnimationFrame = true
+}
+
export default RoleRecordTableView;
diff --git a/package-lock.json b/package-lock.json
index abedb8d453..70ccaaf56f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -43,7 +43,7 @@
"moment-timezone": "^0.5.41",
"moment-timezone-data-build": "github:yurikuzn/moment-timezone-data-build#0.1.1",
"qrcodejs": "^1.0.0",
- "selectize": "github:selectize/selectize.js#v0.13.6",
+ "selectize": "github:yurikuzn/selectize-for-espo#0.1.0",
"set-value": ">=4.0.1",
"summernote": "^0.9.1",
"timepicker": "^1.11.15",
@@ -6346,10 +6346,9 @@
"optional": true
},
"node_modules/selectize": {
- "name": "@selectize/selectize",
- "version": "0.13.6",
- "resolved": "git+ssh://[email protected]/selectize/selectize.js.git#9ac0506e73fdf72b5b09571f2fec8124658866eb",
- "license": "Apache-2.0",
+ "name": "selectize-for-espo",
+ "version": "0.1.0",
+ "resolved": "git+ssh://[email protected]/yurikuzn/selectize-for-espo.git#000086f61efdd25b4f31911bfad88f04968efeba",
"dependencies": {
"@selectize/sifter": "^0.6.2",
"microplugin": "0.0.3"
@@ -11990,8 +11989,8 @@
"optional": true
},
"selectize": {
- "version": "git+ssh://[email protected]/selectize/selectize.js.git#9ac0506e73fdf72b5b09571f2fec8124658866eb",
- "from": "selectize@github:selectize/selectize.js#v0.13.6",
+ "version": "git+ssh://[email protected]/yurikuzn/selectize-for-espo.git#000086f61efdd25b4f31911bfad88f04968efeba",
+ "from": "selectize@github:yurikuzn/selectize-for-espo#0.1.0",
"requires": {
"@selectize/sifter": "^0.6.2",
"jquery-ui": "^1.13.0",
diff --git a/package.json b/package.json
index 87a7515525..b117e7f1f6 100644
--- a/package.json
+++ b/package.json
@@ -73,7 +73,7 @@
"moment-timezone": "^0.5.41",
"moment-timezone-data-build": "github:yurikuzn/moment-timezone-data-build#0.1.1",
"qrcodejs": "^1.0.0",
- "selectize": "github:selectize/selectize.js#v0.13.6",
+ "selectize": "github:yurikuzn/selectize-for-espo#0.1.0",
"set-value": ">=4.0.1",
"summernote": "^0.9.1",
"timepicker": "^1.11.15",