Skip to content

EspoCRM – Open Source CRM Application

mass convert currency catch bad request

Yuri Kuznetsov20391bee3e10
diff --git a/application/Espo/Core/MassAction/Actions/MassConvertCurrency.php b/application/Espo/Core/MassAction/Actions/MassConvertCurrency.php
index b39796822b..177cb9a4ab 100644
--- a/application/Espo/Core/MassAction/Actions/MassConvertCurrency.php
+++ b/application/Espo/Core/MassAction/Actions/MassConvertCurrency.php
@@ -48,6 +48,7 @@ use Espo\Core\Utils\Metadata;
use Espo\Entities\User;
use Espo\Tools\Currency\Conversion\EntityConverterFactory;
use RuntimeException;
+use Throwable;
/**
* @noinspection PhpUnused
@@ -123,7 +124,7 @@ class MassConvertCurrency implements MassAction
try {
$converter->convert($entity, $targetCurrency, $rates);
- } catch (Forbidden $e) {
+ } catch (Forbidden|BadRequest $e) {
$this->log->info("Could not convert currency for {id}.", [
'id' => $entity->getId(),
'exception' => $e,
diff --git a/application/Espo/Tools/Currency/Conversion/EntityConverter.php b/application/Espo/Tools/Currency/Conversion/EntityConverter.php
index 262e495ea9..3bd481622d 100644
--- a/application/Espo/Tools/Currency/Conversion/EntityConverter.php
+++ b/application/Espo/Tools/Currency/Conversion/EntityConverter.php
@@ -30,6 +30,7 @@
namespace Espo\Tools\Currency\Conversion;
use Espo\Core\Currency\Rates;
+use Espo\Core\Exceptions\BadRequest;
use Espo\Core\Exceptions\Forbidden;
use Espo\ORM\Entity;
@@ -43,6 +44,7 @@ interface EntityConverter
/**
* @param TEntity $entity
* @throws Forbidden
+ * @throws BadRequest
*/
public function convert(Entity $entity, string $targetCurrency, Rates $rates): void;
}