Skip to content

EspoCRM – Open Source CRM Application

Throw error if internal note and not allowed

Yurii4ecd2a954538
diff --git a/application/Espo/Classes/RecordHooks/Note/BeforeCreate.php b/application/Espo/Classes/RecordHooks/Note/BeforeCreate.php
index e54ab8c5d1..bb406857c9 100644
--- a/application/Espo/Classes/RecordHooks/Note/BeforeCreate.php
+++ b/application/Espo/Classes/RecordHooks/Note/BeforeCreate.php
@@ -71,6 +71,10 @@ class BeforeCreate implements SaveHook
!$entity->getParentType() ||
!$this->metadata->get("streamDefs.{$entity->getParentType()}.allowInternalNotes")
) {
+ if ($entity->isInternal()) {
+ throw new Forbidden("Internal note is not allowed.");
+ }
+
$entity->setIsInternal(false);
}
diff --git a/application/Espo/Hooks/Note/SetFields.php b/application/Espo/Hooks/Note/SetFields.php
new file mode 100644
index 0000000000..aca115cfa5
--- /dev/null
+++ b/application/Espo/Hooks/Note/SetFields.php
@@ -0,0 +1,60 @@
+<?php
+/************************************************************************
+ * This file is part of EspoCRM.
+ *
+ * EspoCRM – Open Source CRM application.
+ * Copyright (C) 2014-2026 EspoCRM, Inc.
+ * Website: https://www.espocrm.com
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
+ * The interactive user interfaces in modified source and object code versions
+ * of this program must display Appropriate Legal Notices, as required under
+ * Section 5 of the GNU Affero General Public License version 3.
+ *
+ * In accordance with Section 7(b) of the GNU Affero General Public License version 3,
+ * these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
+ ************************************************************************/
+
+namespace Espo\Hooks\Note;
+
+use Espo\Core\Hook\Hook\BeforeSave;
+use Espo\Core\Utils\Metadata;
+use Espo\Entities\Note;
+use Espo\ORM\Entity;
+use Espo\ORM\Repository\Option\SaveOptions;
+
+/**
+ * @implements BeforeSave<Note>
+ */
+class SetFields implements BeforeSave
+{
+ public function __construct(
+ private Metadata $metadata,
+ ) {}
+
+ public function beforeSave(Entity $entity, SaveOptions $options): void
+ {
+ if (
+ $entity->isNew() &&
+ (
+ !$entity->isPost() ||
+ !$entity->getParentType() ||
+ !$this->metadata->get("streamDefs.{$entity->getParentType()}.allowInternalNotes")
+ )
+ ) {
+ $entity->setIsInternal(false);
+ }
+ }
+}