EspoCRM – Open Source CRM Application
PHP calendarcontactscrmcrm-platformcrm-systemcustomer-portalcustomer-supportcustomizabledocumentsemail-marketingkanbanleadsopen-sourcephpplatformsales-automationsingle-page-applicationsupport
Backend field, link customizable check
Yurii5e2ce23f2c29
diff --git a/application/Espo/Controllers/EntityManager.php b/application/Espo/Controllers/EntityManager.phpindex 9cd5e3c522..01162fad89 100644--- a/application/Espo/Controllers/EntityManager.php+++ b/application/Espo/Controllers/EntityManager.php@@ -307,6 +307,7 @@ class EntityManager/*** @throws BadRequest* @throws Error+ * @throws Forbidden*/public function postActionUpdateLink(Request $request): bool{@@ -399,6 +400,7 @@ class EntityManager/*** @throws BadRequest* @throws Error+ * @throws Forbidden*/public function postActionRemoveLink(Request $request): bool{@@ -433,6 +435,7 @@ class EntityManager/*** @throws BadRequest* @throws Error+ * @throws Forbidden*/public function postActionUpdateLinkParams(Request $request): bool{diff --git a/application/Espo/Tools/FieldManager/FieldManager.php b/application/Espo/Tools/FieldManager/FieldManager.phpindex ec52540d28..3e9f2cc9eb 100644--- a/application/Espo/Tools/FieldManager/FieldManager.php+++ b/application/Espo/Tools/FieldManager/FieldManager.php@@ -225,6 +225,10 @@ class FieldManagerthrow new Error("Entity type $scope is not customizable.");}+ if (!$this->isCustomizable($scope, $name)) {+ throw new Error("Field '$name' is not customizable.");+ }+$isCustom = false;if (!empty($fieldDefs['isCustom'])) {@@ -935,4 +939,22 @@ class FieldManagerreturn true;}++ private function isCustomizable(string $scope, string $name): bool+ {+ if (!$this->isScopeCustomizable($scope)) {+ return false;+ }++ $defs = $this->metadata->get("entityDefs.$scope.fields.$name") ?? [];++ $utility = $defs['utility'] ?? false;+ $customizationDisabled = $defs['customizationDisabled'] ?? false;++ if ($utility || $customizationDisabled) {+ return false;+ }++ return true;+ }}diff --git a/application/Espo/Tools/LinkManager/LinkManager.php b/application/Espo/Tools/LinkManager/LinkManager.phpindex 0a1deed335..b03d70d292 100644--- a/application/Espo/Tools/LinkManager/LinkManager.php+++ b/application/Espo/Tools/LinkManager/LinkManager.php@@ -33,6 +33,7 @@ use Espo\Core\DataManager;use Espo\Core\Exceptions\BadRequest;use Espo\Core\Exceptions\Conflict;use Espo\Core\Exceptions\Error;+use Espo\Core\Exceptions\Forbidden;use Espo\Core\ORM\Type\FieldType;use Espo\Core\Utils\Language;use Espo\Core\Utils\Metadata;@@ -50,6 +51,7 @@ use Espo\Tools\LinkManager\Hook\HookProcessor as LinkHookProcessor;use Espo\Tools\LinkManager\Params as LinkParams;use Espo\Tools\LinkManager\Type as LinkType;use Espo\Tools\EntityManager\NameUtil;+use RuntimeException;/*** Administration > Entity Manager > {Entity Type} > Relationships.@@ -633,6 +635,7 @@ class LinkManager* } $params* @throws BadRequest* @throws Error+ * @throws Forbidden*/public function update(array $params): void{@@ -641,110 +644,105 @@ class LinkManager$entityForeign = $params['entityForeign'] ?? null;$linkForeign = $params['linkForeign'] ?? null;- if (empty($link)) {+ if (!$link || !$entity) {throw new BadRequest();}- if (empty($entity)) {- throw new BadRequest();+ if (!$this->isScopeCustomizable($entity)) {+ throw new Forbidden("Entity type '$entity' is not customizable.");+ }++ if ($entityForeign && !$this->isScopeCustomizable($entityForeign)) {+ throw new Forbidden("Entity type '$entityForeign' is not customizable.");}$linkType = $this->metadata->get("entityDefs.$entity.links.$link.type");$isCustom = $this->metadata->get("entityDefs.$entity.links.$link.isCustom");if ($linkType !== Entity::BELONGS_TO_PARENT) {- if (empty($entityForeign)) {+ if (!$entityForeign) {throw new BadRequest();}- if (empty($linkForeign)) {+ if (!$linkForeign) {throw new BadRequest();}}if (- $this->metadata->get("entityDefs.$entity.links.$link.type") == Entity::HAS_MANY &&- $this->metadata->get("entityDefs.$entity.links.$link.isCustom")+ $linkType === Entity::HAS_MANY &&+ $isCustom &&+ array_key_exists('linkMultipleField', $params)) {- if (array_key_exists('linkMultipleField', $params)) {- $this->updateLinkMultiple($params['linkMultipleField'], $entity, $link);- }+ $this->updateLinkMultiple($params['linkMultipleField'], $entity, $link);+ }++ $linkTypeForeign = null;+ $isCustomForeign = null;++ if ($entityForeign && $linkForeign) {+ $linkTypeForeign = $this->metadata->get("entityDefs.$entityForeign.links.$linkForeign.type");+ $isCustomForeign = $this->metadata->get("entityDefs.$entityForeign.links.$linkForeign.isCustom");}if (- $this->metadata->get("entityDefs.$entityForeign.links.$linkForeign.type") == Entity::HAS_MANY &&- $this->metadata->get("entityDefs.$entityForeign.links.$linkForeign.isCustom")+ $entityForeign &&+ $linkForeign &&+ $linkTypeForeign === Entity::HAS_MANY &&+ $isCustomForeign &&+ array_key_exists('linkMultipleFieldForeign', $params)) {- /** @var string $entityForeign */- /** @var string $linkForeign */-- if (array_key_exists('linkMultipleFieldForeign', $params)) {- $this->updateLinkMultiple($params['linkMultipleFieldForeign'], $entityForeign, $linkForeign);- }+ $this->updateLinkMultiple($params['linkMultipleFieldForeign'], $entityForeign, $linkForeign);}if (- in_array($this->metadata->get("entityDefs.$entity.links.$link.type"), [- Entity::HAS_MANY,- Entity::HAS_CHILDREN,- ])+ in_array($linkType, [Entity::HAS_MANY, Entity::HAS_CHILDREN]) &&+ array_key_exists('audited', $params)) {- if (array_key_exists('audited', $params)) {- $audited = $params['audited'];+ $audited = $params['audited'];- $dataLeft = [- 'links' => [- $link => [- "audited" => $audited,- ],+ $this->metadata->set('entityDefs', $entity, [+ 'links' => [+ $link => [+ "audited" => $audited,],- ];- $this->metadata->set('entityDefs', $entity, $dataLeft);- $this->metadata->save();- }+ ],+ ]);++ $this->metadata->save();}if (+ $entityForeign &&$linkForeign &&- in_array(- $this->metadata->get("entityDefs.$entityForeign.links.$linkForeign.type"),- [- Entity::HAS_MANY,- Entity::HAS_CHILDREN,- ]- )+ in_array($linkTypeForeign, [Entity::HAS_MANY, Entity::HAS_CHILDREN]) &&+ array_key_exists('auditedForeign', $params)) {- /** @var string $entityForeign */+ $auditedForeign = $params['auditedForeign'];- if (array_key_exists('auditedForeign', $params)) {- $auditedForeign = $params['auditedForeign'];-- $dataRight = [- 'links' => [- $linkForeign => [- "audited" => $auditedForeign,- ],+ $this->metadata->set('entityDefs', $entityForeign, [+ 'links' => [+ $linkForeign => [+ "audited" => $auditedForeign,],- ];+ ],+ ]);- $this->metadata->set('entityDefs', $entityForeign, $dataRight);- $this->metadata->save();- }+ $this->metadata->save();}if ($linkType === Entity::BELONGS_TO_PARENT) {$parentEntityTypeList = $params['parentEntityTypeList'] ?? null;if (is_array($parentEntityTypeList)) {- $data = [+ $this->metadata->set('entityDefs', $entity, ['fields' => [$link => ['entityList' => $parentEntityTypeList,],],- ];+ ]);- $this->metadata->set('entityDefs', $entity, $data);$this->metadata->save();}@@ -792,24 +790,21 @@ class LinkManager$this->language->save();- if ($isCustom) {- if ($this->language->getLanguage() !== $this->baseLanguage->getLanguage()) {-- if ($label) {- $this->baseLanguage->set($entity, 'fields', $link, $label);- $this->baseLanguage->set($entity, 'links', $link, $label);- }+ if ($isCustom && $this->language->getLanguage() !== $this->baseLanguage->getLanguage()) {+ if ($label) {+ $this->baseLanguage->set($entity, 'fields', $link, $label);+ $this->baseLanguage->set($entity, 'links', $link, $label);+ }- if ($labelForeign && $linkType !== Entity::BELONGS_TO_PARENT) {- /** @var string $linkForeign */- /** @var string $entityForeign */+ if ($labelForeign && $linkType !== Entity::BELONGS_TO_PARENT) {+ /** @var string $linkForeign */+ /** @var string $entityForeign */- $this->baseLanguage->set($entityForeign, 'fields', $linkForeign, $labelForeign);- $this->baseLanguage->set($entityForeign, 'links', $linkForeign, $labelForeign);- }-- $this->baseLanguage->save();+ $this->baseLanguage->set($entityForeign, 'fields', $linkForeign, $labelForeign);+ $this->baseLanguage->set($entityForeign, 'links', $linkForeign, $labelForeign);}++ $this->baseLanguage->save();}$this->dataManager->clearCache();@@ -822,24 +817,33 @@ class LinkManager* } $params* @throws Error* @throws BadRequest+ * @throws Forbidden*/public function delete(array $params): void{$entity = $params['entity'] ?? null;$link = $params['link'] ?? null;- if (!$this->metadata->get("entityDefs.$entity.links.$link.isCustom")) {- throw new Error("Could not delete link $entity.$link. Not isCustom.");+ if (!$entity || !$link) {+ throw new BadRequest();}- if (empty($entity) || empty($link)) {- throw new BadRequest();+ if (!$this->isScopeCustomizable($entity)) {+ throw new Forbidden("Entity type '$entity' is not customizable.");+ }++ if (!$this->metadata->get("entityDefs.$entity.links.$link.isCustom")) {+ throw new Error("Could not delete link $entity.$link. Not isCustom.");}$entityForeign = $this->metadata->get("entityDefs.$entity.links.$link.entity");$linkForeign = $this->metadata->get("entityDefs.$entity.links.$link.foreign");$linkType = $this->metadata->get("entityDefs.$entity.links.$link.type");+ if ($entityForeign && !$this->isScopeCustomizable($entityForeign)) {+ throw new Forbidden("Entity type '$entityForeign' is not customizable.");+ }+if (!$this->metadata->get(['entityDefs', $entity, 'links', $link, 'isCustom'])) {throw new Error("Can't remove not custom link.");}@@ -882,7 +886,7 @@ class LinkManagerreturn;}- if (empty($entityForeign) || empty($linkForeign)) {+ if (!$entityForeign || !$linkForeign) {throw new BadRequest();}@@ -1159,12 +1163,31 @@ class LinkManager/*** @param array{readOnly?: bool, cascadeRemoval?: bool} $params* @throws Error+ * @throws Forbidden*/public function updateParams(string $entityType, string $link, array $params): void{- $type = $this->metadata->get("entityDefs.$entityType.links.$link.type");- $foreignEntityType = $this->metadata->get("entityDefs.$entityType.links.$link.entity");- $foreign = $this->metadata->get("entityDefs.$entityType.links.$link.foreign");+ if (!$this->isLinkCustomizable($entityType, $link)) {+ throw new Forbidden("Link '$link' is not customizable.");+ }++ /**+ * @type array{+ * type?: string,+ * entity?: string|null,+ * foreign?: string|null,+ * } $linkDefs+ */+ $linkDefs = $this->metadata->get("entityDefs.$entityType.links.$link") ?? [];++ $type = $linkDefs['type'] ?? null;+ $foreignEntityType = $linkDefs['entity'] ?? null;+ $foreign = $linkDefs['foreign'] ?? null;++ if (!$type) {+ throw new RuntimeException("No type.");+ }+$foreignType = null;$isObject = false;$isSystem = false;@@ -1261,4 +1284,28 @@ class LinkManager);}}++ private function isLinkCustomizable(string $entityType, string $link): bool+ {+ if (!$this->isScopeCustomizable($entityType)) {+ return false;+ }++ /**+ * @type array{+ * utility?: bool|null,+ * customizationDisabled?: bool|null,+ * } $linkDefs+ */+ $linkDefs = $this->metadata->get("entityDefs.$entityType.links.$link") ?? [];++ if (+ ($linkDefs['utility'] ?? false) ||+ ($linkDefs['customizationDisabled'] ?? false)+ ) {+ return false;+ }++ return true;+ }}diff --git a/client/src/views/admin/link-manager/index.js b/client/src/views/admin/link-manager/index.jsindex 47dea6203c..cf96b68923 100644--- a/client/src/views/admin/link-manager/index.js+++ b/client/src/views/admin/link-manager/index.js@@ -151,7 +151,7 @@ class LinkManagerIndexView extends View {let type;- let isEditable = this.isCustomizable;+ let isEditable = this.isCustomizable && !defs.utility;if (defs.type === 'belongsToParent') {type = 'childrenToParent';@@ -180,8 +180,10 @@ class LinkManagerIndexView extends View {const isRemovable = defs.isCustom;- const hasEditParams = ['hasChildren', 'hasMany'].includes(defs.type) ||- ['oneToOneLeft', 'oneToOneRight', 'oneToMany'].includes(type);+ const hasEditParams = (+ ['hasChildren', 'hasMany'].includes(defs.type) ||+ ['oneToOneLeft', 'oneToOneRight', 'oneToMany'].includes(type)+ ) && this.isCustomizable && !defs.utility;this.linkDataList.push({link: link,diff --git a/schema/metadata/entityDefs.json b/schema/metadata/entityDefs.jsonindex 98a2dd1caf..123235de85 100644--- a/schema/metadata/entityDefs.json+++ b/schema/metadata/entityDefs.json@@ -1518,6 +1518,10 @@"type": "boolean","description": "The link will be hidden from the user on the UI but not disabled."},+ "customizationDisabled": {+ "type": "boolean",+ "description": "Disables the ability to customize the link. As of v10.0.8."+ },"disabled": {"type": "boolean","description": "Disables the link."