Skip to content

EspoCRM – Open Source CRM Application

Main page escaping fix

Yuriice73338ea7b4
diff --git a/application/Espo/Core/Utils/ClientManager.php b/application/Espo/Core/Utils/ClientManager.php
index c82981e28b..c52a53a5e3 100644
--- a/application/Espo/Core/Utils/ClientManager.php
+++ b/application/Espo/Core/Utils/ClientManager.php
@@ -47,6 +47,8 @@ use Slim\ResponseEmitter;
/**
* Renders the main HTML page.
+ *
+ * @todo Use Handlebars.
*/
class ClientManager
{
@@ -249,7 +251,7 @@ class ClientManager
$data = [
'applicationId' => $this->applicationId,
'apiUrl' => $this->apiUrl,
- 'applicationName' => $pageTitle ?? $this->config->get('applicationName', 'EspoCRM'),
+ 'applicationName' => $this->escapeValue($pageTitle ?? $this->config->get('applicationName', 'EspoCRM')),
'cacheTimestamp' => $cacheTimestamp,
'appTimestamp' => $appTimestamp,
'loaderCacheTimestamp' => Json::encode($loaderCacheTimestamp),
@@ -265,10 +267,11 @@ class ClientManager
'faviconAlternate' => $faviconAlternate,
'favicon' => $favicon,
'faviconType' => $faviconType,
- 'ajaxTimeout' => $this->config->get('ajaxTimeout') ?? 60000,
+ 'ajaxTimeout' => (int) ($this->config->get('ajaxTimeout') ?? 60000),
'internalModuleList' => Json::encode($internalModuleList),
'bundledModuleList' => Json::encode($this->getBundledModuleList()),
- 'applicationDescription' => $this->config->get('applicationDescription') ?? self::APP_DESCRIPTION,
+ 'applicationDescription' =>
+ $this->escapeValue($this->config->get('applicationDescription') ?? self::APP_DESCRIPTION),
'nonce' => $this->nonce,
'loaderParams' => Json::encode([
'basePath' => $this->basePath,
@@ -488,4 +491,11 @@ class ClientManager
return [$faviconSvgPath, $faviconType];
}
+
+ private function escapeValue(string $value): string
+ {
+ $value = htmlspecialchars($value, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8');
+
+ return str_replace(['{', '}'], ['{', '}'], $value);
+ }
}