Skip to content

EspoCRM – Open Source CRM Application

Refactor and test

Yuriidb51353470c5
diff --git a/application/Espo/Core/Api/Auth.php b/application/Espo/Core/Api/Auth.php
index 0c11c44be2..6458d8a7c1 100644
--- a/application/Espo/Core/Api/Auth.php
+++ b/application/Espo/Core/Api/Auth.php
@@ -137,7 +137,7 @@ class Auth
return AuthResult::createNotResolved();
}
- if (!$result->isFail()) {
+ if ($result->isSuccess()) {
return AuthResult::createResolved();
}
diff --git a/tests/unit/Espo/Core/Api/AuthTest.php b/tests/unit/Espo/Core/Api/AuthTest.php
new file mode 100644
index 0000000000..9bde0116e6
--- /dev/null
+++ b/tests/unit/Espo/Core/Api/AuthTest.php
@@ -0,0 +1,155 @@
+<?php
+/************************************************************************
+ * This file is part of EspoCRM.
+ *
+ * EspoCRM – Open Source CRM application.
+ * Copyright (C) 2014-2026 EspoCRM, Inc.
+ * Website: https://www.espocrm.com
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
+ * The interactive user interfaces in modified source and object code versions
+ * of this program must display Appropriate Legal Notices, as required under
+ * Section 5 of the GNU Affero General Public License version 3.
+ *
+ * In accordance with Section 7(b) of the GNU Affero General Public License version 3,
+ * these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
+ ************************************************************************/
+
+namespace tests\unit\Espo\Core\Api;
+
+use Espo\Core\Api\Auth;
+use Espo\Core\Api\RequestWrapper;
+use Espo\Core\Api\Response;
+use Espo\Core\Authentication\Authentication;
+use Espo\Core\Authentication\ConfigDataProvider;
+use Espo\Core\Authentication\HeaderKey;
+use Espo\Core\Authentication\Result;
+use Espo\Core\Authentication\Result\Data;
+use Espo\Core\Utils\Json;
+use Espo\Core\Utils\Log;
+use Espo\Entities\User;
+use PHPUnit\Framework\TestCase;
+use Slim\Psr7\Factory\RequestFactory;
+use Slim\Psr7\Factory\StreamFactory;
+
+class AuthTest extends TestCase
+{
+ /**
+ * @noinspection PhpUnhandledExceptionInspection
+ */
+ public function testProcessNoAuth(): void
+ {
+ $request = $this->createRequestInstance();
+
+ $response = $this->createMock(Response::class);
+
+ $authentication = $this->createMock(Authentication::class);
+ $authentication
+ ->expects(self::once())
+ ->method('login')
+ ->willReturn(
+ Result::secondStepRequired($this->createMock(User::class), Data::create())
+ );
+
+ $configDataProvider = $this->createConfigDataProvider();
+
+ $auth = new Auth(
+ log: $this->createMock(Log::class),
+ authentication: $authentication,
+ configDataProvider: $configDataProvider,
+ authRequired: false,
+ );
+
+ $result = $auth->process($request, $response);
+
+ $this->assertTrue($result->isResolvedUseNoAuth());
+ }
+
+ /**
+ * @noinspection PhpUnhandledExceptionInspection
+ */
+ public function testProcessAuthFail(): void
+ {
+ $request = $this->createRequestInstance();
+
+ $response = $this->createMock(Response::class);
+
+ $authentication = $this->createMock(Authentication::class);
+ $authentication
+ ->expects(self::once())
+ ->method('login')
+ ->willReturn(
+ Result::fail()
+ );
+
+ $configDataProvider = $this->createConfigDataProvider();
+
+ $auth = new Auth(
+ log: $this->createMock(Log::class),
+ authentication: $authentication,
+ configDataProvider: $configDataProvider,
+ );
+
+ $result = $auth->process($request, $response);
+
+ $this->assertFalse($result->isResolved());
+ $this->assertFalse($result->isResolvedUseNoAuth());
+ }
+
+ private function createRequest(
+ string $method,
+ array $queryParams = [],
+ array $headers = [],
+ ?string $body = null,
+ ): RequestWrapper {
+
+ $request = (new RequestFactory())
+ ->createRequest($method, 'http://localhost/?' . http_build_query($queryParams));
+
+ foreach ($headers as $name => $value) {
+ $request = $request->withHeader($name, $value);
+ }
+
+ if ($body) {
+ $request = $request->withBody(
+ (new StreamFactory)->createStream($body)
+ );
+ }
+
+ return new RequestWrapper($request, '', []);
+ }
+
+ private function createRequestInstance(): RequestWrapper
+ {
+ return $this->createRequest(
+ method: 'POST',
+ headers: [
+ 'Content-Type' => 'application/json',
+ HeaderKey::AUTHORIZATION => base64_encode('test:1'),
+ ],
+ body: Json::encode((object) []),
+ );
+ }
+
+ private function createConfigDataProvider(): ConfigDataProvider
+ {
+ $configDataProvider = $this->createMock(ConfigDataProvider::class);
+ $configDataProvider
+ ->method('getLoginMetadataParamsList')
+ ->willReturn([]);
+
+ return $configDataProvider;
+ }
+}