Skip to content

EspoCRM – Open Source CRM Application

Buttons change state optimization

Yuriieb22a5e4b4fb
diff --git a/client/src/views/modal.ts b/client/src/views/modal.ts
index ad8d00714e..0ad0f409b4 100644
--- a/client/src/views/modal.ts
+++ b/client/src/views/modal.ts
@@ -647,14 +647,22 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
* @param name A button name.
*/
async disableButton(name: string) {
+ let changed = false;
+
this.buttonList.forEach(item => {
if (item.name !== name) {
return;
}
+ changed ||= !item.disabled;
+
item.disabled = true;
});
+ if (!changed) {
+ return;
+ }
+
if (!this.isRendered()) {
return;
}
@@ -668,14 +676,22 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
* @param name A button name.
*/
async enableButton(name: string) {
+ let changed: any = false;
+
this.buttonList.forEach(item => {
if (item.name !== name) {
return;
}
+ changed ||= item.disabled;
+
item.disabled = false;
});
+ if (!changed) {
+ return;
+ }
+
if (!this.isRendered()) {
return;
}
@@ -877,8 +893,12 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
* @param name A name.
*/
async showActionItem(name: string) {
+ let changed: any = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
@@ -887,12 +907,18 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
for (const item of this.dropdownItemList) {
if (item && item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
}
}
+ if (!changed) {
+ return;
+ }
+
if (!this.isRendered()) {
return;
}
@@ -929,8 +955,12 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
* @param name A name.
*/
async hideActionItem(name: string) {
+ let changed = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= !item.hidden;
+
item.hidden = true;
break;
@@ -939,12 +969,18 @@ class ModalView<S extends ViewSchema = ViewSchema> extends View<S> {
for (const item of this.dropdownItemList) {
if (item && item.name === name) {
+ changed ||= !item.hidden;
+
item.hidden = true;
break;
}
}
+ if (changed) {
+ return;
+ }
+
if (!this.isRendered()) {
return;
}
diff --git a/client/src/views/record/detail.ts b/client/src/views/record/detail.ts
index b2eb905fa9..d342a28e5e 100644
--- a/client/src/views/record/detail.ts
+++ b/client/src/views/record/detail.ts
@@ -1089,8 +1089,12 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
* @param name A name.
*/
hideActionItem(name: string) {
+ let changed = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= !item.hidden;
+
item.hidden = true;
break;
@@ -1099,6 +1103,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownItemList) {
if (item.name === name) {
+ changed ||= !item.hidden
+
item.hidden = true;
break;
@@ -1107,6 +1113,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownEditItemList) {
if (item.name === name) {
+ changed ||= !item.hidden
+
item.hidden = true;
break;
@@ -1115,12 +1123,18 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.buttonEditList) {
if (item.name === name) {
+ changed ||= !item.hidden
+
item.hidden = true;
break;
}
}
+ if (!changed) {
+ return;
+ }
+
if (this.isRendered()) {
this.reRenderButtons();
}
@@ -1132,8 +1146,12 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
* @param name A name.
*/
showActionItem(name: string) {
+ let changed: any = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
@@ -1142,6 +1160,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownItemList) {
if (item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
@@ -1150,6 +1170,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownEditItemList) {
if (item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
@@ -1158,12 +1180,18 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.buttonEditList) {
if (item.name === name) {
+ changed ||= item.hidden;
+
item.hidden = false;
break;
}
}
+ if (!changed) {
+ return;
+ }
+
if (this.isRendered()) {
this.reRenderButtons();
}
@@ -1176,8 +1204,12 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
* @param name A name.
*/
disableActionItem(name: string) {
+ let changed = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= !item.disabled;
+
item.disabled = true;
break;
@@ -1186,6 +1218,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownItemList) {
if (item.name === name) {
+ changed ||= !item.disabled;
+
item.disabled = true;
break;
@@ -1194,6 +1228,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownEditItemList) {
if (item.name === name) {
+ changed ||= !item.disabled;
+
item.disabled = true;
break;
@@ -1202,12 +1238,18 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.buttonEditList) {
if (item.name === name) {
+ changed ||= !item.disabled;
+
item.disabled = true;
break;
}
}
+ if (!changed) {
+ return false;
+ }
+
if (this.isRendered()) {
this.reRenderButtons();
}
@@ -1220,8 +1262,12 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
* @param name A name.
*/
enableActionItem(name: string) {
+ let changed: any = false;
+
for (const item of this.buttonList) {
if (item.name === name) {
+ changed ||= item.disabled;
+
item.disabled = false;
break;
@@ -1230,6 +1276,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownItemList) {
if (item.name === name) {
+ changed ||= item.disabled;
+
item.disabled = false;
break;
@@ -1238,6 +1286,8 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.dropdownEditItemList) {
if (item.name === name) {
+ changed ||= item.disabled;
+
item.disabled = false;
break;
@@ -1246,12 +1296,18 @@ class DetailRecordView<S extends DetailRecordViewSchema = DetailRecordViewSchema
for (const item of this.buttonEditList) {
if (item.name === name) {
+ changed ||= item.disabled;
+
item.disabled = false;
break;
}
}
+ if (!changed) {
+ return false;
+ }
+
if (this.isRendered()) {
this.reRenderButtons();
}