Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(gates): a fractional offset is not a spacing step

esengine2251607f9fde
diff --git a/desktop b/desktop
index 2b67403e9..565834ce2 160000
--- a/desktop
+++ b/desktop
@@ -1 +1 @@
-Subproject commit 2b67403e94eaa02590f1a856fe775d657fcb9ea7
+Subproject commit 565834ce25cf602dda97fdf646c258a6ae4890cf
diff --git a/tools/baselines/theme-drift.json b/tools/baselines/theme-drift.json
index 00dd66508..380c21259 100644
--- a/tools/baselines/theme-drift.json
+++ b/tools/baselines/theme-drift.json
@@ -1,31 +1,30 @@
{
"spacing": {
- "agent.css": 96,
- "app.css": 14,
- "chrome.css": 6,
- "content.css": 31,
- "controllers.css": 14,
- "controls.css": 10,
+ "agent.css": 82,
+ "app.css": 12,
+ "chrome.css": 5,
+ "content.css": 25,
+ "controllers.css": 9,
+ "controls.css": 7,
"dockview-theme.css": 1,
- "events.css": 9,
- "flipbook.css": 9,
- "health.css": 3,
- "history.css": 7,
- "inspector.css": 64,
+ "events.css": 4,
+ "flipbook.css": 3,
+ "history.css": 6,
+ "inspector.css": 45,
"launcher.css": 4,
- "lighting.css": 6,
- "menus.css": 33,
+ "lighting.css": 4,
+ "menus.css": 21,
"nodegraph.css": 10,
- "outliner.css": 4,
- "plugins.css": 12,
+ "outliner.css": 2,
+ "plugins.css": 8,
"profiler.css": 14,
- "sequencer.css": 8,
- "settings.css": 13,
- "tilemap.css": 15,
- "tileset.css": 22,
- "transport.css": 2,
- "viewport.css": 13,
- "world.css": 4
+ "sequencer.css": 6,
+ "settings.css": 9,
+ "tilemap.css": 10,
+ "tileset.css": 17,
+ "transport.css": 1,
+ "viewport.css": 11,
+ "world.css": 3
},
"colourLiterals": {
"app.css": 26,
diff --git a/tools/check-theme.mjs b/tools/check-theme.mjs
index 958f4b21d..a1482c717 100644
--- a/tools/check-theme.mjs
+++ b/tools/check-theme.mjs
@@ -212,7 +212,9 @@ const offGridByFile = () => {
const text = readFileSync(path.join(THEME_DIR, f), 'utf8');
let n = 0;
for (const m of text.matchAll(/(?:gap|padding|margin)[a-z-]*:\s*([^;}]+)/g)) {
- for (const px of m[1].matchAll(/(\d+)px/g)) {
+ // A fractional value is centring arithmetic (-4.5px on a 9px dot), not a
+ // spacing step, and read as `5px` it was counted as one.
+ for (const px of m[1].matchAll(/(?<![\d.])(\d+)px/g)) {
const v = Number(px[1]);
if (v !== 0 && v % GRID !== 0) n++;
}