Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

perf: cache QueryInstance in SystemRunner to eliminate per-run allocations

esengine28bdf4158c88
diff --git a/sdk/src/query.ts b/sdk/src/query.ts
index 1972039b0..39091ac70 100644
--- a/sdk/src/query.ts
+++ b/sdk/src/query.ts
@@ -167,7 +167,7 @@ export class QueryInstance<C extends readonly QueryArg[]> implements Iterable<Qu
private readonly result_: unknown[];
private readonly mutData_: Array<{ component: AnyComponentDef; data: Record<string, unknown> }>;
private readonly cacheKey_: string;
- private readonly lastRunTick_: number;
+ private lastRunTick_: number;
private readonly getters_: Array<((entity: Entity) => unknown) | null>;
private readonly mutSetters_: Array<((entity: Entity, data: unknown) => void) | null>;
private readonly mutIsBuiltin_: boolean[];
@@ -203,6 +203,11 @@ export class QueryInstance<C extends readonly QueryArg[]> implements Iterable<Qu
}
}
+ /** @internal Update lastRunTick for reuse across system runs */
+ resetTick(tick: number): void {
+ this.lastRunTick_ = tick;
+ }
+
private passesChangeFilters_(entity: Entity): boolean {
const { _addedFilters, _changedFilters } = this.descriptor_;
if (_addedFilters.length === 0 && _changedFilters.length === 0) return true;
@@ -427,7 +432,7 @@ export function Removed<T extends AnyComponentDef>(component: T): RemovedQueryDe
export class RemovedQueryInstance<T extends AnyComponentDef> implements Iterable<Entity> {
private readonly world_: World;
private readonly component_: T;
- private readonly lastRunTick_: number;
+ private lastRunTick_: number;
constructor(world: World, component: T, lastRunTick: number) {
this.world_ = world;
@@ -436,6 +441,11 @@ export class RemovedQueryInstance<T extends AnyComponentDef> implements Iterable
world.enableChangeTracking(component);
}
+ /** @internal Update lastRunTick for reuse across system runs */
+ resetTick(tick: number): void {
+ this.lastRunTick_ = tick;
+ }
+
*[Symbol.iterator](): Iterator<Entity> {
yield* this.world_.getRemovedEntitiesSince(this.component_, this.lastRunTick_);
}
diff --git a/sdk/src/system.ts b/sdk/src/system.ts
index f121d4e1e..3f8c15fcb 100644
--- a/sdk/src/system.ts
+++ b/sdk/src/system.ts
@@ -142,6 +142,8 @@ export class SystemRunner {
private readonly eventRegistry_: EventRegistry | null;
private readonly argsCache_ = new Map<symbol, unknown[]>();
private readonly systemTicks_ = new Map<symbol, number>();
+ private readonly queryCache_ = new Map<symbol, QueryInstance<any>[]>();
+ private readonly removedCache_ = new Map<symbol, RemovedQueryInstance<any>[]>();
private currentLastRunTick_ = -1;
private timings_: Map<string, number> | null = null;
@@ -168,8 +170,46 @@ export class SystemRunner {
this.currentLastRunTick_ = this.systemTicks_.get(system._id) ?? -1;
+ let queries = this.queryCache_.get(system._id);
+ let removeds = this.removedCache_.get(system._id);
+ const firstRun = !queries;
+
+ if (firstRun) {
+ queries = [];
+ removeds = [];
+ this.queryCache_.set(system._id, queries);
+ this.removedCache_.set(system._id, removeds);
+ }
+
+ let qi = 0, ri = 0;
for (let i = 0; i < system._params.length; i++) {
- args[i] = this.resolveParam(system._params[i]);
+ const param = system._params[i];
+ if (param._type === 'query') {
+ if (firstRun) {
+ const inst = new QueryInstance(this.world_, param, this.currentLastRunTick_);
+ queries!.push(inst);
+ args[i] = inst;
+ } else {
+ const inst = queries![qi];
+ inst.resetTick(this.currentLastRunTick_);
+ args[i] = inst;
+ }
+ qi++;
+ } else if (param._type === 'removed') {
+ if (firstRun) {
+ const desc = param as RemovedQueryDescriptor<AnyComponentDef>;
+ const inst = new RemovedQueryInstance(this.world_, desc._component, this.currentLastRunTick_);
+ removeds!.push(inst);
+ args[i] = inst;
+ } else {
+ const inst = removeds![ri];
+ inst.resetTick(this.currentLastRunTick_);
+ args[i] = inst;
+ }
+ ri++;
+ } else {
+ args[i] = this.resolveParam(param);
+ }
}
const t0 = this.timings_ ? performance.now() : 0;
@@ -192,9 +232,6 @@ export class SystemRunner {
private resolveParam(param: SystemParam): unknown {
switch (param._type) {
- case 'query':
- return new QueryInstance(this.world_, param, this.currentLastRunTick_);
-
case 'res':
return this.resources_.get(param._resource);
@@ -220,11 +257,6 @@ export class SystemRunner {
return new EventReaderInstance(bus);
}
- case 'removed': {
- const desc = param as RemovedQueryDescriptor<AnyComponentDef>;
- return new RemovedQueryInstance(this.world_, desc._component, this.currentLastRunTick_);
- }
-
case 'get_world':
return this.world_;