Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(cocos): a converted effect declares the tangent varying it reads again: without it every effect failed its glslang check (294 not converted in the Cocos client) and its materials came out empty

yhh2eccc4126dce
diff --git a/pipeline/src/import/cocos/effectConvert.ts b/pipeline/src/import/cocos/effectConvert.ts
index 40a827900..3bd7c5218 100644
--- a/pipeline/src/import/cocos/effectConvert.ts
+++ b/pipeline/src/import/cocos/effectConvert.ts
@@ -268,6 +268,7 @@ in highp vec2 v_texCoord1;
#endif`;
const TANGENT_VARYING = `#ifdef MESH_TANGENTS
+in highp vec4 v_worldTangent;
#define cocos_tangent v_worldTangent
#else
#define cocos_tangent vec4(1.0, 0.0, 0.0, 1.0)