Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

ci: the engine's jobs stop trying to clone the private editor

esengine36608536bb74
diff --git a/.github/actions/engine-submodules/action.yml b/.github/actions/engine-submodules/action.yml
new file mode 100644
index 000000000..ca83d48b2
--- /dev/null
+++ b/.github/actions/engine-submodules/action.yml
@@ -0,0 +1,22 @@
+name: Check out the engine's submodules
+description: Initialise every submodule except the private editor.
+
+# `submodules: recursive` on checkout tries to clone ALL of them, and the editor
+# is private — so a job that only wants third_party's vendored sources fails at
+# checkout with "repository not found". These jobs do not want the editor at all.
+#
+# Derived from .gitmodules rather than listed here: a new vendored dependency
+# would otherwise be silently left uninitialised by every job using this.
+
+runs:
+ using: composite
+ steps:
+ - name: Init the engine submodules
+ shell: bash
+ run: |
+ set -euo pipefail
+ paths=$(git config -f .gitmodules --get-regexp '^submodule\..*\.path$' \
+ | awk '{print $2}' | grep -vx 'desktop')
+ echo "initialising: $(echo "$paths" | tr '\n' ' ')"
+ # shellcheck disable=SC2086
+ git submodule update --init --recursive $paths
diff --git a/.github/workflows/android-canary-apk.yml b/.github/workflows/android-canary-apk.yml
index ae42c395c..5864947c1 100644
--- a/.github/workflows/android-canary-apk.yml
+++ b/.github/workflows/android-canary-apk.yml
@@ -50,9 +50,8 @@ jobs:
# carries its libraries already. Fetched unconditionally because a
# conditional checkout is a second way for the two paths to diverge.
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
# The SDK bundle is compiled INTO the host binary, so a template built here
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 37460a7bb..a0cc84498 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -40,9 +40,8 @@ jobs:
steps:
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
- name: Setup Emscripten
@@ -108,9 +107,8 @@ jobs:
steps:
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- name: Setup Emscripten
uses: mymindstorm/setup-emsdk@v16
with:
@@ -459,9 +457,8 @@ jobs:
steps:
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
# The SDK bundle is compiled into the host binary.
diff --git a/.github/workflows/native-smoke.yml b/.github/workflows/native-smoke.yml
index 900ebd336..d10109962 100644
--- a/.github/workflows/native-smoke.yml
+++ b/.github/workflows/native-smoke.yml
@@ -92,9 +92,8 @@ jobs:
steps:
# With submodules: the host links box2d, spine and glm from third_party.
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
# The SDK bundle is compiled INTO the host binary, which is why a template
diff --git a/.github/workflows/release-desktop.yml b/.github/workflows/release-desktop.yml
index 9628394bc..820796747 100644
--- a/.github/workflows/release-desktop.yml
+++ b/.github/workflows/release-desktop.yml
@@ -86,9 +86,8 @@ jobs:
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
- name: Setup Emscripten
@@ -146,9 +145,8 @@ jobs:
# a checkout without them fails at configure with a directory that has no
# CMakeLists.txt — which is exactly how this job failed the first time it ran.
- uses: actions/checkout@v7
- with:
- submodules: recursive
+ - uses: ./.github/actions/engine-submodules
- uses: ./.github/actions/setup
# The SDK bundle is compiled INTO the host binary, which is why a template