Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(ci): the wechat runtime was built every run and carried by nothing

esengine369ad6a6fd14
diff --git a/.github/actions/editor-host/action.yml b/.github/actions/editor-host/action.yml
index 11551c9d0..0b5145694 100644
--- a/.github/actions/editor-host/action.yml
+++ b/.github/actions/editor-host/action.yml
@@ -13,6 +13,14 @@ runs:
name: wasm-web
path: build/wasm/web/
+ # The editor packages for every platform it offers, and wechat's runtime is a
+ # separate build target with its own output tree.
+ - name: Download wechat wasm artifact
+ uses: actions/download-artifact@v8
+ with:
+ name: wasm-wechat
+ path: build/wasm/wechat/
+
- name: Build SDK
shell: bash
run: pnpm --filter ./sdk build
@@ -20,8 +28,9 @@ runs:
- name: Stage wasm for the editor host
shell: bash
run: |
- mkdir -p desktop/public/wasm
+ mkdir -p desktop/public/wasm desktop/public/wasm-wechat
cp build/wasm/web/* desktop/public/wasm/
+ cp build/wasm/wechat/* desktop/public/wasm-wechat/
- name: Build editor renderer bundle
shell: bash
diff --git a/.github/actions/native-template/action.yml b/.github/actions/native-template/action.yml
index 0e9443e38..01839031c 100644
--- a/.github/actions/native-template/action.yml
+++ b/.github/actions/native-template/action.yml
@@ -38,14 +38,18 @@ runs:
TAG=$(gh release view --repo "$GITHUB_REPOSITORY" --json tagName -q .tagName)
echo "no tag given — taking the $PLATFORM template from $TAG"
fi
+ # NOT `templates/`, which the checkout already uses for the eight project
+ # starters: downloading into it works only while nothing else there is a
+ # zip, and `unzip templates/*.zip` would then take whichever came first.
+ rm -rf .native-template-dl
gh release download "$TAG" --repo "$GITHUB_REPOSITORY" \
- -p "estella-native-$PLATFORM-*.zip" -D templates
+ -p "estella-native-$PLATFORM-*.zip" -D .native-template-dl
# Under release strictness, so nothing is packaged around an archive the
# publish gate would reject anyway.
- node build-tools/cli.js verify-template templates/*.zip
- mkdir -p template
- unzip -q templates/*.zip -d template
+ node build-tools/cli.js verify-template .native-template-dl/*.zip
+ rm -rf template && mkdir -p template
+ unzip -q .native-template-dl/*.zip -d template
# `mkdir -p` already made the directory, so its existence proves nothing;
# what the next step needs is that the archive put something in it.
[ -n "$(ls -A template)" ] || { echo "::error::$PLATFORM template unpacked to nothing"; exit 1; }
- echo "unpacked $(ls templates) into template/ ($(ls -A template | wc -l) entries)"
+ echo "unpacked $(ls .native-template-dl) into template/ ($(ls -A template | wc -l) entries)"
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 09c021024..d003a778c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -97,6 +97,16 @@ jobs:
path: build/wasm/web/
retention-days: 3
+ # `-t all` builds this and nothing carried it, so every wechat package after
+ # it said "wechat engine runtime not found" — a whole platform's packaging
+ # answered by an artifact that was built and dropped.
+ - name: Upload wechat wasm artifact
+ uses: actions/upload-artifact@v7
+ with:
+ name: wasm-wechat
+ path: build/wasm/wechat/
+ retention-days: 3
+
# The same harnesses, instrumented. An out-of-bounds read that lands in
# allocation slack (or in the next allocation) is silent in the plain build and
# is exactly what these gates cannot otherwise see. Findings are fatal —
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index e88eca2f3..574e90dc8 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -61,13 +61,26 @@ jobs:
path: build/wasm/web/
retention-days: 3
+ # `-t all` builds this and nothing carried it, so every wechat package after
+ # it said "wechat engine runtime not found" — a whole platform's packaging
+ # answered by an artifact that was built and dropped.
+ - name: Upload wechat wasm artifact
+ uses: actions/upload-artifact@v7
+ with:
+ name: wasm-wechat
+ path: build/wasm/wechat/
+ retention-days: 3
+
# 27 of the 31. The runner names the four it cannot answer from here and the
# four nobody can automate, so a green job is never read as a green release.
linux:
name: Exit criteria (linux)
runs-on: ubuntu-latest
needs: build-emscripten
- timeout-minutes: 90
+ # 90 was measured against criteria that failed in seconds. Answering them
+ # costs what the work costs: golden alone is 32 minutes, and the run that
+ # first got this far was cut at 90 with the flagship still going.
+ timeout-minutes: 150
steps:
# verify-legacy reads examples out of RELEASE TAGS (git archive v0.20.0 …),