Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

test(smoke): recreate the activity on purpose, since the OS does it by surprise

esengine3d1cb5c5b114
diff --git a/.github/workflows/native-smoke.yml b/.github/workflows/native-smoke.yml
index 5d28308c2..a1d590a1f 100644
--- a/.github/workflows/native-smoke.yml
+++ b/.github/workflows/native-smoke.yml
@@ -132,9 +132,14 @@ jobs:
# until its launcher stops responding, which is noise this has already
# had to filter once.
emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none -camera-front none -memory 4096 -cores 2
+ # --recreate only when the template is this run's own build: the probe
+ # requires the stack-anchor fix (jsEntry), and pointing it at an older
+ # release's template would red the run on a bug that release is known
+ # to carry.
script: >-
node tools/verify-native-boot.mjs --platform android --examples all
--shard ${{ matrix.shard }}/3
+ ${{ steps.src.outputs.tag == '' && '--recreate' || '' }}
${{ inputs.examples && format('--only {0}', inputs.examples) || '' }}
- name: Keep the frames and the records
diff --git a/tools/verify-native-boot.mjs b/tools/verify-native-boot.mjs
index 12a6c7a0f..97a636157 100644
--- a/tools/verify-native-boot.mjs
+++ b/tools/verify-native-boot.mjs
@@ -102,6 +102,7 @@ function parseArgs(argv) {
const key = argv[i].replace(/^--/, '');
if (key === 'allow-skip') { opts.allowSkip = true; continue; }
if (key === 'no-frame-judge') { opts.frameJudge = false; continue; }
+ if (key === 'recreate') { opts.recreate = true; continue; }
opts[key.replace(/-([a-z])/g, (_, c) => c.toUpperCase())] = argv[++i];
}
opts.timeout = Number(opts.timeout);
@@ -236,6 +237,15 @@ function androidDriver(opts) {
clearScreen() {
trySh(adb, ['shell', 'am', 'broadcast', '-a', 'android.intent.action.CLOSE_SYSTEM_DIALOGS']);
},
+ // A uiMode change the manifest does not handle, so the platform recreates
+ // the activity: the process and the booted engine survive, every later JS
+ // call runs on a NEW glue thread. That thread swap is what broke three
+ // releases' smoke runs intermittently (QuickJS's stack-overflow anchor),
+ // and ASLR decides whether a given recreate trips it — hence a probe that
+ // recreates several times rather than once.
+ recreate(night) {
+ trySh(adb, ['shell', 'cmd', 'uimode', 'night', night ? 'yes' : 'no']);
+ },
readLog() {
const got = trySh(adb, ['shell', 'cat', logFile]);
// Why it failed, kept for the diagnostics. "No such file" (the app never
@@ -517,6 +527,29 @@ async function verifyApp(driver, artifact, label, opts, judgeFrame = true) {
// Before stop(): a dead process has no memory, no threads and no layer.
const metrics = driver.metrics ? await driver.metrics(launchOutput) : null;
+
+ // The recreate probe, after the frame is already banked so it cannot disturb
+ // the pixel question. Each uiMode toggle recreates the activity over the
+ // LIVING engine; the errors that only this path produces (a JS runtime
+ // entered from a fresh thread) land in the boot record, and the diff below
+ // attributes them to the recreate rather than to the boot.
+ let recreateWhy = '';
+ let bootErrorCount = null;
+ if (opts.recreate && driver.recreate && !offScreen && log.includes(READY)) {
+ const errorsBefore = log.split('\n').filter((l) => l.startsWith('ERROR [')).length;
+ bootErrorCount = errorsBefore;
+ for (let i = 0; i < 3; i++) {
+ driver.recreate(true); await sleep(2000);
+ driver.recreate(false); await sleep(2000);
+ }
+ const after = driver.readLog();
+ if (after) log = after;
+ const fresh = log.split('\n').filter((l) => l.startsWith('ERROR [')).slice(errorsBefore);
+ const gone = driver.foreground();
+ if (fresh.length) recreateWhy = `after an activity recreate: ${fresh[0].trim()}`;
+ else if (gone) recreateWhy = `after an activity recreate: ${gone}`;
+ writeFileSync(path.join(opts.out, `${driver.name}-${label}.log`), log);
+ }
driver.stop();
const image = decodePng(frame);
@@ -527,7 +560,10 @@ async function verifyApp(driver, artifact, label, opts, judgeFrame = true) {
// The record already carries structured errors, and they say far more than a
// pixel count can: drawing-demo drew a black screen because a resize sent
// es_onNativeVisibility into infinite recursion, and the record said so.
+ // Errors the recreate probe provoked are its to report (with attribution),
+ // not this list's — the boot slice is what the plain branch judges.
const errors = log.split('\n').filter((l) => l.startsWith('ERROR ['));
+ const bootErrors = bootErrorCount === null ? errors : errors.slice(0, bootErrorCount);
// `--no-frame-judge` turns the pixel question off entirely: a compatibility
// run compares one Android version against another, and the frame is there to
@@ -536,8 +572,9 @@ async function verifyApp(driver, artifact, label, opts, judgeFrame = true) {
const countColors = judgeFrame && opts.frameJudge !== false;
const why = !ready ? 'never reported ready'
: offScreen ? `the game was not on screen — ${offScreen}`
- : errors.length ? errors[0].trim()
- : (countColors && colors < opts.minColors) ? `the frame is ${colors} flat color` : '';
+ : bootErrors.length ? bootErrors[0].trim()
+ : (countColors && colors < opts.minColors) ? `the frame is ${colors} flat color`
+ : recreateWhy;
return {
ok: !why, ready, colors, readyLine, errors, offScreen, metrics,