Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

tools(verify): a third-person launch that never painted says so, instead of judging a character nobody drove

yhh4e8e3b9eb7a1
diff --git a/tools/verify-third-person.mjs b/tools/verify-third-person.mjs
index 2e3fbcfed..86c379b4e 100644
--- a/tools/verify-third-person.mjs
+++ b/tools/verify-third-person.mjs
@@ -70,8 +70,13 @@ function reading(stdout, label) {
*/
function launch(args, label) {
const r = runElectron([LAUNCHER, ...args], { encoding: 'utf8', cwd: ROOT });
- if (!reading(r.stdout, label)) {
- console.error(`✗ third-person: a launch printed no ${label} reading, so no game ran to judge`);
+ // The launcher drives input only once the package has painted, and reads the world either way: an unpainted
+ // launch reads a character nobody touched, and judging that reported every behaviour as broken.
+ const unpainted = /painted=false/.test(r.stdout ?? '');
+ if (!reading(r.stdout, label) || unpainted) {
+ console.error(unpainted
+ ? `✗ third-person: the package did not paint before the launch's timeout, so no input reached it and no game ran to judge`
+ : `✗ third-person: a launch printed no ${label} reading, so no game ran to judge`);
for (const l of `${r.stderr ?? ''}${r.stdout ?? ''}`.trim().split('\n').slice(-12)) {
console.error(` ${l}`);
}