Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix: update emscripten version check and pnpm filter paths for CI

esengine520f8b343a89
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 69893d14b..e4116df10 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -104,13 +104,13 @@ jobs:
run: pnpm exec tsc --noEmit -p sdk/tsconfig.json
- name: Build SDK
- run: pnpm --filter esengine build
+ run: pnpm --filter ./sdk build
- name: Type-check Editor
run: pnpm exec tsc --noEmit -p editor/tsconfig.json
- name: Run SDK tests with coverage
- run: pnpm --filter esengine vitest run --coverage --coverage.thresholds.lines=60 --coverage.thresholds.functions=60 --coverage.thresholds.branches=60 --coverage.thresholds.statements=60
+ run: pnpm --filter ./sdk vitest run --coverage --coverage.thresholds.lines=60 --coverage.thresholds.functions=60 --coverage.thresholds.branches=60 --coverage.thresholds.statements=60
- name: Run Editor tests with coverage
run: pnpm --filter @esengine/editor vitest run --coverage --coverage.thresholds.lines=60 --coverage.thresholds.functions=60 --coverage.thresholds.branches=60 --coverage.thresholds.statements=60
diff --git a/.github/workflows/release-desktop.yml b/.github/workflows/release-desktop.yml
index 5bac746af..acdf84379 100644
--- a/.github/workflows/release-desktop.yml
+++ b/.github/workflows/release-desktop.yml
@@ -66,7 +66,7 @@ jobs:
run: node build-tools/cli.js build -t all
- name: Build workspace packages
- run: pnpm --filter esengine build && pnpm --filter @esengine/editor build
+ run: pnpm --filter ./sdk build && pnpm --filter ./editor build
- uses: tauri-apps/tauri-action@v0
env:
diff --git a/build-tools/utils/emscripten.js b/build-tools/utils/emscripten.js
index ec103fca4..97df92f75 100644
--- a/build-tools/utils/emscripten.js
+++ b/build-tools/utils/emscripten.js
@@ -2,7 +2,7 @@ import { spawn } from 'child_process';
import os from 'os';
import * as logger from './logger.js';
-const MIN_EMSCRIPTEN_VERSION = '3.1.51';
+const MIN_EMSCRIPTEN_VERSION = '5.0.0';
function compareVersions(a, b) {
const pa = a.split('.').map(Number);
@@ -56,8 +56,8 @@ export async function checkEnvironment() {
if (!checks.emscripten) {
logger.error('Emscripten not found. Please install and activate emsdk:');
- logger.info(' Required version: 3.1.51');
- logger.info(' Install: emsdk install 3.1.51 && emsdk activate 3.1.51');
+ logger.info(` Required version: ${MIN_EMSCRIPTEN_VERSION}`);
+ logger.info(` Install: emsdk install ${MIN_EMSCRIPTEN_VERSION} && emsdk activate ${MIN_EMSCRIPTEN_VERSION}`);
logger.info(' Activate: source /path/to/emsdk/emsdk_env.sh');
return false;
}
diff --git a/build-tools/utils/errorHelp.js b/build-tools/utils/errorHelp.js
index 67b2e1a58..926d6cc02 100644
--- a/build-tools/utils/errorHelp.js
+++ b/build-tools/utils/errorHelp.js
@@ -14,7 +14,7 @@ export function suggestFix(error) {
if (message.includes('emscripten') || message.includes('emcc') || message.includes('emcmake')) {
return [
'Emscripten not found or incorrect version.',
- 'Run: emsdk install 3.1.51 && emsdk activate 3.1.51',
+ 'Run: emsdk install 5.0.0 && emsdk activate 5.0.0',
'Then reload your shell: source path/to/emsdk/emsdk_env.sh',
];
}