Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(camera): use Camera.viewport vec4 instead of stale viewportX/Y/W/H fields

esengine5ec803d7a21a
diff --git a/sdk/src/camera/CameraPlugin.ts b/sdk/src/camera/CameraPlugin.ts
index 9adeb9d80..ca971a76d 100644
--- a/sdk/src/camera/CameraPlugin.ts
+++ b/sdk/src/camera/CameraPlugin.ts
@@ -119,7 +119,7 @@ export function collectCameras(
const camera = registry.getCamera(e);
const transform = registry.getTransform(e);
- const aspect = (camera.viewportW * width) / (camera.viewportH * height);
+ const aspect = (camera.viewport.z * width) / (camera.viewport.w * height);
let projection: Float32Array;
let camHalfW = 0;
let camHalfH = 0;
@@ -151,10 +151,10 @@ export function collectCameras(
const cam = acquireCameraInfo(cameras.length);
cam.entity = e;
cam.viewProjection.set(multiply(projection, view));
- cam.viewportRect.x = camera.viewportX;
- cam.viewportRect.y = camera.viewportY;
- cam.viewportRect.w = camera.viewportW;
- cam.viewportRect.h = camera.viewportH;
+ cam.viewportRect.x = camera.viewport.x;
+ cam.viewportRect.y = camera.viewport.y;
+ cam.viewportRect.w = camera.viewport.z;
+ cam.viewportRect.h = camera.viewport.w;
cam.clearFlags = camera.clearFlags;
cam.priority = camera.priority;
cam.halfW = camHalfW;