Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(gate): a criterion that never ran is not a criterion that passed

esengine627941c61751
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index f5bb91253..de36806a1 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -67,11 +67,31 @@ jobs:
timeout-minutes: 90
steps:
+ # verify-legacy reads examples out of RELEASE TAGS (git archive v0.20.0 …),
+ # which a shallow checkout has none of: old-projects-open failed on all five
+ # with "an unknown tag" every night it ran.
- uses: actions/checkout@v7
+ with:
+ fetch-depth: 0
- uses: ./.github/actions/engine-submodules
+ # play-stop-conserves, scene-churn-flat and the scale budgets measure the
+ # EDITOR, and golden compares a package against the editor's own frame. All
+ # four reported a missing checkout as a verdict.
+ - uses: ./.github/actions/editor-checkout
+ with:
+ ssh-key: ${{ secrets.EDITOR_SSH_KEY }}
- uses: ./.github/actions/setup
- uses: ./.github/actions/render-host
+ - uses: ./.github/actions/editor-host
+
+ # A golden project marks a system @compiled, and packaging one runs the AOT
+ # step rather than falling back — so the three AOT criteria said "there is no
+ # emcc" on a runner that had never been given one.
+ - name: Setup Emscripten
+ uses: mymindstorm/setup-emsdk@v16
+ with:
+ version: 5.0.0
- name: Run the exit criteria
run: node tools/run-release-gate.mjs --host linux
@@ -89,8 +109,15 @@ jobs:
- uses: actions/checkout@v7
- uses: ./.github/actions/engine-submodules
+ # Half the nightly scenes name the editor host, and without it verify-render
+ # got as far as "Command \"vite\" not found" — one second, and read as a
+ # verdict on 141 scenes.
+ - uses: ./.github/actions/editor-checkout
+ with:
+ ssh-key: ${{ secrets.EDITOR_SSH_KEY }}
- uses: ./.github/actions/setup
- uses: ./.github/actions/render-host
+ - uses: ./.github/actions/editor-host
- name: Run the exit criteria
run: node tools/run-release-gate.mjs --host macos
@@ -113,6 +140,13 @@ jobs:
- uses: ./.github/actions/setup
- uses: ./.github/actions/render-host
+ # The corpus it boots includes projects with @compiled systems, which package
+ # through the AOT step.
+ - name: Setup Emscripten
+ uses: mymindstorm/setup-emsdk@v16
+ with:
+ version: 5.0.0
+
# Nested virtualisation for the emulator, as the compat matrix does.
- name: Enable KVM
run: |
diff --git a/bench/aot-native/frame-bench.mjs b/bench/aot-native/frame-bench.mjs
index 647eeb7b6..851c19a23 100644
--- a/bench/aot-native/frame-bench.mjs
+++ b/bench/aot-native/frame-bench.mjs
@@ -132,11 +132,12 @@ const version = JSON.parse(spawnSync(process.execPath, ['-p', 'JSON.stringify(re
{ cwd: ROOT, encoding: 'utf8' }).stdout || '{}').version;
const template = installedTemplateDir(version, os);
if (!template || !existsSync(template)) {
- // Loud, not silent: a bench that skipped without saying so reads as a bench
- // that ran and found nothing.
+ // Saying so was not enough: this exited 0, so the release gate read three
+ // criteria as answered on every runner that never had a template. 2 is the
+ // convention for a machine that cannot answer, which is not a verdict.
console.log(`aot native bench: no ${os} runtime template for v${version} — did NOT run.`);
console.log(` build one with: node build-tools/cli.js native --target ${os}`);
- process.exit(0);
+ process.exit(2);
}
// ---------------------------------------------------------------- the project
diff --git a/tools/run-release-gate.mjs b/tools/run-release-gate.mjs
index f35473721..4255ee4b4 100644
--- a/tools/run-release-gate.mjs
+++ b/tools/run-release-gate.mjs
@@ -73,10 +73,20 @@ function reportElsewhere() {
}
}
+/**
+ * A verifier missing what it needs exits 2, and that is not a verdict.
+ *
+ * Four criteria read PASS on the nightly while their own output said "did NOT
+ * run": exiting 0 having done nothing is, to a runner, exiting 0. Counted apart
+ * from a failure here, and still not counted as answered.
+ */
+const CANNOT_ANSWER = 2;
+
// Every criterion, not the first failure: which of them a release is short of is
// the useful answer, and stopping early turns the rest into silence — the same
// reason verify-render reports its whole matrix.
const failed = [];
+const unanswered = [];
for (const j of jobs) {
const began = Date.now();
process.stdout.write(`\n=== ${j.ids.join(', ')}\n ${j.run}\n`);
@@ -85,6 +95,9 @@ for (const j of jobs) {
if (r.error) {
console.error(`✗ could not run it: ${r.error.message}`);
failed.push({ ...j, secs, why: 'would not start' });
+ } else if (r.status === CANNOT_ANSWER) {
+ console.error(`— UNANSWERED (${secs}s): this machine is missing what it needs`);
+ unanswered.push({ ...j, secs });
} else if (r.status !== 0) {
console.error(`✗ FAIL (${secs}s)`);
failed.push({ ...j, secs, why: `exit ${r.status}` });
@@ -93,9 +106,14 @@ for (const j of jobs) {
}
}
-const short = failed.flatMap((j) => j.ids);
+const short = [...failed, ...unanswered].flatMap((j) => j.ids);
console.log(`\nrelease gate ${RELEASE}: ${automated.length - short.length}/${automated.length} criteria answered`);
for (const j of failed) console.log(` ✗ ${j.ids.join(', ')} — ${j.why}`);
+// Named apart, because the fix is not the same one: a FAIL is the engine's to
+// answer and this is the runner's, and a release is short either way.
+for (const j of unanswered) {
+ console.log(` — ${j.ids.join(', ')} — nothing on this machine could answer it (see its output above)`);
+}
// Named, always: a release is not ready because 27 commands went green, and a
// summary that omits the four nobody can automate reads as though it is.
console.log(` ${manual.length} criteria are BY HAND and this cannot answer them:`);
diff --git a/tools/verify-aot-native.mjs b/tools/verify-aot-native.mjs
index c8b8d2347..4cdf5a349 100644
--- a/tools/verify-aot-native.mjs
+++ b/tools/verify-aot-native.mjs
@@ -42,11 +42,12 @@ const os = process.platform === 'darwin' ? 'macos'
: process.platform === 'win32' ? 'windows' : 'linux';
const template = installedTemplateDir(version, os);
if (!template || !existsSync(template)) {
- // Loud, not silent: a gate that skipped without saying so is a gate that
- // always passes on the machines that never had the thing it checks.
+ // Saying so was not enough: this exited 0, so the release gate read the
+ // criterion as answered on every runner that never had a template. 2 is the
+ // convention for a machine that cannot answer, which is not a verdict.
console.log(`aot native: no ${os} runtime template for v${version} — did NOT run.`);
console.log(' build one with: node build-tools/cli.js native --target ' + os);
- process.exit(0);
+ process.exit(2);
}
const out = mkdtempSync(path.join(tmpdir(), 'estella-aot-native-'));