Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

ci: init the submodules the index has, not the ones .gitmodules names

esengine69977a576a21
diff --git a/.github/actions/engine-submodules/action.yml b/.github/actions/engine-submodules/action.yml
index ca83d48b2..b0bfd82a6 100644
--- a/.github/actions/engine-submodules/action.yml
+++ b/.github/actions/engine-submodules/action.yml
@@ -5,8 +5,10 @@ description: Initialise every submodule except the private editor.
# is private — so a job that only wants third_party's vendored sources fails at
# checkout with "repository not found". These jobs do not want the editor at all.
#
-# Derived from .gitmodules rather than listed here: a new vendored dependency
-# would otherwise be silently left uninitialised by every job using this.
+# The list comes from the INDEX (gitlink entries, mode 160000), not .gitmodules:
+# that file still declares four submodules this repo no longer tracks, and naming
+# them is an immediate `pathspec did not match` rather than a no-op. The index is
+# what `git submodule update` acts on, so it is also what can be asked for.
runs:
using: composite
@@ -15,8 +17,7 @@ runs:
shell: bash
run: |
set -euo pipefail
- paths=$(git config -f .gitmodules --get-regexp '^submodule\..*\.path$' \
- | awk '{print $2}' | grep -vx 'desktop')
+ paths=$(git ls-files --stage | awk '$1 == "160000" {print $4}' | grep -vx 'desktop')
echo "initialising: $(echo "$paths" | tr '\n' ' ')"
# shellcheck disable=SC2086
git submodule update --init --recursive $paths