Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(render): passes that read a world transform decompose it first

esengine6daaf0861767
diff --git a/src/esengine/renderer/RenderFrameMask.cpp b/src/esengine/renderer/RenderFrameMask.cpp
index 58983a819..b6750d722 100644
--- a/src/esengine/renderer/RenderFrameMask.cpp
+++ b/src/esengine/renderer/RenderFrameMask.cpp
@@ -49,7 +49,10 @@ ScreenRect computeMaskScreenRect(
return {0, 0, 0, 0};
}
const auto& node = registry.get<ecs::UINode>(entity);
- const auto& transform = registry.get<ecs::Transform>(entity);
+ auto& transform = registry.get<ecs::Transform>(entity);
+ // The world TRS below is decomposed on demand, so a mask whose transform no
+ // other pass has read this frame would be clipped to where it used to be.
+ transform.ensureDecomposed();
f32 worldW = node.computed_size_.x * transform.worldScale.x;
f32 worldH = node.computed_size_.y * transform.worldScale.y;
diff --git a/src/esengine/renderer/plugins/TilemapRenderPlugin.cpp b/src/esengine/renderer/plugins/TilemapRenderPlugin.cpp
index b76e7f907..305d0b60c 100644
--- a/src/esengine/renderer/plugins/TilemapRenderPlugin.cpp
+++ b/src/esengine/renderer/plugins/TilemapRenderPlugin.cpp
@@ -237,6 +237,7 @@ void TilemapRenderPlugin::collect(RenderCollectContext& collect_ctx) {
Entity transformEntity = (layer.origin_entity != INVALID_ENTITY)
? layer.origin_entity : entity;
if (auto* transform = registry.tryGet<ecs::Transform>(transformEntity)) {
+ transform->ensureDecomposed(); // lazily derived; see Transform.hpp
originX = transform->worldPosition.x;
originY = transform->worldPosition.y;
}