A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.
TypeScript 2d-game-engine3d3d-game-engineandroidcppecsgame-editorgame-enginegamedeviostypescriptwebassemblywebglwebgpuwechat-minigame
perf(ui): use generated web pointers for live focus checks
yhh72471317a868
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 13ff378c4..beaba7cc7 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -16,6 +16,8 @@ published separately; it ships inside the editor.### Fixed+- **Web UI getters can reach their generated pointer accessors.** The optional UINode pointer export avoids full component object marshaling for pre-resolved readers, with existing generated layout assertions and fresh pointer resolution after pool growth. Live focus queries use compact per-query visibility flags and pre-resolved parent reads to reduce transient work; older cores retain the getter fallback.+- **Ineligible text fields reject late editing callbacks immediately.** Hidden fields and controls outside a newly opened modal cannot commit delayed changes, composition endings or submissions. The rejected session releases its OS editing surface and preedit state, so eligibility returning before another frame reattaches the committed value instead of replaying stale input; fields inside the active dialog remain editable.- **Keyboard focus observes authored visibility between layout passes.** Focus traversal and single-target checks read current display ancestry, so hiding a tree or opening a previously hidden modal immediately changes eligibility without waiting for the cached layout bit. Per-query ancestry memoization and borrowed component reads share work across controls; hosts without authored UI ancestry retain their existing visibility fallback.diff --git a/sdk/etc/wasm.api.md b/sdk/etc/wasm.api.mdindex dd57871fa..0e40ce21c 100644--- a/sdk/etc/wasm.api.md+++ b/sdk/etc/wasm.api.md@@ -340,6 +340,7 @@ getUINodeAlphaInTree: ((registry: CppRegistry, entity: number) => number) | undegetUINodeComputedHeight: ((registry: CppRegistry, entity: number) => number) | undefinedgetUINodeComputedWidth: ((registry: CppRegistry, entity: number) => number) | undefinedgetUINodeHiddenInTree: ((registry: CppRegistry, entity: number) => boolean) | undefined+getUINodePtr: ((registry: CppRegistry, entity: number) => number) | undefinedgetVelocityPtr: (registry: CppRegistry, entity: number) => numbergl_checkErrors: (context: string) => numbergl_enableErrorCheck: (enabled: boolean) => voiddiff --git a/sdk/src/ui/input/focus-inspection.ts b/sdk/src/ui/input/focus-inspection.tsindex bd74c8812..b80003baa 100644--- a/sdk/src/ui/input/focus-inspection.ts+++ b/sdk/src/ui/input/focus-inspection.ts@@ -51,38 +51,38 @@ function focusContext(world: FocusInspectionWorld) {/** Authored display is current even between layout passes. Memoize shared* ancestors only within this read-only query, never across scene mutations. */function liveVisibility(world: FocusInspectionWorld, fallback: (entity: Entity) => boolean) {- const getter = (world as FocusInspectionWorld & Partial<Pick<World, 'resolveGetter'>>)- .resolveGetter?.(UINode) as ((entity: Entity) => UINodeData) | null | undefined;+ const fastWorld = world as FocusInspectionWorld & Partial<Pick<World, 'resolveGetter'>>;+ const getter = fastWorld.resolveGetter?.(UINode) as ((entity: Entity) => UINodeData) | null | undefined;const readNode = getter ?? ((entity: Entity) => world.get(entity, UINode));- const memo = new Map<Entity, { hidden: boolean; authored: boolean; pending: boolean }>();+ const parentGetter = fastWorld.resolveGetter?.(Parent) as ((entity: Entity) => { entity: Entity }) | null | undefined;+ const readParent = parentGetter ?? ((entity: Entity) => world.get(entity, Parent));+ const HIDDEN = 1, AUTHORED = 2, PENDING = 4;+ const memo = new Map<Entity, number>();const path: Entity[] = [];return (entity: Entity): boolean => {path.length = 0;- let current = entity, hidden = false, authored = false;- while (world.valid(current)) {+ let current = entity, flags = 0;+ for (;;) {const cached = memo.get(current);- if (cached) {+ if (cached !== undefined) {// Invalid cyclic ancestry cannot receive keyboard input.- hidden = cached.pending || cached.hidden;- authored = cached.pending || cached.authored;+ flags = cached === PENDING ? HIDDEN | AUTHORED : cached;break;}- memo.set(current, { hidden: false, authored: false, pending: true });+ if (!world.valid(current)) break;+ memo.set(current, PENDING);path.push(current);if (!world.has(current, Parent)) break;- current = world.get(current, Parent).entity;+ current = readParent(current).entity;}for (let i = path.length - 1; i >= 0; i--) {- const entry = memo.get(path[i])!;if (world.has(path[i], UINode)) {- authored = true;- hidden = hidden || readNode(path[i]).display === UIDisplay.None;+ flags |= AUTHORED;+ if (!(flags & HIDDEN) && readNode(path[i]).display === UIDisplay.None) flags |= HIDDEN;}- entry.hidden = hidden;- entry.authored = authored;- entry.pending = false;+ memo.set(path[i], flags);}- return authored ? hidden : fallback(entity);+ return flags & AUTHORED ? !!(flags & HIDDEN) : fallback(entity);};}diff --git a/sdk/src/wasm.ts b/sdk/src/wasm.tsindex d7482ea87..97b4392ee 100644--- a/sdk/src/wasm.ts+++ b/sdk/src/wasm.ts@@ -797,6 +797,8 @@ export interface ESEngineModule {// Pointer-based component accessgetTransformPtr(registry: CppRegistry, entity: number): number;getSpritePtr(registry: CppRegistry, entity: number): number;+ /** Optional fast access; older Web cores retain the component-getter fallback. */+ getUINodePtr?(registry: CppRegistry, entity: number): number;getVelocityPtr(registry: CppRegistry, entity: number): number;getCameraPtr(registry: CppRegistry, entity: number): number;getRigidBody2DPtr(registry: CppRegistry, entity: number): number;diff --git a/sdk/tests/ui-focus-transition-wasm.test.ts b/sdk/tests/ui-focus-transition-wasm.test.tsindex 527a5fe7f..5edf6d6d4 100644--- a/sdk/tests/ui-focus-transition-wasm.test.ts+++ b/sdk/tests/ui-focus-transition-wasm.test.ts@@ -92,7 +92,7 @@ describe.skipIf(!HAS_WASM)('focus transitions on real WASM', () => {engine.uiLayout_update(registry, -400, -300, 400, 300, true);expect(isFocusEligible(app.world, entity)).toBe(true);app.world.update(root, UINode, n => { n.display = UIDisplay.None; });- expect(engine.getUINodeHiddenInTree(registry, entity)).toBe(false);+ expect(engine.getUINodeHiddenInTree!(registry, entity)).toBe(false);expect(isFocusEligible(app.world, entity)).toBe(false);app.world.update(root, UINode, n => { n.display = UIDisplay.Flex; });expect(isFocusEligible(app.world, entity)).toBe(true);@@ -110,13 +110,31 @@ describe.skipIf(!HAS_WASM)('focus transitions on real WASM', () => {}app.world.insert(dialog, UIDialog);engine.uiLayout_update(registry, -400, -300, 400, 300, true);- expect(engine.getUINodeHiddenInTree(registry, dialog)).toBe(true);+ expect(engine.getUINodeHiddenInTree!(registry, dialog)).toBe(true);expect(isFocusEligible(app.world, outside)).toBe(true);app.world.update(dialog, UINode, n => { n.display = UIDisplay.Flex; });- expect(engine.getUINodeHiddenInTree(registry, dialog)).toBe(true);+ expect(engine.getUINodeHiddenInTree!(registry, dialog)).toBe(true);expect(isFocusEligible(app.world, outside)).toBe(false);expect(isFocusEligible(app.world, dialog)).toBe(true);app.world.update(dialog, UINode, n => { n.display = UIDisplay.None; });expect(isFocusEligible(app.world, outside)).toBe(true);});++ it('reads UI data through the generated pointer accessor after pool growth', () => {+ expect(typeof engine.getUINodePtr).toBe('function');+ const entity = control(0);+ app.world.insert(entity, UINode, { display: UIDisplay.None, opacity: 0.375 });+ const get = app.world.resolveGetter(UINode)!;+ const legacy = vi.spyOn(registry, 'getUINode');+ try {+ expect(get(entity)).toMatchObject({ display: UIDisplay.None, opacity: 0.375 });+ for (let i = 0; i < 5000; i++) app.world.insert(app.world.spawn(), UINode);+ app.world.update(entity, UINode, node => { node.display = UIDisplay.Flex; });+ legacy.mockClear();+ expect(get(entity)).toMatchObject({ display: UIDisplay.Flex, opacity: 0.375 });+ expect(legacy).not.toHaveBeenCalled();+ } finally { legacy.mockRestore(); }+ const absent = app.world.spawn();+ expect(engine.getUINodePtr!(registry, absent)).toBe(0);+ });});diff --git a/src/esengine/bindings/WebSDKEntry.cpp b/src/esengine/bindings/WebSDKEntry.cppindex f262cc075..e0c607450 100644--- a/src/esengine/bindings/WebSDKEntry.cpp+++ b/src/esengine/bindings/WebSDKEntry.cpp@@ -398,6 +398,12 @@ int getSpritePtr(ecs::Registry& r, u32 e) {return static_cast<int>(reinterpret_cast<uintptr_t>(s));}+int getUINodePtr(ecs::Registry& r, u32 e) {+ auto* node = r.tryGet<ecs::UINode>(Entity::fromRaw(e));+ if (!node) return 0;+ return static_cast<int>(reinterpret_cast<uintptr_t>(node));+}+int getVelocityPtr(ecs::Registry& r, u32 e) {auto* v = r.tryGet<ecs::Velocity>(Entity::fromRaw(e));if (!v) return 0;@@ -434,6 +440,7 @@ EMSCRIPTEN_BINDINGS(esengine_ptr_access) {emscripten::function("getTransformPtr", &esengine::getTransformPtr);emscripten::function("registryLayoutEpoch", &esengine::registryLayoutEpoch);emscripten::function("getSpritePtr", &esengine::getSpritePtr);+ emscripten::function("getUINodePtr", &esengine::getUINodePtr);emscripten::function("getVelocityPtr", &esengine::getVelocityPtr);emscripten::function("getCameraPtr", &esengine::getCameraPtr);emscripten::function("getRigidBody2DPtr", &esengine::getRigidBody2DPtr);diff --git a/tools/releaseNotes.mjs b/tools/releaseNotes.mjsindex 52c98024a..3137bd959 100644--- a/tools/releaseNotes.mjs+++ b/tools/releaseNotes.mjs@@ -28,6 +28,8 @@ export const NOTES_FLOOR = 'v0.65.0';* the reader recognises anyway.*/export const NOTED = {+ 'perf(ui): use generated web pointers for live focus checks':+ { note: 'Web UI getters can reach their generated pointer accessors.' },'fix(ui): retire text sessions when focus eligibility changes':{ note: 'Ineligible text fields reject late editing callbacks immediately.' },'fix(ui): resolve live display ancestry for keyboard focus':