Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(lod): a skinned group whose stand-in the skeleton cannot pose is refused whole, a cull size or not

yhh7a7b7e204619
diff --git a/desktop b/desktop
index e106641ae..ef180a824 160000
--- a/desktop
+++ b/desktop
@@ -1 +1 @@
-Subproject commit e106641ae421766a26ddcd61f458e018f16c8548
+Subproject commit ef180a82444d3a8d09f28d13816565d4af0add91
diff --git a/src/esengine/renderer/plugins/MeshPlugin.cpp b/src/esengine/renderer/plugins/MeshPlugin.cpp
index a6db946a2..4a054a350 100644
--- a/src/esengine/renderer/plugins/MeshPlugin.cpp
+++ b/src/esengine/renderer/plugins/MeshPlugin.cpp
@@ -229,7 +229,9 @@ bool gatherLodLevels(resource::ResourceManager& resources, const ecs::LODGroup&
out.localMin = glm::min(out.localMin, standIn->localMin);
out.localMax = glm::max(out.localMax, standIn->localMax);
}
- return out.set.count > 0 || out.set.cull > 0.0f;
+ // A skin whose stand-in the skeleton cannot pose is refused whole: a cull size alone is not a reason to keep a group that was authored against
+ // levels it cannot have.
+ return out.set.count > 0 || (out.set.cull > 0.0f && !out.skinMismatch);
}
/** @brief Says once what a group declares that nothing will ever use. */
diff --git a/tools/releaseNotes.mjs b/tools/releaseNotes.mjs
index 497e8a14f..c1b400c8e 100644
--- a/tools/releaseNotes.mjs
+++ b/tools/releaseNotes.mjs
@@ -2866,6 +2866,10 @@ export const NOTED = {
{"note":"Clouds drawn from a coverage picture."},
"fix(examples): Terrain & Water takes the compact grass with its leaf colour from the art":
{"note":"A generated world's plants."},
+ "fix(lod): a skinned group whose stand-in the skeleton cannot pose is refused whole, a cull size or not":
+ {"internal":"Restores the refusal a cull-only group had lost; nothing a creator could use changed."},
+ "fix(editor-checks): the texture handle sample is taken again until its frame is drawn":
+ {"internal":"A test race."},
"feat(water): two tiled, scrolling detail normal maps give the surface its sparkle":
{"note":"Sparkle on the water."},
"fix(lod): a LODGroup with only a cull size is no longer ignored":