Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

ci(nightly): the third-person and compiled-game package checks run on macOS, where a package boots on a GPU

yhh95afb8273451
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 1b6061d85..ca55330eb 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -206,13 +206,10 @@ jobs:
# Four launches of a streamed world, which alone has taken twenty minutes.
- shard: streamed
criteria: --only streamed-world-comes-and-goes
- # 29 launches of the third-person package: 15 of its checks took 56 minutes
- # on a runner, so the whole list needs a window of its own.
- - shard: third-person
- criteria: --only a-character-may-only-do-what-the-world-allows,a-streamed-place-is-ready-before-it-is-seen
- timeout: 150
+ # The third-person package and the compiled-game parity run on the macOS job: they judge web packages,
+ # and here, with no GPU, a package often boots past its launch timeout (releaseGate.mjs says why).
- shard: rest
- criteria: --except flagship-plays-through,golden-packages,performance-ceilings,static-gates,streamed-world-comes-and-goes,a-character-may-only-do-what-the-world-allows,a-streamed-place-is-ready-before-it-is-seen
+ criteria: --except flagship-plays-through,golden-packages,performance-ceilings,static-gates,streamed-world-comes-and-goes
env:
ESTELLA_NATIVE_TEMPLATES: ${{ github.workspace }}/.native-templates
# Empty outside the golden shards, where verify-golden takes the whole tier.
@@ -318,7 +315,8 @@ jobs:
name: Exit criteria (macos)
runs-on: macos-latest
needs: build-emscripten
- timeout-minutes: 90
+ # The pixel gates, plus the third-person package's 29 launches and the compiled-game parity.
+ timeout-minutes: 120
steps:
- uses: actions/checkout@v7
@@ -333,6 +331,13 @@ jobs:
- uses: ./.github/actions/setup
- uses: ./.github/actions/render-host
- uses: ./.github/actions/editor-host
+ # The compiled-game parity builds its systems module with emcc.
+ - name: Setup Emscripten
+ uses: mymindstorm/setup-emsdk@v16
+ with:
+ version: 5.0.0
+ actions-cache-folder: .emsdk-ci
+ cache-key: emsdk-5.0.0-${{ runner.os }}-${{ runner.arch }}
- name: Run the exit criteria
run: node tools/run-release-gate.mjs --host macos
diff --git a/tools/releaseGate.mjs b/tools/releaseGate.mjs
index 126c8adf0..7bb59aa43 100644
--- a/tools/releaseGate.mjs
+++ b/tools/releaseGate.mjs
@@ -60,15 +60,18 @@ export const CRITERIA = [
},
{
id: 'a-character-may-only-do-what-the-world-allows',
+ host: 'macos',
+ why: 'it judges a web package booted in Electron, which says nothing about Linux; a Linux runner has no GPU, and a package rasterised in software boots past the launch timeout often enough that the reading was of a game nobody drove',
says: 'a packaged third-person character climbs, is stopped, and lands where its world says',
- // 29 launches over 2440 rendered frames — the arena costs about 1.4 s a frame
- // on a runner with no GPU, so this is a nightly question. It sat in the push
+ // 29 launches over 2440 rendered frames — a nightly question, on the runner with a GPU. It sat in the push
// gate behind a step that always failed first, and never once ran there.
answeredBy: 'node tools/verify-third-person.mjs',
needs: ['tools/verify-third-person.mjs', 'examples/third-person-3d/project.esproject'],
},
{
id: 'a-streamed-place-is-ready-before-it-is-seen',
+ host: 'macos',
+ why: 'it judges a web package booted in Electron, which says nothing about Linux; a Linux runner has no GPU, and a package rasterised in software boots past the launch timeout often enough that the reading was of a game nobody drove',
says: 'a streamed place pays its own shader requirements while it is being prepared,'
+ ' not on the frame the player first sees it',
// The same command as above, deliberately under its own name: deleting the
@@ -197,6 +200,8 @@ export const CRITERIA = [
},
{
id: 'compiled-game-packages-and-draws',
+ host: 'macos',
+ why: 'it judges a web package booted in Electron, which says nothing about Linux; a Linux runner has no GPU, and a package rasterised in software boots past the launch timeout often enough that the reading was of a game nobody drove',
says: 'a game whose systems were compiled packages, boots and draws the game it drew interpreted',
// Not "the same pixels": the loop is wall-clock, so two launches of ONE
// package already differ by more than a wrong field offset does (the file
diff --git a/tools/run-release-gate.mjs b/tools/run-release-gate.mjs
index f0609c7ae..3996eda76 100644
--- a/tools/run-release-gate.mjs
+++ b/tools/run-release-gate.mjs
@@ -34,7 +34,7 @@ const ONLY = flag('only')?.split(',').map((s) => s.trim()).filter(Boolean) ?? nu
// a criterion added tomorrow lands here rather than in no job at all.
const EXCEPT = flag('except')?.split(',').map((s) => s.trim()).filter(Boolean) ?? null;
// Where this runner is standing. A criterion says which host can answer it; the
-// default is a plain Linux runner, which is 27 of the 31.
+// default is a plain Linux runner, which answers most of them.
const HOST = flag('host') ?? 'linux';
const runnable = CRITERIA.filter((c) => c.answeredBy);