Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(ci): a golden package launch waits for its settle frames, and only gives up on a package that hangs

yhhb5422aa65a02
diff --git a/tools/goldenProjects.mjs b/tools/goldenProjects.mjs
index 40f5ea978..0bbb63b07 100644
--- a/tools/goldenProjects.mjs
+++ b/tools/goldenProjects.mjs
@@ -1343,9 +1343,6 @@ export const GOLDEN = [
// Walking is what makes a place exist here, so the frame after 60 frames of
// it differs by more than a character moving — a cell came in.
interact: { keys: ['KeyD'], frames: 60 },
- // Measured on a runner of its own: 25, 28 and 30 of 30 settle frames inside the 30 s default on different runs of the same code, about
- // a frame a second in software GL. The window is the project's, as character-rig's is.
- launchTimeoutMs: 120_000,
// Comparable now that the editor cuts this world the way the package does —
// but not the claim: the frame moved only 0.0073 → 0.0008 when Play stopped
// loading it whole. verify-world-residency.mjs asks both for their residency.
diff --git a/tools/launchers/launch-export.mjs b/tools/launchers/launch-export.mjs
index 023181c75..ec9132667 100644
--- a/tools/launchers/launch-export.mjs
+++ b/tools/launchers/launch-export.mjs
@@ -21,7 +21,7 @@
* --w / --h surface size (default 640x360)
* --settle <n> frames to let run before capturing (default 30)
* --frame-ms <n> simulated time per render frame (default 1000/60; 0 = real time)
- * --timeout <ms> how long to wait for the first frame (default 30000)
+ * --timeout <ms> how long to wait for the first frame (default 180000)
* --scene <name> boot this named scene instead of the package's entry
* --port <n> serve on a fixed loopback port for same-origin restart tests
* --present present without taking focus, for virtual-desktop frame checks
@@ -110,7 +110,9 @@ const SETTLE = Number(flag('settle', '30'));
const INPUT = flag('input', '');
/** After the input, keep running until the engine has nothing left to bake, instead of guessing a frame count. */
const UNTIL_IDLE = has('until-idle');
-const TIMEOUT = Number(flag('timeout', '30000'));
+// How long to wait for the settle frames before calling the launch dead. A slow rasterizer makes frames late, not wrong, so the bound is only there
+// for a package that hangs; what the launch decides is whether the frames came.
+const TIMEOUT = Number(flag('timeout', '180000'));
const LOG = flag('log', '');
/** Emulate a link before loading, so the start screen is asked a real question. */
const THROTTLE = flag('throttle', '');
diff --git a/tools/releaseNotes.mjs b/tools/releaseNotes.mjs
index c13d418d6..1d023a32e 100644
--- a/tools/releaseNotes.mjs
+++ b/tools/releaseNotes.mjs
@@ -3096,6 +3096,8 @@ export const NOTED = {
{"internal":"Repairs the release-notes ledger; no creator can observe it."},
"fix(ci): world-streaming-3d is given the settle window its frame rate needs":
{"internal":"A golden package's launch window; no creator can observe it."},
+ "fix(ci): a golden package launch waits for its settle frames, and only gives up on a package that hangs":
+ {"internal":"A golden package's launch window; no creator can observe it."},
"fix(ci): the ledger names its own repair":
{"internal":"Repairs the release-notes ledger; no creator can observe it."},
"feat(render): the medium quality level smooths edges temporally by default":
diff --git a/tools/verify-golden.mjs b/tools/verify-golden.mjs
index 91dd93acf..3edda0e17 100644
--- a/tools/verify-golden.mjs
+++ b/tools/verify-golden.mjs
@@ -307,7 +307,7 @@ function launchPackage(id, target, args) {
// Three launches on one rasterizer each get the wait three would: alone,
// model-import settles 30 frames inside its 30 s; beside two workers it made 22.
const at = args.indexOf('--timeout');
- const timeoutMs = (at >= 0 ? Number(args[at + 1]) : 30_000) * SHARE;
+ const timeoutMs = (at >= 0 ? Number(args[at + 1]) : 180_000) * SHARE;
const patient = at >= 0
? [...args.slice(0, at + 1), String(timeoutMs), ...args.slice(at + 2)]
: [...args, '--timeout', String(timeoutMs)];