Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(gates): the editor checks measure a window the runner was choosing

yhhb7e15e71cd1c
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3f19f4a82..121801332 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -343,6 +343,16 @@ jobs:
name: Editor authoring checks
runs-on: ubuntu-latest
needs: build-emscripten
+ # The window the editor opens is what its viewport measures, and several of
+ # these checks measure the viewport. Pinned here rather than left to the
+ # runner: main.ts wants 1480x920, and on a screen narrower than that the
+ # window arrives some other width — design-frame reads the design screen's
+ # projected shape and answered 4.3% to a bar of 8%, where every width this
+ # was reproduced at locally reads 8.9% to 15.8%. The screens below are sized
+ # so this window is never the thing that gets clamped.
+ env:
+ ESTELLA_WIN_W: '1480'
+ ESTELLA_WIN_H: '920'
# Forty-two authoring checks are sixteen minutes of it on their own, and four
# more steps follow. At 30 the job was killed mid-step rather than reporting.
timeout-minutes: 45
@@ -375,7 +385,7 @@ jobs:
working-directory: desktop
env:
ELECTRON_DISABLE_SANDBOX: '1'
- run: xvfb-run -a node scripts/editor-checks/run.mjs
+ run: xvfb-run -a --server-args="-screen 0 1920x1080x24" node scripts/editor-checks/run.mjs
# The pixel gates whose subject is an editor door — the reference grid, hit
# testing, the editor eye, preview renders. They cannot run on the engine's
@@ -387,7 +397,7 @@ jobs:
- name: Run the editor's pixel gates
env:
ELECTRON_DISABLE_SANDBOX: '1'
- run: xvfb-run -a node tools/verify-render.mjs --tier pr --host editor --no-build --budget 10
+ run: xvfb-run -a --server-args="-screen 0 1920x1080x24" node tools/verify-render.mjs --tier pr --host editor --no-build --budget 10
# The job has died here twice with "No space left on device", and a runner with
# no disk cannot write the log that would say what filled it. The `df` at the
@@ -428,8 +438,8 @@ jobs:
env:
ELECTRON_DISABLE_SANDBOX: '1'
run: |
- xvfb-run -a node scripts/editor-mcp-e2e.mjs
- xvfb-run -a node scripts/editor-mcp-editor-e2e.mjs
+ xvfb-run -a --server-args="-screen 0 1920x1080x24" node scripts/editor-mcp-e2e.mjs
+ xvfb-run -a --server-args="-screen 0 1920x1080x24" node scripts/editor-mcp-editor-e2e.mjs
verify-packages:
name: Packages (golden + released)
diff --git a/desktop b/desktop
index 3926af21d..0ab35efcd 160000
--- a/desktop
+++ b/desktop
@@ -1 +1 @@
-Subproject commit 3926af21d581099fa5cf64e67e71ecbdd9d7f073
+Subproject commit 0ab35efcd9559cbb665ad7e0980829f82c7d8103