Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(sdk): keep indexed access valid for strict consumers

yhhd17a4c8a3412
diff --git a/sdk/src/ecs/ScriptPool.ts b/sdk/src/ecs/ScriptPool.ts
index 9d5780e85..00ae3050b 100644
--- a/sdk/src/ecs/ScriptPool.ts
+++ b/sdk/src/ecs/ScriptPool.ts
@@ -436,8 +436,9 @@ export class ScriptPool {
private writeValue_(slot: number, index: number, at: number, value: unknown): void {
this.ensureCurrent_();
- if (typeof value === 'string' && this.fields[index].kind === 'number'
- && this.assetRefs_?.fields().some(f => f.field === this.fields[index].name)) {
+ const field = this.fields[index];
+ if (typeof value === 'string' && field?.kind === 'number'
+ && this.assetRefs_?.fields().some(f => f.field === field.name)) {
this.refs_ ??= new Map();
let refs = this.refs_.get(slot);
if (!refs) {
diff --git a/sdk/src/util/disposeAll.ts b/sdk/src/util/disposeAll.ts
index 609b1856f..b5ec6d458 100644
--- a/sdk/src/util/disposeAll.ts
+++ b/sdk/src/util/disposeAll.ts
@@ -4,7 +4,7 @@
export function disposeAll<T>(items: readonly T[], dispose: (item: T) => void, reverse = false): void {
let failed = false, reason: unknown;
for (let n = 0; n < items.length; n++) {
- try { dispose(items[reverse ? items.length - 1 - n : n]); }
+ try { dispose(items[reverse ? items.length - 1 - n : n]!); }
catch (error) { if (!failed) { failed = true; reason = error; } }
}
if (failed) throw reason;
diff --git a/tools/releaseNotes.mjs b/tools/releaseNotes.mjs
index 342f04133..8dd0ab3ea 100644
--- a/tools/releaseNotes.mjs
+++ b/tools/releaseNotes.mjs
@@ -28,6 +28,8 @@ export const NOTES_FLOOR = 'v0.65.0';
* the reader recognises anyway.
*/
export const NOTED = {
+ 'fix(sdk): keep indexed access valid for strict consumers':
+ { internal: 'Preserves supported pool and cleanup behavior while satisfying strict compiler consumer type checks.' },
'fix(sdk): resolve spawned entities before tracking scene ownership':
{ note: 'Scene assets have scoped ownership.' },
'Fix engine activity, asset ownership and material rendering':