Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(gates): the editor capture gets the settle window the package gets

esengined8c9dc363a74
diff --git a/desktop b/desktop
index 36735ae4c..be58c1f20 160000
--- a/desktop
+++ b/desktop
@@ -1 +1 @@
-Subproject commit 36735ae4cd3c924a4b7efa35337beda45b41c912
+Subproject commit be58c1f20e7e40aa78201c158bc8649b340b4ff6
diff --git a/tools/verify-golden.mjs b/tools/verify-golden.mjs
index c5f8dd69e..917bc8201 100644
--- a/tools/verify-golden.mjs
+++ b/tools/verify-golden.mjs
@@ -164,7 +164,7 @@ function designAspect(id) {
* a landscape surface draws the package's rotate gate against the editor's
* letterbox — a difference of surface, not of game.
*/
-function captureEditorFrame(id, out) {
+function captureEditorFrame(id, out, timeoutMs) {
const a = designAspect(id);
const major = 820;
const panel = a.h >= a.w
@@ -187,6 +187,9 @@ function captureEditorFrame(id, out) {
ESTELLA_SHOT_PLAY: '1',
ESTELLA_SHOT_CROP: 'iframe[title="Game"]',
ESTELLA_SHOT_EVAL: `window.__estellaEditor.setPanelSize('viewport', ${JSON.stringify(panel)})`,
+ // The settle window the PACKAGE gets, so one policy covers both sides:
+ // a project that needs longer needs it wherever its frames are drawn.
+ ...(timeoutMs ? { ESTELLA_SHOT_PLAY_TIMEOUT: String(timeoutMs) } : {}),
ESTELLA_WIN_W: '1500',
ESTELLA_WIN_H: '1040',
},
@@ -408,7 +411,7 @@ for (const { id, target } of pairs) {
const tolerance = COMPARABLE.has(target) && !NO_PARITY ? parityFor(golden) : null;
const editorPng = path.join(WORK, `${id}-editor.png`);
- const editor = tolerance != null ? captureEditorFrame(id, editorPng) : null;
+ const editor = tolerance != null ? captureEditorFrame(id, editorPng, timeoutMs) : null;
if (editor && !editor.ok) {
results.push({ id, target, stage: 'editor-frame', ok: false, why: editor.why });
console.log(`✗ ${id} ${target} — the editor never produced a play frame`);