Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

perf: reuse IteratorResult object in query for-of iteration

esengineea5334a3b11b
diff --git a/sdk/src/query.ts b/sdk/src/query.ts
index 861a061e8..e9e2ae195 100644
--- a/sdk/src/query.ts
+++ b/sdk/src/query.ts
@@ -258,6 +258,9 @@ export class QueryInstance<C extends readonly QueryArg[]> implements Iterable<Qu
}
};
+ const iterResult: IteratorResult<QueryResult<C>> = { value: result as QueryResult<C>, done: false };
+ const doneResult: IteratorResult<QueryResult<C>> = { value: undefined as unknown as QueryResult<C>, done: true };
+
return {
next(): IteratorResult<QueryResult<C>> {
if (!started) {
@@ -289,15 +292,15 @@ export class QueryInstance<C extends readonly QueryArg[]> implements Iterable<Qu
prevEntity = entity;
}
- return { value: result as QueryResult<C>, done: false };
+ return iterResult;
}
finalize();
- return { value: undefined as unknown as QueryResult<C>, done: true };
+ return doneResult;
},
return(): IteratorResult<QueryResult<C>> {
finalize();
- return { value: undefined as unknown as QueryResult<C>, done: true };
+ return doneResult;
},
};
}