Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix(gates): the import-settings rule can see a reader named for what it reads

yhhf00fa6eef0d0
diff --git a/tools/check-import-settings.mjs b/tools/check-import-settings.mjs
index 0803eaa67..65ff1f901 100644
--- a/tools/check-import-settings.mjs
+++ b/tools/check-import-settings.mjs
@@ -57,7 +57,12 @@ const unverified = [];
const readers = files
.filter((f) => /\.(ts|tsx)$/.test(f) && !f.includes('generated') && f !== SPECS.split(path.sep).join('/'))
.map((f) => readFileSync(path.join(ROOT, f), 'utf8'))
- .filter((text) => /\bimporter\b/i.test(text))
+ // `importer`, not `importer`: the word boundary excluded every file whose
+ // accessor is NAMED for the thing — `importerFor`, `importerDefaults`,
+ // `applyImporterEdit` — which is to say the files most likely to be readers.
+ // A sheet grid read through `AssetRegistry.importerFor(path)?.sheet` was
+ // reported as a knob that does nothing.
+ .filter((text) => /importer/i.test(text))
.join('\n');
const problems = [];