Skip to content

A fast 2D and 3D game engine — TypeScript SDK, C++/WebAssembly core, visual editor. Ship one project to web, desktop, WeChat MiniGames, playable ads, and native Android / iOS.

fix: Sprite seamless tiling, dynamic Inspector visibility, clean Transform

esenginef11d54105faf
diff --git a/editor/src/panels/inspector/EntityInspector.ts b/editor/src/panels/inspector/EntityInspector.ts
index 29f490672..1f9d9e6fa 100644
--- a/editor/src/panels/inspector/EntityInspector.ts
+++ b/editor/src/panels/inspector/EntityInspector.ts
@@ -590,13 +590,19 @@ function renderPropertyRow(
return;
}
+ const hasVisibilityRule = propMeta.visibleWhen != null || propMeta.hiddenWhen != null;
const fullData = { ...defaults, ...component.data };
- if (!visibilityResolver.isVisible(propMeta, fullData, entityComponents)) {
+ const initiallyVisible = visibilityResolver.isVisible(propMeta, fullData, entityComponents);
+
+ if (!initiallyVisible && !hasVisibilityRule) {
return;
}
const row = document.createElement('div');
row.className = 'es-property-row';
+ if (!initiallyVisible) {
+ row.style.display = 'none';
+ }
const entityData = store.getEntityData(entity as number);
if (entityData?.prefab && isPropertyOverridden(
@@ -680,6 +686,21 @@ function renderPropertyRow(
}
container.appendChild(row);
+
+ if (hasVisibilityRule) {
+ editors.push({
+ editor: {
+ update() {
+ const data = { ...defaults, ...component.data };
+ const visible = visibilityResolver.isVisible(propMeta, data, entityComponents);
+ row.style.display = visible ? '' : 'none';
+ },
+ dispose() {},
+ },
+ componentType: component.type,
+ propertyName: `__visibility_${propMeta.name}`,
+ });
+ }
}
// =============================================================================
diff --git a/editor/src/plugins/coreComponents.ts b/editor/src/plugins/coreComponents.ts
index 068dc38d8..6a650e98d 100644
--- a/editor/src/plugins/coreComponents.ts
+++ b/editor/src/plugins/coreComponents.ts
@@ -29,6 +29,7 @@ export const coreComponentsPlugin: EditorPlugin = {
TransformSchema = defineSchema('Transform', {
removable: false,
+ exclude: ['worldPosition', 'worldRotation', 'worldScale'],
overrides: {
rotation: { type: 'euler' },
},
diff --git a/src/esengine/renderer/plugins/SpritePlugin.cpp b/src/esengine/renderer/plugins/SpritePlugin.cpp
index f73f65edd..25233f0c3 100644
--- a/src/esengine/renderer/plugins/SpritePlugin.cpp
+++ b/src/esengine/renderer/plugins/SpritePlugin.cpp
@@ -79,16 +79,11 @@ void SpritePlugin::collect(
}
bool hasTiling = sprite.tileSize.x > 0.0f && sprite.tileSize.y > 0.0f;
- bool hasSpacing = sprite.tileSpacing.x > 0.0f || sprite.tileSpacing.y > 0.0f;
-
- if (hasTiling && !hasSpacing) {
- uvSc = finalSize / (sprite.tileSize * glm::vec2(scale));
- }
u32 shaderId = batch_shader_id_;
BlendMode blend = BlendMode::Normal;
- if (hasTiling && hasSpacing) {
+ if (hasTiling) {
emitTiledQuads(buffers, draw_list,
glm::vec2(position), finalSize, sprite.pivot,
angle, position.z,