Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

test(eve): let in-flight workflow deliveries settle before clearing the test world (#4796)

roboeve[bot]11e094718a63
diff --git a/packages/eve/test/setup/workflow-setup.ts b/packages/eve/test/setup/workflow-setup.ts
index d535ed6fd..894465f4d 100644
--- a/packages/eve/test/setup/workflow-setup.ts
+++ b/packages/eve/test/setup/workflow-setup.ts
@@ -30,17 +30,51 @@ const world = createWorld({
await world.start?.();
await world.clear();
-world.registerHandler(
- deriveEveWorkflowQueuePrefix(WORKFLOW_TEST_AGENT_NAME),
- createLazyHandler(join(outDir, "workflows.mjs")),
-);
+const deliveries = trackDeliveries(createLazyHandler(join(outDir, "workflows.mjs")));
+world.registerHandler(deriveEveWorkflowQueuePrefix(WORKFLOW_TEST_AGENT_NAME), deliveries.handler);
setWorld(world);
afterAll(async () => {
- setWorld(undefined);
+ // A test can end while its session still runs, such as one that dispatches
+ // a reset and returns. Clearing the world under that delivery fails it in
+ // places nothing awaits, like a stream it hydrates, and Vitest reports the
+ // rejection as an unhandled error. Refuse new deliveries and let the
+ // in-flight ones settle first.
+ await deliveries.close();
await world.close?.();
+ setWorld(undefined);
});
+/** Wraps the queue handler so teardown can refuse new deliveries and await running ones. */
+function trackDeliveries(handle: (request: Request) => Promise<Response>) {
+ const running = new Set<Promise<Response>>();
+ let closing = false;
+ return {
+ async handler(request: Request): Promise<Response> {
+ // world-local drops a delivery whose handler throws an AbortError.
+ if (closing) throw new DOMException("The test workflow world is closing.", "AbortError");
+ const delivery = handle(request);
+ running.add(delivery);
+ try {
+ return await delivery;
+ } finally {
+ running.delete(delivery);
+ }
+ },
+ async close(): Promise<void> {
+ closing = true;
+ // Stay within Vitest's 10s hook timeout if a delivery never settles.
+ const deadline = Date.now() + 5_000;
+ while (running.size > 0 && Date.now() < deadline) {
+ await Promise.race([
+ Promise.allSettled(running),
+ new Promise((resolve) => setTimeout(resolve, deadline - Date.now())),
+ ]);
+ }
+ },
+ };
+}
+
function createLazyHandler(bundlePath: string): (request: Request) => Promise<Response> {
let handler: ((request: Request) => Promise<Response>) | undefined;
let loading: Promise<(request: Request) => Promise<Response>> | undefined;