Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): properly support multiline titles, stopping TUI prompt spam (#3429)

Ben Pankow16e11f9f727f
diff --git a/.changeset/quiet-multiline-setup-title.md b/.changeset/quiet-multiline-setup-title.md
new file mode 100644
index 000000000..f9bbabfd5
--- /dev/null
+++ b/.changeset/quiet-multiline-setup-title.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Prevent multiline setup prompts, including the Vercel project-link question shown by `/add`, from being duplicated into TUI scrollback during repaints.
diff --git a/packages/eve/src/cli/dev/tui/setup-panel.test.ts b/packages/eve/src/cli/dev/tui/setup-panel.test.ts
index 05ff13927..2cf20c764 100644
--- a/packages/eve/src/cli/dev/tui/setup-panel.test.ts
+++ b/packages/eve/src/cli/dev/tui/setup-panel.test.ts
@@ -67,6 +67,33 @@ describe("renderFlowPanel", () => {
expect(text).toContain(" › Create a new project");
});
+ it("renders multiline titles as separate terminal rows", () => {
+ const title =
+ "You need to link to a project to use linear through Vercel Connect.\n\nSelect your team";
+ const rows = renderFlowPanel(
+ {
+ title: "Add to your agent",
+ lines: [],
+ content: {
+ kind: "question",
+ title,
+ rows: [" › Vercel"],
+ },
+ },
+ theme,
+ 80,
+ );
+
+ expect(rows.slice(0, 5)).toEqual([
+ " You need to link to a project to use linear through Vercel Connect.",
+ "",
+ " Select your team",
+ "",
+ " › Vercel",
+ ]);
+ expect(rows.every((row) => !row.includes("\n"))).toBe(true);
+ });
+
it("renders multiline diagnostics as separate terminal rows", () => {
const rows = renderFlowPanel(
{
diff --git a/packages/eve/src/cli/dev/tui/setup-panel.ts b/packages/eve/src/cli/dev/tui/setup-panel.ts
index 53f24277b..e3b6b8d9e 100644
--- a/packages/eve/src/cli/dev/tui/setup-panel.ts
+++ b/packages/eve/src/cli/dev/tui/setup-panel.ts
@@ -281,7 +281,12 @@ export function renderFlowPanel(state: FlowPanelState, theme: Theme, width: numb
const rows: string[] = [];
const title =
state.content.kind === "question" ? (state.content.title ?? state.title) : state.title;
- if (title.length > 0) rows.push(` ${c.bold(title)}`, "");
+ if (title.length > 0) {
+ for (const line of title.split("\n")) {
+ rows.push(line.length === 0 ? "" : ` ${c.bold(line)}`);
+ }
+ rows.push("");
+ }
if (state.navigation?.kind === "planner") {
rows.push(...plannerStepRows(state.navigation, undefined, theme));
}
diff --git a/packages/eve/src/cli/dev/tui/terminal-renderer.test.ts b/packages/eve/src/cli/dev/tui/terminal-renderer.test.ts
index d1677f990..a367bff02 100644
--- a/packages/eve/src/cli/dev/tui/terminal-renderer.test.ts
+++ b/packages/eve/src/cli/dev/tui/terminal-renderer.test.ts
@@ -4458,6 +4458,30 @@ describe("TerminalRenderer setup panel", () => {
});
describe("TerminalRenderer setup flow session", () => {
+ it("repaints multiline setup titles without leaking copies into the transcript", async () => {
+ const { screen, input, renderer } = makeRenderer();
+ const message =
+ "You need to link to a project to use linear through Vercel Connect.\n\nSelect your team";
+
+ renderer.setupFlow.begin("Add to your agent", "pulse");
+ const answer = renderer.setupFlow.readSelect({
+ kind: "single",
+ message,
+ options: [
+ { value: "vercel", label: "Vercel" },
+ { value: "labs", label: "Vercel Labs" },
+ ],
+ });
+ input.down();
+ input.up();
+
+ expect(screen.snapshot().split(message.split("\n")[0]!)).toHaveLength(2);
+ input.send("\x1b");
+ await expect(answer).resolves.toBeUndefined();
+ renderer.setupFlow.end({ preserveDiagnostics: false });
+ renderer.shutdown();
+ });
+
it("discards inherited subprocess output when restoring the transcript", async () => {
const { screen, input, renderer } = makeRenderer();