Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): write monorepo fallback service config under the app root (#3644)

Bryan Hunter1a6cb88c4087
diff --git a/.changeset/tidy-build-output.md b/.changeset/tidy-build-output.md
new file mode 100644
index 000000000..407ef5000
--- /dev/null
+++ b/.changeset/tidy-build-output.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Write fallback Vercel service configuration under the Next.js app directory in linked monorepos. This keeps generated eve services discoverable when no active build output directory is found, preventing deployments that omit the agent endpoints.
diff --git a/packages/eve/src/public/next/index.integration.test.ts b/packages/eve/src/public/next/index.integration.test.ts
index 0dcccf2c6..e42daf6c8 100644
--- a/packages/eve/src/public/next/index.integration.test.ts
+++ b/packages/eve/src/public/next/index.integration.test.ts
@@ -129,11 +129,16 @@ describe("withEve Vercel config", () => {
});
});
- it("writes Build Output config to the closest existing .vercel directory", async () => {
+ it("writes fallback Build Output config under the app in a linked monorepo", async () => {
const projectRoot = await createTempAppRoot();
const appRoot = join(projectRoot, "apps", "web");
await mkdir(join(projectRoot, ".vercel"), { recursive: true });
- await writeFile(join(projectRoot, ".vercel", "project.json"), "{}\n");
+ await writeFile(
+ join(projectRoot, ".vercel", "project.json"),
+ JSON.stringify({ settings: { rootDirectory: "apps/web" } }),
+ );
+ await mkdir(join(projectRoot, "custom-staging"));
+ await writeFile(join(projectRoot, "custom-staging", "builds.json"), "{}\n");
await mkdir(appRoot, { recursive: true });
process.chdir(appRoot);
vi.stubEnv("NODE_ENV", "production");
@@ -142,7 +147,7 @@ describe("withEve Vercel config", () => {
await resolveConfig(withEve<TestConfig>({}));
- const outputConfig = await readJsonFile(join(projectRoot, ".vercel", "output", "config.json"));
+ const outputConfig = await readJsonFile(join(appRoot, ".vercel", "output", "config.json"));
expect(outputConfig).toEqual({
routes: [
@@ -157,7 +162,7 @@ describe("withEve Vercel config", () => {
services: {
eve: {
buildCommand:
- "cd '../../..' && export EVE_INTERNAL_BUILD_OUTPUT_DIRECTORY='.eve/vercel-services/eve/.vercel/output' && export EVE_INTERNAL_HOST_BUILD_OUTPUT_DIRECTORY='../../.vercel/output' && node 'node_modules/eve/bin/eve.js' build",
+ "cd '../../..' && export EVE_INTERNAL_BUILD_OUTPUT_DIRECTORY='.eve/vercel-services/eve/.vercel/output' && export EVE_INTERNAL_HOST_BUILD_OUTPUT_DIRECTORY='.vercel/output' && node 'node_modules/eve/bin/eve.js' build",
framework: "eve",
outputDirectory: ".vercel/output",
routes: [
@@ -178,7 +183,7 @@ describe("withEve Vercel config", () => {
version: 3,
});
await expect(
- readFile(join(appRoot, ".vercel", "output", "config.json"), "utf8"),
+ readFile(join(projectRoot, ".vercel", "output", "config.json"), "utf8"),
).rejects.toThrow();
});
diff --git a/packages/eve/src/public/next/vercel-output-config.ts b/packages/eve/src/public/next/vercel-output-config.ts
index 8ceaec78f..aeb295b63 100644
--- a/packages/eve/src/public/next/vercel-output-config.ts
+++ b/packages/eve/src/public/next/vercel-output-config.ts
@@ -61,16 +61,8 @@ async function resolveVercelOutputConfigLocation(nextRoot: string): Promise<{
};
}
- if (vercelDirectory !== undefined) {
- return {
- canWriteGeneratedOutput: true,
- outputConfigPath: join(vercelDirectory, "output", "config.json"),
- projectRoot,
- };
- }
-
return {
- canWriteGeneratedOutput: Boolean(process.env.VERCEL),
+ canWriteGeneratedOutput: vercelDirectory !== undefined || Boolean(process.env.VERCEL),
outputConfigPath: join(nextRoot, VERCEL_OUTPUT_CONFIG_FILE_NAME),
projectRoot,
};