Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): Fix incorrectly adjusting tool call names in Slack status as part of markdown stripping (#1138)

Ben Pankow1bd0aa4879b3
diff --git a/.changeset/fuzzy-slack-status.md b/.changeset/fuzzy-slack-status.md
new file mode 100644
index 000000000..1656bd072
--- /dev/null
+++ b/.changeset/fuzzy-slack-status.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Preserve underscores in connection tool names shown by Slack typing status indicators.
diff --git a/packages/eve/src/public/channels/slack/limits.test.ts b/packages/eve/src/public/channels/slack/limits.test.ts
index 64d4bc174..8928f00df 100644
--- a/packages/eve/src/public/channels/slack/limits.test.ts
+++ b/packages/eve/src/public/channels/slack/limits.test.ts
@@ -33,6 +33,18 @@ describe("truncateTypingStatus", () => {
);
});
+ it("preserves underscores within tool names", () => {
+ expect(truncateTypingStatus("kernel_browser_manage_browsers")).toBe(
+ "kernel_browser_manage_browsers",
+ );
+ expect(truncateTypingStatus("kernel__browser__manage_browsers")).toBe(
+ "kernel__browser__manage_browsers",
+ );
+ expect(truncateTypingStatus("Running kernel_browser_manage_browsers now")).toBe(
+ "Running kernel_browser_manage_browsers now",
+ );
+ });
+
it("caps at the typing-status limit with a trailing ellipsis", () => {
const long = "a".repeat(SLACK_TYPING_STATUS_MAX_LENGTH + 20);
const result = truncateTypingStatus(long);
diff --git a/packages/eve/src/public/channels/slack/limits.ts b/packages/eve/src/public/channels/slack/limits.ts
index d8b6e3e6e..d8b21cf6e 100644
--- a/packages/eve/src/public/channels/slack/limits.ts
+++ b/packages/eve/src/public/channels/slack/limits.ts
@@ -129,6 +129,7 @@ function stripTypingStatusMarkdown(status: string): string {
.replace(/\[([^\]]+)\]\([^)]+\)/gu, "$1")
.replace(/`([^`]+)`/gu, "$1")
.replace(/~~([^~]+)~~/gu, "$1")
- .replace(/(\*\*|__)([^*_]+)\1/gu, "$2")
- .replace(/(^|[^\p{L}\p{N}])([*_])([^*_]+)\2(?=$|[^\p{L}\p{N}])/gu, "$1$3");
+ .replace(/(^|[^\p{L}\p{N}])(\*\*|__)([^*_]+)\2(?=$|[^\p{L}\p{N}])/gu, "$1$3")
+ .replace(/(^|[^\p{L}\p{N}*])\*([^*_]+)\*(?=$|[^\p{L}\p{N}*])/gu, "$1$2")
+ .replace(/(^|[^\p{L}\p{N}_])_([^*_]+)_(?=$|[^\p{L}\p{N}_])/gu, "$1$2");
}