The Open Framework for Building Agents
fix(eve): set framework preset only for standalone projects (#163)
Allen Zhou3f6096903021
diff --git a/.changeset/eve-framework-preset.md b/.changeset/eve-framework-preset.mdindex bdd7a0511..7eb5c2350 100644--- a/.changeset/eve-framework-preset.md+++ b/.changeset/eve-framework-preset.md@@ -2,4 +2,4 @@"eve": patch----Set the Vercel framework preset when creating new Eve projects.+Set the Eve Vercel framework preset when creating standalone Eve projects.diff --git a/packages/eve/src/setup/scaffold/index.integration.test.ts b/packages/eve/src/setup/scaffold/index.integration.test.tsindex 7096e9145..086b23fb9 100644--- a/packages/eve/src/setup/scaffold/index.integration.test.ts+++ b/packages/eve/src/setup/scaffold/index.integration.test.ts@@ -6,6 +6,7 @@ import { describe, expect, test } from "vitest";import {deriveSlackConnectorSlug,ensureChannel,+ hasVercelHostFramework,isNextJsProject,listAuthoredChannels,normalizeSlackConnectorSlug,@@ -528,7 +529,7 @@ describe("isNextJsProject", () => {await expect(isNextJsProject(projectRoot)).resolves.toBe(false);});- test("finds a next dependency in any dependency field", async () => {+ test("finds a next dependency in the Vercel framework dependency fields", async () => {const projectRoot = await createTempDir();await writeFile(join(projectRoot, "package.json"),@@ -551,6 +552,89 @@ describe("isNextJsProject", () => {});});+describe("hasVercelHostFramework", () => {+ test("reads as no host app when package.json is missing", async () => {+ const projectRoot = await createTempDir();++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(false);+ });++ test.each([+ ["Next.js", { next: "16.2.6" }],+ ["Nuxt", { nuxt: "4.3.3" }],+ ["Nuxt 3", { nuxt3: "3.19.7" }],+ ["Nuxt edge", { "nuxt-edge": "3.0.0-rc.13" }],+ ["Nuxt nightly", { "nuxt-nightly": "3.0.0-27575307.749db41" }],+ ["SvelteKit", { "@sveltejs/kit": "2.60.0" }],+ ])("recognizes %s as the root Vercel framework", async (_label, dependencies) => {+ const projectRoot = await createTempDir();+ await writeFile(+ join(projectRoot, "package.json"),+ JSON.stringify({ name: "demo", devDependencies: dependencies }),+ "utf8",+ );++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(true);+ });++ test("does not infer a host framework from ancestor node_modules alone", async () => {+ const workspaceRoot = await createTempDir();+ const projectRoot = join(workspaceRoot, "apps", "agent");+ await mkdir(projectRoot, { recursive: true });+ await writeFile(join(projectRoot, "package.json"), JSON.stringify({ name: "agent" }), "utf8");+ await mkdir(join(workspaceRoot, "node_modules", "next"), { recursive: true });+ await writeFile(+ join(workspaceRoot, "node_modules", "next", "package.json"),+ JSON.stringify({ name: "next", version: "16.2.6" }),+ "utf8",+ );++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(false);+ });++ test("ignores dependency fields Vercel framework detection does not inspect", async () => {+ const projectRoot = await createTempDir();+ await writeFile(+ join(projectRoot, "package.json"),+ JSON.stringify({+ name: "demo",+ optionalDependencies: { next: "16.2.6" },+ peerDependencies: { nuxt: "4.3.3" },+ }),+ "utf8",+ );++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(false);+ });++ test("does not scan unrelated sibling package manifests", async () => {+ const workspaceRoot = await createTempDir();+ const projectRoot = join(workspaceRoot, "apps", "agent");+ const siblingRoot = join(workspaceRoot, "apps", "web");+ await mkdir(projectRoot, { recursive: true });+ await mkdir(siblingRoot, { recursive: true });+ await writeFile(join(projectRoot, "package.json"), JSON.stringify({ name: "agent" }), "utf8");+ await writeFile(+ join(siblingRoot, "package.json"),+ JSON.stringify({ name: "web", dependencies: { next: "16.2.6" } }),+ "utf8",+ );++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(false);+ });++ test("ignores standalone eve projects", async () => {+ const projectRoot = await createTempDir();+ await writeFile(+ join(projectRoot, "package.json"),+ JSON.stringify({ name: "demo", dependencies: { eve: "0.25.0" } }),+ "utf8",+ );++ await expect(hasVercelHostFramework(projectRoot)).resolves.toBe(false);+ });+});+describe("listAuthoredChannels", () => {test("recognizes flat channel modules and folder connection modules", async () => {const projectRoot = await createTempDir();diff --git a/packages/eve/src/setup/scaffold/index.ts b/packages/eve/src/setup/scaffold/index.tsindex be2236f97..f3661b865 100644--- a/packages/eve/src/setup/scaffold/index.ts+++ b/packages/eve/src/setup/scaffold/index.ts@@ -12,6 +12,7 @@ export {SLACK_CHANNEL_DEFAULT_ROUTE,deriveSlackConnectorSlug,ensureChannel,+ hasVercelHostFramework,isNextJsProject,listAuthoredChannels,normalizeSlackConnectorSlug,diff --git a/packages/eve/src/setup/scaffold/update/channels.ts b/packages/eve/src/setup/scaffold/update/channels.tsindex ba46052ae..40196a9df 100644--- a/packages/eve/src/setup/scaffold/update/channels.ts+++ b/packages/eve/src/setup/scaffold/update/channels.ts@@ -31,12 +31,15 @@ const DEFAULT_TYPES_REACT_PACKAGE_VERSION = "__TYPES_REACT_VERSION__";const DEFAULT_TYPES_REACT_DOM_PACKAGE_VERSION = "__TYPES_REACT_DOM_VERSION__";const CONNECT_PACKAGE_NAME = "@vercel/connect";const NEXT_PACKAGE_NAME = "next";-const PACKAGE_DEPENDENCY_FIELDS = [- "dependencies",- "devDependencies",- "peerDependencies",- "optionalDependencies",+const VERCEL_HOST_FRAMEWORK_PACKAGE_NAMES = [+ "@sveltejs/kit",+ NEXT_PACKAGE_NAME,+ "nuxt",+ "nuxt3",+ "nuxt-edge",+ "nuxt-nightly",] as const;+const PACKAGE_DEPENDENCY_FIELDS = ["dependencies", "devDependencies"] as const;const USER_AUTHORED_CHANNEL_DIR = "agent/channels";const WEB_CHANNEL_PATH = "agent/channels/eve.ts";const WEB_NEXT_CONFIG_PATH = "next.config.ts";@@ -167,9 +170,22 @@ async function hasPackageDependency(return isJsonObject(parsed) && packageJsonHasDependency(parsed, dependencyName);}+async function hasAnyPackageDependency(+ packageJsonPath: string,+ dependencyNames: readonly string[],+): Promise<boolean> {+ if (!(await pathExists(packageJsonPath))) return false;++ const parsed: unknown = JSON.parse(await readFile(packageJsonPath, "utf8"));+ if (!isJsonObject(parsed)) return false;++ return dependencyNames.some((dependencyName) => packageJsonHasDependency(parsed, dependencyName));+}+/*** Whether the project already carries a Next.js app: `package.json` declares a- * `next` dependency in any dependency field. This is the exact predicate the+ * `next` dependency in the same dependency fields Vercel framework detection+ * checks. This is the exact predicate the* web scaffold skips on (`skipReason: "nextjs-project"`), so pickers can mark* Web Chat as already present precisely when scaffolding would be a no-op.* A missing `package.json` reads as "no app".@@ -178,6 +194,18 @@ export async function isNextJsProject(projectRoot: string): Promise<boolean> {return hasPackageDependency(join(projectRoot, "package.json"), NEXT_PACKAGE_NAME);}+/**+ * Whether the root app declares a Vercel framework that should own the+ * top-level deployment while eve runs as a sibling service. These match Eve's+ * current framework integrations: Next.js, Nuxt, and SvelteKit.+ */+export async function hasVercelHostFramework(projectRoot: string): Promise<boolean> {+ return hasAnyPackageDependency(+ join(projectRoot, "package.json"),+ VERCEL_HOST_FRAMEWORK_PACKAGE_NAMES,+ );+}+async function ensurePackageDependency(packageJsonPath: string,dependencyName: string,diff --git a/packages/eve/src/setup/vercel-project.test.ts b/packages/eve/src/setup/vercel-project.test.tsindex 294149d66..c7476a42a 100644--- a/packages/eve/src/setup/vercel-project.test.ts+++ b/packages/eve/src/setup/vercel-project.test.ts@@ -2,6 +2,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest";import { createPromptCommandOutput, WHIMSY_POOLS } from "#setup/cli/index.js";import { captureVercel, runVercel, type VercelCaptureResult } from "#setup/primitives/index.js";+import { hasVercelHostFramework } from "#setup/scaffold/index.js";import { HumanActionRequiredError } from "#setup/human-action.js";import type { Prompter, PrompterValue, SingleSelectOptions } from "./prompter.js";@@ -28,8 +29,17 @@ vi.mock("#setup/primitives/index.js", async (importOriginal) => {};});+vi.mock("#setup/scaffold/index.js", async (importOriginal) => {+ const original = await importOriginal<typeof import("#setup/scaffold/index.js")>();+ return {+ ...original,+ hasVercelHostFramework: vi.fn(async () => false),+ };+});+const mockedCaptureVercel = vi.mocked(captureVercel);const mockedRunVercel = vi.mocked(runVercel);+const mockedHasVercelHostFramework = vi.mocked(hasVercelHostFramework);/** Wraps stdout as a successful capture result for the mocked `captureVercel`. */const captured = (stdout: string): VercelCaptureResult => ({ ok: true, stdout });@@ -57,6 +67,8 @@ beforeEach(() => {mockedCaptureVercel.mockReset();mockedRunVercel.mockReset();mockedRunVercel.mockResolvedValue(true);+ mockedHasVercelHostFramework.mockReset();+ mockedHasVercelHostFramework.mockResolvedValue(false);});describe("listTeams", () => {@@ -460,6 +472,43 @@ describe("linkProject", () => {{ cwd: "/tmp/eve-agent", onOutput: expect.any(Function), nonInteractive: true },);});++ it("leaves the framework preset unset for host framework projects", async () => {+ mockedHasVercelHostFramework.mockResolvedValueOnce(true);+ mockedCaptureVercel+ .mockResolvedValueOnce(+ failedCapture(+ JSON.stringify({ error: { code: "not_found", message: "Project not found" } }),+ ),+ )+ .mockResolvedValueOnce(captured(JSON.stringify({ id: "prj_new", name: "my-web-agent" })));+ const { prompter } = createFakePrompter();++ await expect(+ linkProject(+ prompter,+ "/tmp/eve-web-agent",+ { kind: "new", project: "my-web-agent", team: "team-a" },+ createPromptCommandOutput(prompter.log),+ ),+ ).resolves.toBe(true);++ expect(mockedCaptureVercel).toHaveBeenNthCalledWith(+ 2,+ [+ "api",+ "/v10/projects",+ "--scope",+ "team-a",+ "--method",+ "POST",+ "--raw-field",+ "name=my-web-agent",+ "--raw",+ ],+ { cwd: "/tmp/eve-web-agent", onOutput: expect.any(Function) },+ );+ });});/** Stubs the `vercel` CLI lookups the provisioning prompts perform. */diff --git a/packages/eve/src/setup/vercel-project.ts b/packages/eve/src/setup/vercel-project.tsindex 5eaccd3e8..12da80edc 100644--- a/packages/eve/src/setup/vercel-project.ts+++ b/packages/eve/src/setup/vercel-project.ts@@ -1,6 +1,7 @@import { createPromptCommandOutput, whimsyFor } from "#setup/cli/index.js";import { HumanActionRequiredError } from "#setup/human-action.js";import { captureVercel, runVercel, type VercelCaptureFailure } from "#setup/primitives/index.js";+import { hasVercelHostFramework } from "#setup/scaffold/index.js";import pc from "picocolors";import { z } from "zod";@@ -230,22 +231,29 @@ async function createProject(onOutput: ReturnType<typeof createPromptCommandOutput>,options: VercelProjectOperationOptions,): Promise<VercelProjectReference> {- const result = await captureVercel(- [- "api",- "/v10/projects",- "--scope",- team,- "--method",- "POST",- "--raw-field",- `name=${projectName}`,- "--raw-field",- `framework=${EVE_FRAMEWORK_PRESET}`,- "--raw",- ],- { cwd: projectRoot, onOutput, signal: options.signal },- );+ const createProjectArgs = [+ "api",+ "/v10/projects",+ "--scope",+ team,+ "--method",+ "POST",+ "--raw-field",+ `name=${projectName}`,+ ];+ // Host framework integrations (Next.js, Nuxt, SvelteKit) own the top-level+ // Vercel build. Leaving the preset unset lets Vercel detect that framework+ // while vercel.json/build-output config owns the internal Eve service.+ if (!(await hasVercelHostFramework(projectRoot))) {+ createProjectArgs.push("--raw-field", `framework=${EVE_FRAMEWORK_PRESET}`);+ }+ createProjectArgs.push("--raw");++ const result = await captureVercel(createProjectArgs, {+ cwd: projectRoot,+ onOutput,+ signal: options.signal,+ });if (result.ok) {return parseProjectReference(result.stdout, `created project ${projectName}`);}