Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

fix(eve): avoid inferring tool failures from output fields (#2191)

vercel-gh-bot-2[bot]4c8ffa6d8546
diff --git a/.changeset/fair-tools-succeed.md b/.changeset/fair-tools-succeed.md
new file mode 100644
index 000000000..5c54f3cc6
--- /dev/null
+++ b/.changeset/fair-tools-succeed.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Keep successful tool calls completed when their output includes `code` and `message` fields.
diff --git a/packages/eve/src/client/message-reducer.test.ts b/packages/eve/src/client/message-reducer.test.ts
index d24c9efda..4ab2b2fbc 100644
--- a/packages/eve/src/client/message-reducer.test.ts
+++ b/packages/eve/src/client/message-reducer.test.ts
@@ -901,8 +901,10 @@ describe("defaultMessageReducer", () => {
const reducer = defaultMessageReducer();
const data = reduceServerEvents(reducer, reducer.initial(), [
createActionResultEvent({
+ rejected: true,
result: {
callId: "call_1",
+ isError: true,
kind: "tool-result",
output: JSON.stringify({
code: "TOOL_EXECUTION_DENIED",
diff --git a/packages/eve/src/protocol/message.test.ts b/packages/eve/src/protocol/message.test.ts
index fd077bc44..552177f37 100644
--- a/packages/eve/src/protocol/message.test.ts
+++ b/packages/eve/src/protocol/message.test.ts
@@ -526,6 +526,7 @@ describe("message stream protocol", () => {
const event = createActionResultEvent({
result: {
callId: "call_weather",
+ isError: true,
kind: "tool-result",
output: '{"code":"TOOL_EXECUTION_FAILED","message":"Nope"}',
toolName: "get_weather",
@@ -542,6 +543,7 @@ describe("message stream protocol", () => {
},
result: {
callId: "call_weather",
+ isError: true,
kind: "tool-result",
output: '{"code":"TOOL_EXECUTION_FAILED","message":"Nope"}',
toolName: "get_weather",
@@ -572,6 +574,27 @@ describe("message stream protocol", () => {
});
});
+ it("keeps successful action results completed when their output has code and message fields", () => {
+ const event = createActionResultEvent({
+ result: {
+ callId: "call_purchase_request",
+ kind: "tool-result",
+ output: {
+ code: "PR-2025-001",
+ message: "Purchase request created successfully.",
+ ok: true,
+ },
+ toolName: "create_purchase_request",
+ },
+ sequence: 0,
+ stepIndex: 1,
+ turnId: "turn_0",
+ });
+
+ expect(event.data.status).toBe("completed");
+ expect(event.data.error).toBeUndefined();
+ });
+
it("marks denied action results as rejected", () => {
const event = createActionResultEvent({
rejected: true,
diff --git a/packages/eve/src/protocol/message.ts b/packages/eve/src/protocol/message.ts
index f90a9d74d..0be91ee1e 100644
--- a/packages/eve/src/protocol/message.ts
+++ b/packages/eve/src/protocol/message.ts
@@ -1954,7 +1954,6 @@ function normalizeActionResultOutcome(result: RuntimeActionResult): {
readonly error?: ActionResultError;
readonly status: ActionResultStatus;
} {
- const outputError = readActionResultOutputError(result.output);
if (result.isError === true) {
return {
error: buildActionResultError(result),
@@ -1962,13 +1961,6 @@ function normalizeActionResultOutcome(result: RuntimeActionResult): {
};
}
- if (outputError !== undefined) {
- return {
- error: outputError,
- status: "failed",
- };
- }
-
return {
status: "completed",
};