The Open Framework for Building Agents
fix(eve): release stream bodies when followers stop (#2928)
OwenKephart4ee671565be5
diff --git a/.changeset/calm-workflow-stream-followers.md b/.changeset/calm-workflow-stream-followers.mdnew file mode 100644index 000000000..3b4e4ca03--- /dev/null+++ b/.changeset/calm-workflow-stream-followers.md@@ -0,0 +1,5 @@+---+"eve": patch+---++Release local Workflow stream listeners when client stream followers reconnect or stop.diff --git a/packages/eve/src/client/open-stream.test.ts b/packages/eve/src/client/open-stream.test.tsnew file mode 100644index 000000000..dd4a1e0e9--- /dev/null+++ b/packages/eve/src/client/open-stream.test.ts@@ -0,0 +1,39 @@+import { afterEach, describe, expect, it, vi } from "vitest";++import { openStreamBody } from "./open-stream.js";+import { EVE_MESSAGE_STREAM_VERSION, EVE_STREAM_VERSION_HEADER } from "#protocol/message.js";++afterEach(() => {+ vi.unstubAllGlobals();+});++describe("openStreamBody", () => {+ it("cancels an opened response body when the stream follower closes", async () => {+ const cancel = vi.fn();+ const body = new ReadableStream<Uint8Array>({ cancel });+ let signal: AbortSignal | undefined;+ vi.stubGlobal(+ "fetch",+ vi.fn(async (_input: Parameters<typeof fetch>[0], init?: RequestInit) => {+ signal = init?.signal ?? undefined;+ return new Response(body, {+ headers: { [EVE_STREAM_VERSION_HEADER]: EVE_MESSAGE_STREAM_VERSION },+ status: 200,+ });+ }),+ );++ const connection = await openStreamBody({+ host: "https://agent.example",+ resolveHeaders: () => Promise.resolve(new Headers()),+ sessionId: "session_1",+ startIndex: 0,+ });+ connection.close();+ connection.close();+ await Promise.resolve();++ expect(cancel).toHaveBeenCalledOnce();+ expect(signal?.aborted).toBe(true);+ });+});diff --git a/packages/eve/src/client/open-stream.ts b/packages/eve/src/client/open-stream.tsindex cf7096439..f9d1e3016 100644--- a/packages/eve/src/client/open-stream.ts+++ b/packages/eve/src/client/open-stream.ts@@ -274,9 +274,19 @@ export async function openStreamBody(if (!response.body) {throw new ClientError(response.status, "Response body is null.", response.headers);}+ let closed = false;return {body: response.body,- close: () => connectionController.abort(),+ close: () => {+ if (closed) return;+ closed = true;+ // Aborting a fetch after its response has resolved does not reliably+ // propagate cancellation through every local HTTP transport. Cancel+ // the body as well so its server-side Workflow stream releases its+ // live chunk and close listeners before a reconnect opens another.+ response.body?.cancel().catch(() => {});+ connectionController.abort();+ },streamVersion: readMessageStreamVersion(response.headers),tailIndex: parseTailIndexHeader(response.headers),};