Skip to content

armgit / eve

Public Imported from GitHub
0

The Open Framework for Building Agents

Fix manual compaction with step-scoped dynamic models (#3438)

roboeve[bot]51648e3a75bc
diff --git a/.changeset/dynamic-compaction-model.md b/.changeset/dynamic-compaction-model.md
new file mode 100644
index 000000000..0efa11bf1
--- /dev/null
+++ b/.changeset/dynamic-compaction-model.md
@@ -0,0 +1,5 @@
+---
+"eve": patch
+---
+
+Manual compaction now resolves step-scoped dynamic models before summarizing a session.
diff --git a/packages/eve/src/harness/compaction/step.ts b/packages/eve/src/harness/compaction/step.ts
index 21af2f0a4..b9176bfea 100644
--- a/packages/eve/src/harness/compaction/step.ts
+++ b/packages/eve/src/harness/compaction/step.ts
@@ -15,6 +15,7 @@ import type { Publish } from "#harness/session-machine/commit.js";
import type { SessionAuthContext } from "#channel/types.js";
import type { Step } from "#harness/step/context.js";
import { activeTurnId, type TurnPosition } from "#harness/session-machine/view.js";
+import { stepStartedForResolvers } from "#harness/session-machine/resolver-events.js";
import {
buildGatewayAttributionHeaders,
resolveEffectiveRuntimeModel,
@@ -49,6 +50,19 @@ export async function compactHistory(step: Step): Promise<StepResult> {
const { config } = step;
if (step.session.history.length > 0) {
try {
+ if (step.ctx !== undefined && config.dispatchDynamicModelEvent !== undefined) {
+ const position = step.position();
+ await config.dispatchDynamicModelEvent({
+ ctx: step.ctx,
+ event: stepStartedForResolvers({
+ modelId: step.session.agent.modelReference?.id ?? "dynamic",
+ sequence: position.sequence,
+ stepIndex: position.stepIndex,
+ turnId: activeTurnId(position),
+ }),
+ messages: validateHarnessModelMessages(step.projectHistory(step.session.history)),
+ });
+ }
const resolvedModel = await resolveEffectiveRuntimeModel({
config,
ctx: step.ctx,
diff --git a/packages/eve/src/harness/tool-loop.test.ts b/packages/eve/src/harness/tool-loop.test.ts
index 0704c3c2a..7e0e0c8a5 100644
--- a/packages/eve/src/harness/tool-loop.test.ts
+++ b/packages/eve/src/harness/tool-loop.test.ts
@@ -8296,6 +8296,61 @@ describe("createToolLoopHarness", () => {
]);
});
+ it("resolves a step-scoped dynamic model before manual compaction", async () => {
+ const compactedHistory: HarnessModelMessage[] = [
+ createFrameworkUserMessage("context.compaction", "Summary of our conversation so far:"),
+ { content: "summary", role: "assistant" },
+ ];
+ vi.mocked(compactMessages).mockResolvedValue(compactedHistory);
+
+ const selectedModel = new MockLanguageModelV3({
+ modelId: "gpt-5",
+ provider: "openai.chat",
+ });
+ const dispatchDynamicModelEvent: NonNullable<
+ ToolLoopHarnessConfig["dispatchDynamicModelEvent"]
+ > = vi.fn(async ({ ctx, event }) => {
+ expect(event.type).toBe("step.started");
+ ctx.setVirtualContext(LiveStepDynamicModelSelectionKey, {
+ model: selectedModel,
+ reference: {
+ contextWindowTokens: 200_000,
+ id: "openai/gpt-5",
+ },
+ });
+ });
+ const { emit, events } = createEventCollector();
+ const runStep = createToolLoopHarness(
+ createTestConfig(emit, {
+ compactOnly: true,
+ dispatchDynamicModelEvent,
+ }),
+ );
+ const session = createTestSession({
+ agent: {
+ dynamicModel: true,
+ system: "You are a test assistant.",
+ tools: [{ description: "Adds numbers", name: "add", inputSchema: { type: "object" } }],
+ },
+ history: [
+ { content: "old message", kind: "user" as const, role: "user" },
+ { content: "old reply", role: "assistant" },
+ ],
+ });
+ const ctx = new ContextContainer();
+
+ const result = await contextStorage.run(ctx, () => runStep(session));
+
+ expect(result.next).toBeNull();
+ expect(result.session.history).toEqual(compactedHistory);
+ expect(dispatchDynamicModelEvent).toHaveBeenCalledOnce();
+ expect(getCompatibilityEventTypes(events)).toEqual([
+ "compaction.requested",
+ "compaction.completed",
+ "session.waiting",
+ ]);
+ });
+
it("returns an empty session to its waiting boundary after manual compaction", async () => {
const { emit, events } = createEventCollector();
const runStep = createToolLoopHarness(